Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

2018-07-17 Thread Joseph D. Darcy
PS This change is part of preparatory work to allow stricter checking of serial-related properties by the javac -Xlint:serial checks. So in the fullness of time, the work intended to be done under JDK-8202056: "Expand serial warning to check for bad overloads of serial-related methods" will ch

Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

2018-07-17 Thread Lance Andersen
Hi Joe > On Jul 17, 2018, at 7:32 PM, Joseph D. Darcy wrote: > > Hi Lance, > > On 7/17/2018 4:25 PM, Lance Andersen wrote: >> Hi Joe, >> >> +1 >> >> I assume we do not need to add a specific test for this clean-up? > > I put a "noreg-hard" label on the bug; I don't think it merits a dedicated

Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

2018-07-17 Thread Joseph D. Darcy
Hi Lance, On 7/17/2018 4:25 PM, Lance Andersen wrote: Hi Joe, +1 I assume we do not need to add a specific test for this clean-up? I put a "noreg-hard" label on the bug; I don't think it merits a dedicated test. Thanks, -Joe

Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

2018-07-17 Thread Lance Andersen
Hi Joe, +1 I assume we do not need to add a specific test for this clean-up? > On Jul 17, 2018, at 7:19 PM, joe darcy wrote: > > Hello, > > The nested enum java.time.temporal.JulianFields.Field declare a > serialVersionUID field. Per the serialization spec, a serialVersionUID field > in an

JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

2018-07-17 Thread joe darcy
Hello, The nested enum java.time.temporal.JulianFields.Field declare a serialVersionUID field. Per the serialization spec, a serialVersionUID field in an enum is ignored. "The process by which enum constants are serialized cannot be customized: any class-specific writeObject, readObject, re