Re: Code Review Request for Bug #7089443

2011-12-13 Thread Darryl Mocek
Charles, thanks for the notification. I was scratching my head trying to figure out why I was seeing the old code and not the new. Being new to Mercurial and after some digging, I realized I was using 'up' the way I used it in Subversion (pull from the repo and update the local copy), th

Re: Code Review Request for Bug #7089443

2011-12-12 Thread Charles Lee
On 12/13/2011 11:02 AM, David Holmes wrote: It seems that 7089443 is fixed as a by-product of your changes Charles - provided getnameinfo does the right thing :) David -- On 13/12/2011 12:26 PM, Charles Lee wrote: On 12/13/2011 06:50 AM, Darryl Mocek wrote: Hello. Please review this patc

Re: Code Review Request for Bug #7089443

2011-12-12 Thread David Holmes
It seems that 7089443 is fixed as a by-product of your changes Charles - provided getnameinfo does the right thing :) David -- On 13/12/2011 12:26 PM, Charles Lee wrote: On 12/13/2011 06:50 AM, Darryl Mocek wrote: Hello. Please review this patch to fix InetAddress.getLocalHost fails if th

Re: Code Review Request for Bug #7089443

2011-12-12 Thread Charles Lee
On 12/13/2011 06:50 AM, Darryl Mocek wrote: Hello. Please review this patch to fix InetAddress.getLocalHost fails if the host name is larger HOST_NAME_MAX. The fix is to use strncpy, and supply the max length the host name can be, instead of using strcpy. There is no test supplied for this f

Code Review Request for Bug #7089443

2011-12-12 Thread Darryl Mocek
Hello. Please review this patch to fix InetAddress.getLocalHost fails if the host name is larger HOST_NAME_MAX. The fix is to use strncpy, and supply the max length the host name can be, instead of using strcpy. There is no test supplied for this fix as I was unable to set the host name larg