Re: 8251160: Fix "no comment" warnings in java.logging

2020-08-14 Thread Mandy Chung
On 8/14/20 2:17 AM, Daniel Fuchs wrote: new webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8251160/webrev.01/index.html +1 CSR updated as well: https://bugs.openjdk.java.net/browse/JDK-8251534 Reviewed. Mandy

Re: 8251160: Fix "no comment" warnings in java.logging

2020-08-14 Thread Daniel Fuchs
Hi Mandy, Thanks for looking at this! On 13/08/2020 20:48, Mandy Chung wrote: Level The javadoc for readResolve seems internal implementation details. Would it be sufficient to say: “Returns a {@code Level} instance with the same {@code name},  {@code value}, and {@code resourceBundleName}

Re: 8251160: Fix "no comment" warnings in java.logging

2020-08-13 Thread Mandy Chung
On 8/13/20 5:00 AM, Daniel Fuchs wrote: Hi, Please find below a doc-only fix for: 8251160: Fix "no comment" warnings in java.logging https://bugs.openjdk.java.net/browse/JDK-8251160 CSR: https://bugs.openjdk.java.net/browse/JDK-8251534 webrev: http://cr.openjdk.java.n

Re: 8251160: Fix "no comment" warnings in java.logging

2020-08-13 Thread Lance Andersen
Hi Daniel, The changes look good. I added myself as a reviewer to the CSR Best Lance > On Aug 13, 2020, at 8:00 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a doc-only fix for: > > 8251160: Fix "no comment" warnings in java.logging > https:

8251160: Fix "no comment" warnings in java.logging

2020-08-13 Thread Daniel Fuchs
Hi, Please find below a doc-only fix for: 8251160: Fix "no comment" warnings in java.logging https://bugs.openjdk.java.net/browse/JDK-8251160 CSR: https://bugs.openjdk.java.net/browse/JDK-8251534 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8251160/webrev.00/ The documentat