53b0b0653256923586c7f4ec9e3cfac3
Stats: 26 lines in 2 files changed: 11 ins; 14 del; 1 mod
8250678: ModuleDescriptor.Version parsing treats empty segments inconsistently
Reviewed-by: mchung, alanb
-
PR: https://git.openjdk.java.net/jdk/pull/5679
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three sections,
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three sections,
On Fri, 5 Nov 2021 16:51:02 GMT, Mandy Chung wrote:
> I would suggest to create a separate issue to follow up the spec
> clarification and keep this PR to fix the implementation.
>
> The version parsing code is tricky. The fix is straight-forward, just moving
> the check of the delimiters as t
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three sections,
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three sections,
On Tue, 2 Nov 2021 20:09:21 GMT, Mandy Chung wrote:
> I reviewed the change. It is reasonable to fix the parsing of the pre-release
> version and the build version be consistent with parsing of the version
> number which currently skips consecutive delimiters.
>
> The spec is unclear on whethe
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three sections,
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold @AlanBateman Are you aware of my comment?
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold @AlanBateman Could you please reply to th
On Mon, 27 Sep 2021 08:22:02 GMT, Alan Bateman wrote:
>> Could you please review the 8250678 bug fixes?
>>
>> The `parse` method of ModuleDescriptor.Version class behaves incorrectly
>> when the input string contains consecutive delimiters.
>>
>> The `parse` method treats strings as three sect
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold (@AlanBateman ) Could you tell me how man
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold I waited for about a week, but I haven't
On Thu, 30 Sep 2021 11:26:12 GMT, Masanori Yano wrote:
> @mbreinhold Could you comment on this pull request?
This is somewhat tricky code. I’ll take a look, but give me a few days.
-
PR: https://git.openjdk.java.net/jdk/pull/5679
On Mon, 27 Sep 2021 08:22:02 GMT, Alan Bateman wrote:
>> Could you please review the 8250678 bug fixes?
>>
>> The `parse` method of ModuleDescriptor.Version class behaves incorrectly
>> when the input string contains consecutive delimiters.
>>
>> The `parse` method treats strings as three sect
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three sections,
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three sections,
: ModuleDescriptor.Version parsing treats empty segments
inconsistently
Changes: https://git.openjdk.java.net/jdk/pull/5679/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5679&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8250678
Stats: 26 lines in 2 files cha
ano
> >
> > > -Original Message-
> > > From: Yano, Masanori
> > > Sent: Wednesday, November 4, 2020 6:03 PM
> > > To: 'core-libs-dev@openjdk.java.net'
> > >
> > > Subject: 8250678: ModuleDescriptor.Version parsing treats
Hello,
Please reply if anyone can be a sponsor.
Regards,
Masanori Yano
> -Original Message-
> From: Yano, Masanori
> Sent: Wednesday, December 23, 2020 5:01 PM
> To: 'core-libs-dev@openjdk.java.net'
> Subject: [PING] RE: 8250678: ModuleDescriptor.Ver
Hello,
Please reply if anyone can be a sponsor.
Regards,
Masanori Yano
> -Original Message-
> From: Yano, Masanori
> Sent: Wednesday, November 4, 2020 6:03 PM
> To: 'core-libs-dev@openjdk.java.net'
> Subject: 8250678: ModuleDescriptor.Version pars
Hello.
I would like to contribute for JDK-8250678.
The 'parse' method of ModuleDescriptor.Version class behaves incorrectly
when the input string contains consecutive delimiters.
The 'parse' method treats strings as three sections, but the parsing method
differs between the method for the vers
22 matches
Mail list logo
