Changeset: 6f9515a9519f
Author:alanb
Date: 2013-10-22 11:43 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f9515a9519f
8021257: com.sun.corba.se.** should be on restricted package list
Reviewed-by: chegar, coffeys, smarks, mullan
Contributed-by: alan.bate...@oralce.com
Changeset: 52ad44f9a3ec
Author:alanb
Date: 2013-10-22 11:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/52ad44f9a3ec
8021257: com.sun.corba.se.** should be on restricted package list
Reviewed-by: chegar, coffeys, smarks
Contributed-by: alan.bate...@oralce.com
On 22/10/2013 01:39, Stuart Marks wrote:
Looks fine, except one tiny issue.
In javax/rmi/CORBA/Stub.java, createDelegate() returns Object, and in
the static initializer it's cast to Object before being assigned to
Object stubDelegateInstance. It's sort-of in parallel with the other
cases that
Looks fine, except one tiny issue.
In javax/rmi/CORBA/Stub.java, createDelegate() returns Object, and in the static
initializer it's cast to Object before being assigned to Object
stubDelegateInstance. It's sort-of in parallel with the other cases that cast it
to some other type, but a cast to
Hi Alan, Chris,
yes, very happy to see the CORBA layers below the pure omg CORBA API
packages being restricted.
The reflection changes in the API layer look good, also.
regards
Mark
On 21/10/2013 13:45, Chris Hegarty wrote:
Very nice Alan.
I have reviewed all the changes, and am happy to
Looks good to me too Alan. Thanks for taking care of this. After
studying the class delegation code, it's now making sense to me why the
initial package restriction failed.
regards,
Sean.
On 21/10/13 13:45, Chris Hegarty wrote:
Very nice Alan.
I have reviewed all the changes, and am happy to
Very nice Alan.
I have reviewed all the changes, and am happy to be listed as reviewer
for both changesets, though Mark or Sean should also probably take a
look at the corba changes.
-Chris.
On 21/10/2013 12:14, Alan Bateman wrote:
Back in June, Sean Coffey had an attempt to add com.sun.co
Back in June, Sean Coffey had an attempt to add com.sun.corba.se.impl.**
to the restricted package list. Problems arose and the change had to be
backed out ([1] [2]]).
Mark Sheppard and I have been looking at this one again and we would
like to make a second attempt at this. The proposed pat