Changeset: 3c524deb8431
Author:lancea
Date: 2011-12-02 19:33 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431
7116445: Miscellaneous warnings in the JDBC/RowSet classes
Reviewed-by: smarks, chegar
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src
Hi Stuart,
On Dec 2, 2011, at 3:45 PM, Stuart Marks wrote:
> Hi Lance,
>
> I'm OK with postponing the @Deprecated work, and doing a separate pass for
> @Deprecated, including the com.sun.* stuff at that time.
OK, will do that separately
>
> There's enough stuff in this changeset already. I th
Hi Lance,
I'm OK with postponing the @Deprecated work, and doing a separate pass for
@Deprecated, including the com.sun.* stuff at that time.
There's enough stuff in this changeset already. I think we're better off
getting it in now than putting more stuff in and getting it reviewed again. I
On Dec 2, 2011, at 10:54 AM, David Schlosnagle wrote:
> On Fri, Dec 2, 2011 at 8:19 AM, Lance Andersen - Oracle
> wrote:
> Adding @Deprecated changes the signatures so I need to coordinate any changes
> as it will result in TCK signature failures. This is something I will most
> likely do a
On Fri, Dec 2, 2011 at 8:19 AM, Lance Andersen - Oracle <
lance.ander...@oracle.com> wrote:
> Adding @Deprecated changes the signatures so I need to coordinate any
> changes as it will result in TCK signature failures. This is something I
> will most likely do as part of the JDBC 4.2 work after
Here is the diff for DriverManager, I won't be pushing another webrev unless
the word is to go ahead and add @Deprecated to the com/* classes of the RowSet
RI or there is another change requested that is more detailed:
dhcp-adc-twvpn-2-vpnpool-10-154-44-9:sql lanceandersen$ hg diff
DriverManage
Hi Dave,
thanks for the feedback. Adding @Deprecated changes the signatures so I need
to coordinate any changes as it will result in TCK signature failures. This is
something I will most likely do as part of the JDBC 4.2 work after giving the
JDBC EG a chance for input.
There are several pla
On Thu, Dec 1, 2011 at 10:08 PM, Lance Andersen - Oracle
wrote:> Sadly, once i start digging, i
found more changes :-(>> Here are the latest revisions with the
additions/changes since the last review,
http://cr.openjdk.java.net/~lancea/7116445/webrev.03:
Lance,
I'd suggest also including the att
Sadly, once i start digging, i found more changes :-(
Here are the latest revisions with the additions/changes since the last review,
http://cr.openjdk.java.net/~lancea/7116445/webrev.03:
The modified files since the last diff:
src/share/classes/com/sun/rowset:
CachedRowSetImpl.java
Jdbc
On 12/1/11 1:21 PM, Lance Andersen - Oracle wrote:
I will make the couple changes above for the unboxing and generate 1 last
webrev and then push it once I get the final green light...
Leaving in the breaks and the arraycopy is probably the right thing to do.
I don't think you need to generate
Hi Stuart,
On Dec 1, 2011, at 4:10 PM, Stuart Marks wrote:
> Hi Lance,
>
> Thanks for your patience. I was doing a lot of organizing this morning and
> I'm finally getting back to reviewing.
Totally understand. I appreciate your time on this as while some of this seems
simple, it is a lot of
Hi Lance,
Thanks for your patience. I was doing a lot of organizing this morning and I'm
finally getting back to reviewing.
Overall the changeset looks fine. I have just a few questions. You might or
might not want to make further changes, but in any case I'm OK if you were to
go ahead and p
Thank you for the review Chris. Once I hear back from Stuart, I will push
these changes back.
Best
Lance
On Dec 1, 2011, at 11:17 AM, Chris Hegarty wrote:
> Skimming over this, I think it looks fine.
>
> -Chris.
>
> On 01/12/2011 01:46, Lance Andersen - Oracle wrote:
>> Here is another round
Skimming over this, I think it looks fine.
-Chris.
On 01/12/2011 01:46, Lance Andersen - Oracle wrote:
Here is another round of diffs as I found more warnings after I changed lint
levels
http://cr.openjdk.java.net/~lancea/7116445/webrev.02/
For SQLOutputImpl.java, as I found no easy way to
Here is another round of diffs as I found more warnings after I changed lint
levels
http://cr.openjdk.java.net/~lancea/7116445/webrev.02/
For SQLOutputImpl.java, as I found no easy way to avoid the errors without
changing the constructor generic types, I went the route of suppressing the
war
On 11/30/11 10:43 AM, Lance Andersen - Oracle wrote:
Hi Stuart,
Thanks for the feedback.
Great, thanks for the updates. Further comments below.
* In CachedRowSetWriter.java, cols is changed from Vector to Vector.
This is fine but there's now a redundant cast (Integer)cols.get(i) at line
75
Hi Stuart,
Thanks for the feedback.
On Nov 29, 2011, at 7:31 PM, Stuart Marks wrote:
> On 11/29/11 10:02 AM, Lance Andersen - Oracle wrote:
>> Please review the following changes for JDBC area as part of the warnings
>> clean up day. I will not be able to participate on Thursday so I wanted to
cc'ing to jdk8-dev so that people know these classes have already been
tackled.
David
On 30/11/2011 4:02 AM, Lance Andersen - Oracle wrote:
Please review the following changes for JDBC area as part of the warnings clean
up day. I will not be able to participate on Thursday so I wanted to try
On 11/29/11 10:02 AM, Lance Andersen - Oracle wrote:
Please review the following changes for JDBC area as part of the warnings clean
up day. I will not be able to participate on Thursday so I wanted to try and
get this done ahead of time.
The changes can be found at
http://cr.openjdk.java.ne
Please review the following changes for JDBC area as part of the warnings clean
up day. I will not be able to participate on Thursday so I wanted to try and
get this done ahead of time.
The changes can be found at
http://cr.openjdk.java.net/~lancea/7116445/webrev.00/
Best
Lance
Lance Anderse
20 matches
Mail list logo
