Re: 7116954: Misc warnings in java.beans/java.beans.context

2012-01-03 Thread Andrey Pikalev
Typically JavaBeans changes went into Swing (now AWT) gate. I don't think this really matter where to push this time assuming the changes will be propagated to AWT repo in a few weeks. Thanks, Andrey. On 12/1/2011 9:04 PM, Alan Bateman wrote: On 01/12/2011 16:33, Maurizio Cimadamore w

Re: 7116954: Misc warnings in java.beans/java.beans.context

2011-12-02 Thread Maurizio Cimadamore
On 02/12/11 10:31, Sergey Malenkov wrote: I approve changes with a small update. java/beans/VetoableChangeSupport.java: -Hashtable children = (Hashtable) fields.get("children", null); +@SuppressWarnings("unchecked") +Hashtable children = (Hashtable)fields.get("childre

hg: jdk8/tl/jdk: 7116954: Misc warnings in java.beans/java.beans.context

2011-12-01 Thread maurizio . cimadamore
Changeset: 89130611b178 Author:mcimadamore Date: 2011-12-01 18:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89130611b178 7116954: Misc warnings in java.beans/java.beans.context Summary: Remove generic warnings form java.beans and java.beans.context Reviewed-by: alanb

Re: 7116954: Misc warnings in java.beans/java.beans.context

2011-12-01 Thread Maurizio Cimadamore
On 01/12/11 17:13, Andrey Pikalev wrote: Typically JavaBeans changes went into Swing (now AWT) gate. I don't think this really matter where to push this time assuming the changes will be propagated to AWT repo in a few weeks. I'm thinking to push the changeset to TL - if you feel otherwise pleas

Re: 7116954: Misc warnings in java.beans/java.beans.context

2011-12-01 Thread Alan Bateman
On 01/12/2011 16:33, Maurizio Cimadamore wrote: Updated version [1]. Changes: *) Beans.java:184 - generified PrivilegedAction *) Beans.java:284 - generified PrivilegedAction *) NameGenerator.java:108 - changed Object to Integer and removed following cast *) Introspector.java: added new fake lo

Re: 7116954: Misc warnings in java.beans/java.beans.context

2011-12-01 Thread Maurizio Cimadamore
Updated version [1]. Changes: *) Beans.java:184 - generified PrivilegedAction *) Beans.java:284 - generified PrivilegedAction *) NameGenerator.java:108 - changed Object to Integer and removed following cast *) Introspector.java: added new fake local variable to reduce scope of @SuppressWarning

Re: 7116954: Misc warnings in java.beans/java.beans.context

2011-12-01 Thread Chris Hegarty
Looks good. Trivially, - NameGenerator.java L108 'size' could be an Integer and avoid subsequent cast. - SimpleBeanInfo.java L121, < PrivilegedAction --- > PrivilegedAction -Chris. On 01/12/2011 15:07, Maurizio Cimadamore wrote: Hi, I tried to cleanup as many warnings as p

Re: 7116954: Misc warnings in java.beans/java.beans.context

2011-12-01 Thread Alan Bateman
On 01/12/2011 15:07, Maurizio Cimadamore wrote: Hi, I tried to cleanup as many warnings as possible in java.beans/java.beans.context [1]. There were a few places (esp. in java.beans.context) in which I had to suppress rawtypes warnings as the raw types were in method signatures of what looked

7116954: Misc warnings in java.beans/java.beans.context

2011-12-01 Thread Maurizio Cimadamore
Hi, I tried to cleanup as many warnings as possible in java.beans/java.beans.context [1]. There were a few places (esp. in java.beans.context) in which I had to suppress rawtypes warnings as the raw types were in method signatures of what looked like public API. Feedback welcome. [1] - http: