答复: Demo for Parallel Core Collection API

2014-02-04 Thread Tristan Yan
Thank you Paul. I was told maybe we will target this on 8u20 if we can't catch 8. Let's do the open review first. http://cr.openjdk.java.net/~tyan/JDK-8033358/webrev.02/ Fibonacci: Update as you suggested. Test shows parallel version is faster than sequential version when the input is greater

答复: Demo for Parallel Core Collection API

2014-02-03 Thread Tristan Yan
Hi Paul I know this may be a little bit late. But I am still asking you review this. http://cr.openjdk.java.net/~tyan/JDK-8033358/webrev.01/ This is a whole demo code include the stream demo code you reviewed before also included parallel part. There is one other parallel demo that Paul has alre

答复: Demo for Parallel Core Collection API

2013-11-11 Thread Tristan Yan
Thank you Paul There is one minor question, I can't compile one of your code, then I realized that's because grouping by signature is public static Collector> groupingBy(Function classifier, Collector downstream) Which makes me wonder why we need type A here, why we don't use variant here

答复: Demo for Parallel Core Collection API

2013-11-11 Thread Tristan Yan
Also there is one more question I missed You suggested ""ParallelCore" is not a very descriptive name. Suggest "streams"." 1) yes we agree this demo is not for parallel computation per se 2) but we do not have a clear demo for parallel computation 3) if we are to rename this, we need to develop a

答复: Demo for Parallel Core Collection API

2013-11-11 Thread Tristan Yan
Hi Paul you have comments "suggest that all streams are sequential. There is an inconsistency in the use and in some cases it is embedded in other stream usages." We do not really understand what exactly is meant, could you elaborate a little bit. Is it because we want to show ppl that we shoul