Re: [jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-18 Thread Ivan Gerasimov
On 18.08.2016 21:27, Claes Redestad wrote: Rather than breaking into Reflection we should likely add an internally public API with a more well-defined contract, ensuring that it addresses arrays, primitives etc, and then Reflection, VerifyAccess and ObjectStream could consolidate their use to

Re: [jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-18 Thread Claes Redestad
On 2016-08-18 20:23, Ivan Gerasimov wrote: Hi Claes! Thank you for looking into this. On 18.08.2016 15:25, Claes Redestad wrote: On 2016-08-16 19:20, Ivan Gerasimov wrote: ObjectStreamClass: I wonder if the entire getPackageName is replaceable with Class.getPackageName()? If so, ditch the

Re: [jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-18 Thread Ivan Gerasimov
Hi Claes! Thank you for looking into this. On 18.08.2016 15:25, Claes Redestad wrote: On 2016-08-16 19:20, Ivan Gerasimov wrote: ObjectStreamClass: I wonder if the entire getPackageName is replaceable with Class.getPackageName()? If so, ditch the method completely and use Class.getPackageNam

Re: [jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-18 Thread Aleksey Shipilev
On 08/16/2016 08:20 PM, Ivan Gerasimov wrote: > Here is the updated webrev: > http://cr.openjdk.java.net/~igerasim/8163517/01/webrev/ Looks good to me. -Aleksey

Re: [jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-18 Thread Claes Redestad
On 2016-08-16 19:20, Ivan Gerasimov wrote: ObjectStreamClass: I wonder if the entire getPackageName is replaceable with Class.getPackageName()? If so, ditch the method completely and use Class.getPackageName everywhere. This may complicate backporting to JDK 8 though. Unfortunately, Class.ge

Re: [jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-16 Thread Ivan Gerasimov
Thank you Aleksey for your careful review! On 16.08.2016 16:08, Aleksey Shipilev wrote: On 08/16/2016 03:53 PM, Ivan Gerasimov wrote: BUGURL: https://bugs.openjdk.java.net/browse/JDK-8163517 WEBREV: http://cr.openjdk.java.net/~igerasim/8163517/00/webrev/ Both ObjectInputStream and ObjectOutpu

Re: [jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-16 Thread Ivan Gerasimov
Thanks Roger for the review and the pointer! I'll follow the process. With kind regards, Ivan On 16.08.2016 17:30, Roger Riggs wrote: Hi Ivan, Look fine. Remember to use the enhancement process[1] to get approval for this enhancement. Roger [1] http://openjdk.java.net/projects/jdk9/fc-e

Re: [jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-16 Thread Roger Riggs
Hi Ivan, Look fine. Remember to use the enhancement process[1] to get approval for this enhancement. Roger [1] http://openjdk.java.net/projects/jdk9/fc-extension-process On 8/16/2016 8:53 AM, Ivan Gerasimov wrote: Hello! Here's a cleanup pass through the code in java.io package. Would yo

Re: [jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-16 Thread Aleksey Shipilev
On 08/16/2016 03:53 PM, Ivan Gerasimov wrote: > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8163517 > WEBREV: http://cr.openjdk.java.net/~igerasim/8163517/00/webrev/ Both ObjectInputStream and ObjectOutputStream can use auto-unboxing in these blocks? 1271 if (result.booleanValue()) {

[jdk9] RFR: 8163517: Various cleanup in java.io code

2016-08-16 Thread Ivan Gerasimov
Hello! Here's a cleanup pass through the code in java.io package. Would you please help review? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8163517 WEBREV: http://cr.openjdk.java.net/~igerasim/8163517/00/webrev/ With kind regards, Ivan