Re: Maintenance Reviews was: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-27 Thread Jaroslav Tulach
Eamonn McManus wrote: > I can act as sponsor for this change. Excellent, thanks Eamonn. > Can you say a bit more about the rationale here? I understand why > SPIs should be defined with abstract classes rather than interfaces, > but ServiceLoader already supports both classes and interfaces. I w

Re: Maintenance Reviews was: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-23 Thread Jaroslav Tulach
Dne Wednesday 22 October 2008 18:55:03 Eamonn McManus napsal(a): > Jaroslav, > > I can act as sponsor for this change. Excellent. I'll prepare better description of the change over the weekend. Thanks. -jst > > My understanding from looking at the code is that the change is as follows. > Today

Re: Maintenance Reviews was: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-22 Thread Eamonn McManus
Jaroslav, I can act as sponsor for this change. My understanding from looking at the code is that the change is as follows. Today, you can supply an implementation of the SPI com.example.Foo by putting a jar file in the classpath (etc) that contains a file called META-INF/services/com.example.

Re: Technical review was: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-21 Thread Alan Bateman
Jaroslav Tulach wrote: OK, so now, after Mark's reply, we know that it is possible to include such little, compatible extensions of an existing APIs into the Maintenance JSR. Good. Now please tell me, what shall I do to make it happen[1]? Will Mark or someone else from core-libs@ do a technical

Technical review was: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-21 Thread Jaroslav Tulach
OK, so now, after Mark's reply, we know that it is possible to include such little, compatible extensions of an existing APIs into the Maintenance JSR. Good. Now please tell me, what shall I do to make it happen[1]? Will Mark or someone else from core-libs@ do a technical review of my patch? By wh

Re: Maintenance Reviews was: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-17 Thread Jaroslav Tulach
Thanks for the clarification, Mark. I've heard about some umbrella JSR for each release of the JDK before and I was hoping that my proposed change could be covered as part of it. Thanks for confirming that such aggregation is possible. > With regard to this particular proposal, as the original au

Re: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-16 Thread Mark Reinhold
> Date: Fri, 17 Oct 2008 05:56:13 +1000 > From: [EMAIL PROTECTED] > If this is a modification to the API not just a patch for the > implementation then the short answer is No. Well, not exactly. > API changes have to be made > via a JSR. ... or in a M

Re: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-16 Thread David Holmes - Sun Microsystems
Hi Jaroslav, If this is a modification to the API not just a patch for the implementation then the short answer is No. API changes have to be made via a JSR. David Holmes On 17/10/08 03:38 AM, Jaroslav Tulach wrote: Hi. I can imagine, dear core-libs members, that you are all busy with your

Re: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-16 Thread Jaroslav Tulach
Hi. I can imagine, dear core-libs members, that you are all busy with your jobs, however at least give me hope: Can I get my patch into the OpenJDK in reasonable timeframe or not? Thanks in advance for your reply. -jst Jaroslav Tulach wrote: > Proposal: Enhance ServiceLoader to understand factor

[PATCH] Enhance ServiceLoader to understand factory methods

2008-10-04 Thread Jaroslav Tulach
Proposal: Enhance ServiceLoader to understand factory methods Justification: A lot of our services in NetBeans are final classes. Still, we would like to use the META-INF/services registration to register their providers. Currently this does not work, we either need to unfinalize the classes (w