On Mon, 13 Jun 2022 07:24:52 GMT, Matthias Baesken wrote:
>> We still handle at a number of places ancient historic _MSC_VER versions of
>> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
>> This should be cleaned up, as long as it is not 3rd party code that we don't
>> want
On Thu, 9 Jun 2022 11:37:21 GMT, Matthias Baesken wrote:
> We still handle at a number of places ancient historic _MSC_VER versions of
> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
> This should be cleaned up, as long as it is not 3rd party code that we don't
> want to ad
On Wed, 18 May 2022 15:44:10 GMT, Quan Anh Mai wrote:
> This patch backs out the changes made by
> [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and
> [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there
> are failures due to div nodes floating above it
thing else given the previous discussion. I should be able to
>> generate a build for the user and ask him to test in his real environment.
>> As for the other concern, I'll evaluate options and let you know.
>
> Thanks for the update, Martin.
> I'm ok with pu
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After
On Mon, 9 May 2022 22:10:54 GMT, Christoph Langer wrote:
> After https://bugs.openjdk.java.net/browse/JDK-8251329, javac throws errors
> when the classpath
> contains jar files with . or .. in its name. The error message, however, does
> not help to find
> the culprit. This could be improved.
extended exponent value set in Pentium 80 bits floating
point values. It impacts the behavior of arithmetic operations + - * /,
but my (maybe wrong) understanding is that it does not impact which
processor instruction is used for implementing Math.sin, cos, etc.
Martin
systematic use of StrictMath in all
JUnit test code ensure that the difference in behavior is not in the
test code, so we can focus our debugging effort on the main code.
Martin
On Sat, 7 May 2022 11:29:32 GMT, Doug Lea wrote:
>> Changes ForkJoinPool.close spec and code to trap close as a no-op if called
>> on common pool
>
> Doug Lea has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Accommodate restrictive Secu
On Sat, 7 May 2022 11:29:32 GMT, Doug Lea wrote:
>> Changes ForkJoinPool.close spec and code to trap close as a no-op if called
>> on common pool
>
> Doug Lea has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Accommodate restrictive Secu
On Sat, 7 May 2022 11:29:32 GMT, Doug Lea wrote:
>> Changes ForkJoinPool.close spec and code to trap close as a no-op if called
>> on common pool
>
> Doug Lea has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Accommodate restrictive Secu
On Fri, 6 May 2022 21:28:45 GMT, Martin Buchholz wrote:
>> Tests in this file are not being executed. I think you need:
>>
>> --- a/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java
>> +++ b/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java
>>
On Fri, 6 May 2022 20:25:10 GMT, Martin Buchholz wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix doc types
>
> test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496:
>
On Fri, 6 May 2022 21:27:53 GMT, Martin Buchholz wrote:
>> test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496:
>>
>>> 494:
>>> 495: /**
>>> 496: * Implictly closing a new pool using try-with-resources
>>> terminates it
&
On Fri, 6 May 2022 15:05:57 GMT, Doug Lea wrote:
> Changes ForkJoinPool.close spec and code to trap close as a no-op if called
> on common pool
test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496:
> 494:
> 495: /**
> 496: * Implictly closing a new pool using try-with-r
On Wed, 4 May 2022 12:04:47 GMT, Matthias Baesken wrote:
> A couple a tests like java/lang/ProcessBuilder/Basic.java#id0.Basic_id0 and
> jdk/jshell/ExternalEditorTest.java.ExternalEditorTest try to start small
> shell scripts without #! at the first line of the script. This fails with
> error=
On Wed, 4 May 2022 12:04:47 GMT, Matthias Baesken wrote:
> A couple a tests like java/lang/ProcessBuilder/Basic.java#id0.Basic_id0 and
> jdk/jshell/ExternalEditorTest.java.ExternalEditorTest try to start small
> shell scripts without #! at the first line of the script. This fails with
> error=
On Wed, 4 May 2022 11:37:09 GMT, Matthias Baesken wrote:
> There is one TestLibrary.bomb call in
> sun/rmi/runtime/Log/checkLogging/CheckLogging.java that is not passing the
> exception to bomb, that should be improved.
Marked as reviewed by mdoerr (Reviewer).
-
PR: https://git.o
On Mon, 2 May 2022 13:33:33 GMT, Doug Lea wrote:
>> This is the jsr166 refresh for jdk19. See
>> https://bugs.openjdk.java.net/browse/JDK-8285450 and
>> https://bugs.openjdk.java.net/browse/JDK-8277090
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since t
.
Regards,
Martin
hen testing with a few
sample values in base 10 (like 10% of 10%), while in reality rounding
errors continue to exist in the general case.
Martin
On Fri, 11 Feb 2022 12:11:54 GMT, Claes Redestad wrote:
>> I'm requesting comments and, hopefully, some help with this patch to replace
>> `StringCoding.hasNegatives` with `countPositives`. The new method does a
>> very similar pass, but alters the intrinsic to return the number of leading
>>
On Wed, 26 Jan 2022 12:51:31 GMT, Claes Redestad wrote:
> I'm requesting comments and, hopefully, some help with this patch to replace
> `StringCoding.hasNegatives` with `countPositives`. The new method does a very
> similar pass, but alters the intrinsic to return the number of leading bytes
On Wed, 9 Feb 2022 19:12:34 GMT, Daniel Fuchs wrote:
> The concerns are two folds:
>
> * without a regression test, you have to trust that the source changes
> actually work, and there's typically no verification possible
> * without a regression test, the next refactoring change in this area t
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After
On Wed, 9 Feb 2022 11:10:14 GMT, Michael Osipov wrote:
>>> @martinuy, I am the reporter of JDK-8160768. Regarding this PR, isn't
>>> everything protocol related a fail-fast issue? E.g., if the socket is up
>>> and running, but the LDAP message is rejected can we assume that all
>>> subsequent
On Tue, 8 Feb 2022 13:41:28 GMT, Martin Balao wrote:
>>> @martinuy This pull request has been inactive for more than 4 weeks and
>>> will be automatically closed if another 4 weeks passes without any
>>> activity. To avoid this, simply add a new comment to the pull
On Thu, 16 Dec 2021 01:23:11 GMT, Martin Balao wrote:
>> Hi @AlekseiEfimov
>>
>> Can you please review the CSR [1]?
>>
>> Thanks,
>> Martin.-
>>
>> --
>> [1] - https://bugs.openjdk.java.net/browse/JDK-8276959
>
>> @martinuy Thi
On Wed, 17 Nov 2021 20:04:50 GMT, Martin Balao wrote:
>> Hi Martin,
>>
>> The change looks reasonable to me.
>> I would suggest having a CSR logged for this change due to the following
>> [behavioral
>> incompatibility](https://wiki.openjdk.java.ne
/ldap.
>>
>> --
>> [1] - https://hg.openjdk.java.net/jdk/jdk/rev/a609d549992a#l2.137
>
> Hi Martin,
>
> The change looks reasonable to me.
> I would suggest having a CSR logged for this change due to the following
> [behavioral
> incompatibility](https://wi
On Wed, 27 Oct 2021 20:16:54 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Wed, 27 Oct 2021 20:16:54 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Sat, 13 Nov 2021 23:16:22 GMT, Sergey Bylokhov wrote:
> The ZipOutputStream class may create bogus zip data which cannot be opened by
> the ZipFile. The root cause is how the comment field is stored by the
> ZipOutputStream. According to the zip specification, the comment field should
> not
On Wed, 27 Oct 2021 20:16:54 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After
/ldap.
>>
>> --
>> [1] - https://hg.openjdk.java.net/jdk/jdk/rev/a609d549992a#l2.137
>
> Hi Martin,
>
> The change looks reasonable to me.
> I would suggest having a CSR logged for this change due to the following
> [behavioral
> incompatibility](https://wi
On Tue, 2 Nov 2021 19:14:23 GMT, Pavel Rappo wrote:
>> Pragmatically, fix the script to ignore those keywords on comment lines.
>> Learn Perl, its just a regular expression pattern match and replace
>> expression.
>>
>> All of the changes have to be manually reviewed by the author and then th
ava.net/pipermail/core-libs-dev/2021-November/082987.html
> (or https://github.com/openjdk/jdk/pull/6191#pullrequestreview-79465)
> [^2]:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035217.html
Marked as reviewed by martin (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6213
I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to the
state previous to JDK-8160768, where an authentication failure stops from
trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
have 2 possible loops to stop: the one that iterates over differ
275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE
> update javadoc of 'newCapacity' method to refer
> ArraysSupport.SOFT_MAX_ARRAY_LENGTH instead
We generally avoid in javadoc.
Especially in private javadoc.
I would write this more simply/readably as
* {@code SOFT_MAX_ARRAY_LENGTH >> coder}
age
Reviewed-by: psandoz, martin, bchristi, rriggs, smarks
If that is fixed (perhaps in a different commit), then this commit is good.
History has shown that capacity growth code is highly errorprone, so it's worth
writing whitebox tests, as I did in e.g.
./java/util/concurrent/Concurren
On Tue, 5 Oct 2021 17:51:31 GMT, Сергей Цыпанов
wrote:
>> Originally was proposed by Zheka Kozlov here:
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-December/057192.html
>>
>> Just a tiny optimization: we can use for-i loop instead of
>> `Iterable.forEach()` which is relying o
2.476 ns/op
>> NCopiesBenchmarks.forEach:·gc.alloc.rate 100 avgt 500.001 ±
>> 0.001 MB/sec
>> NCopiesBenchmarks.forEach:·gc.alloc.rate.norm 100 avgt 500.001 ±
>> 0.001B/op
>> NCopiesBenchmarks.forEach:·gc.count 100 avgt 50 ≈ 0
>>counts
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8274715: Properly format NCopiesBenchmarks.java
Looks good!
-
Marked as reviewed by martin (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2524
avgt 50 ≈ 0
>>counts
>
> Сергей Цыпанов has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains four commits:
>
> - Merge branch 'master' into ncopies
> - 8274715: Add NCopiesBenchmarks.java
> - 8274715: Revert some irrelevant changes
> - 8274715: Implement forEach in Collections.CopiesList
Thanks - TIL about Blackhole::consume .
All Java source files should end with exactly one newline. Configure your
editor to make it so.
-
Changes requested by martin (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2524
st/jdk/java/util/Collection/IteratorMicroBenchmark.java
That was written pre-JMH.
I see a JMH benchmark was written, but it is not part of the commit.
There are a number of unrelated changes in this commit that look like they were
suggested by a lint-like tool. Such changes are good, but th
ing:
>> - new regression test
>> - tiers 1-3
>>
>> Thanks,
>> David
>
> David Holmes has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated TCK test component from @martin
Marked as reviewed by marti
Hi Brian,
thanks a lot!
It may be difficult to reproduce. Maybe a slow file system helps (like NFS).
Just let us know if you have questions.
Best regards,
Martin
Von: Brian Stafford
Datum: Dienstag, 15. Juni 2021 um 01:20
An: [email protected] ,
[email protected]
OVERLAPPED structures.
I was hoping that JDK-8184157<https://bugs.openjdk.java.net/browse/JDK-8184157>
would fix it, but it doesn’t. Maybe it is incomplete?
Did anybody else notice such crashes?
Any idea?
Best regards,
Martin
On Wed, 17 Feb 2021 16:38:03 GMT, Сергей Цыпанов
wrote:
>> Non-static classes hold a link to their parent classes, which in many cases
>> can be avoided.
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8261880: Remove s
On Wed, 3 Feb 2021 21:55:54 GMT, Martin Buchholz wrote:
> 8260664: Phaser.arrive() memory consistency effects
This pull request has now been integrated.
Changeset: eb4a8af5
Author: Martin Buchholz
URL: https://git.openjdk.java.net/jdk/commit/eb4a8af5
Stats: 6 lines in 1 f
On Sat, 20 Feb 2021 14:17:16 GMT, Doug Lea wrote:
> This addresses interactions between parallelism-0 and new shutdown support in
> https://bugs.openjdk.java.net/browse/JDK-8259800
Marked as reviewed by martin (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2661
On Fri, 19 Feb 2021 10:35:21 GMT, Christoph Langer wrote:
> The fix for JDK-8261753 introduced a ',' after the copyright years which is
> not the expected format for SAP copyrights.
Seems like this is the only place where we have the wrong comma. Looks good and
trivial. Thanks for fixing!
---
On Tue, 5 Jan 2021 03:15:56 GMT, Martin Buchholz wrote:
> 8259074: regex benchmarks and tests
This pull request has now been integrated.
Changeset: 351d7888
Author: Martin Buchholz
URL: https://git.openjdk.java.net/jdk/commit/351d7888
Stats: 483 lines in 5 files changed: 473
On Tue, 2 Feb 2021 13:10:29 GMT, Claes Redestad wrote:
>> Martin Buchholz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix imports
>
> Marked as reviewed by redestad (Reviewer).
@cl4es Your comment se
On Wed, 3 Feb 2021 21:55:54 GMT, Martin Buchholz wrote:
> 8260664: Phaser.arrive() memory consistency effects
@DougLea
-
PR: https://git.openjdk.java.net/jdk/pull/2388
8260664: Phaser.arrive() memory consistency effects
-
Commit messages:
- JDK-8260664
Changes: https://git.openjdk.java.net/jdk/pull/2388/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2388&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8260664
Stats: 6 li
> 8259074: regex benchmarks and tests
Martin Buchholz has updated the pull request incrementally with one additional
commit since the last revision:
fix imports
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1940/files
- new: https://git.openjdk.java.net/jdk/p
On Tue, 2 Feb 2021 01:40:09 GMT, Martin Buchholz wrote:
>> @cl4es I agree pruning is a good idea. I settled on 3 data points with 16x
>> separations as good enough to clearly show the difference between O(1) O(N)
>> O(N^2) and O(2^N) (although O(2^N) would "run fore
> 8259074: regex benchmarks and tests
Martin Buchholz has updated the pull request incrementally with one additional
commit since the last revision:
add annotations for sensible defaults
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1940/files
- new: ht
On Mon, 1 Feb 2021 20:52:12 GMT, Martin Buchholz wrote:
>> The assertion discussion aside, the micros look fine to me.
>>
>> With an eye towards reducing total run time I'd ask you to consider if all
>> parameter combinations are useful or if we can get the same
On Mon, 1 Feb 2021 00:23:56 GMT, Martin Buchholz wrote:
>> test/micro/org/openjdk/bench/java/util/regex/Trim.java line 119:
>>
>>> 117: assert ! lookBehind_find();
>>> 118: assert ! find_loop_two_matchers();
>>> 119: assert ! find
> 8259074: regex benchmarks and tests
Martin Buchholz has updated the pull request incrementally with two additional
commits since the last revision:
- refactor correctness checking as suggested by @shipilev
- prune @Param values as suggested by Claes
-
Changes:
- all: ht
On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote:
>> @amalloy - you are invited to comment on regex content
>> @cl4es @shipilev - you are invited to point out my jmh bad practices
>
> The assertion discussion aside, the micros look fine to me.
>
> With an eye towards reducing total run tim
On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote:
>> @amalloy - you are invited to comment on regex content
>> @cl4es @shipilev - you are invited to point out my jmh bad practices
>
> The assertion discussion aside, the micros look fine to me.
>
> With an eye towards reducing total run tim
On Sun, 31 Jan 2021 08:18:28 GMT, Aleksey Shipilev wrote:
>> Martin Buchholz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address comments from @amalloy; introduce technically correct use of
>> "
> 8259074: regex benchmarks and tests
Martin Buchholz has updated the pull request incrementally with one additional
commit since the last revision:
address comments from @amalloy; introduce technically correct use of "numeral"
-
Changes:
- all: https://git.ope
On Tue, 5 Jan 2021 03:15:56 GMT, Martin Buchholz wrote:
> 8259074: regex benchmarks and tests
@amalloy - you are invited to comment on regex content
@cl4es @shipilev - you are invited to point out my jmh bad practices
-
PR: https://git.openjdk.java.net/jdk/pull/1940
8259074: regex benchmarks and tests
-
Commit messages:
- more benchmarks
- JDK-8259074
Changes: https://git.openjdk.java.net/jdk/pull/1940/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1940&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8259074
Stats: 4
On Tue, 26 Jan 2021 21:23:25 GMT, Martin Buchholz wrote:
> 8260461: Modernize jsr166 tck tests
This pull request has now been integrated.
Changeset: 81e9e6a7
Author: Martin Buchholz
URL: https://git.openjdk.java.net/jdk/commit/81e9e6a7
Stats: 7616 lines in 71 files changed:
On Wed, 27 Jan 2021 00:44:51 GMT, Doug Lea wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
&
> 8260461: Modernize jsr166 tck tests
Martin Buchholz has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commit
since the l
> 8260461: Modernize jsr166 tck tests
Martin Buchholz has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains one commit:
JDK-8260461
-
Changes: https://git.openjdk.java.net/jdk/pull/2245/files
Webrev: ht
8260461: Modernize jsr166 tck tests
-
Commit messages:
- JDK-8260461
Changes: https://git.openjdk.java.net/jdk/pull/2245/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2245&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8260461
Stats: 7535 lines in 70 fil
Hi Götz,
thanks for the review!
Best regards,
Martin
From: Lindenmaier, Goetz
Sent: Montag, 25. Januar 2021 10:49
To: Doerr, Martin ; core-libs-dev
; [email protected]
Cc: Langer, Christoph
Subject: RE: [11u] RFR: 7146776: deadlock between
URLStreamHandler.getHostAddress and
On Sun, 24 Jan 2021 20:14:04 GMT, Martin Buchholz wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typo, clarify asserts disabled, test prefGrowth==0
>
> Marked as reviewed by ma
ous call sites around the JDK to
>> use this method.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix typo, clarify asserts disabled, test prefGrowth==0
Marked as reviewed by martin (Reviewer).
test/
On Fri, 4 Dec 2020 17:31:20 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 654:
>>
>>> 652: return SOFT_MAX_ARRAY_LENGTH;
>>> 653: } else {
>>> 654: return minLength;
>>
>> Isn't this last `else if... then.. else
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Wed, 9 Dec 2020 00:32:37 GMT, Paul Sandoz wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typo, clarify asserts disabled, test prefGrowth==0
>
> src/java.base/share/classes/jdk/internal/util/ArraysSupport.ja
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Fri, 22 Jan 2021 22:56:08 GMT, Jiangli Zhou wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> Marke
My github comment was mangled forwarding to core-libs. I suspect the skara
bidirectional mailing list forwarding bot discards lines with leading "/"
.
Instead the bot should pass on unrecognized github comment commands
unmodified.
On Fri, Jan 22, 2021 at 12:12 PM Martin Buchholz
wr
On Fri, 22 Jan 2021 19:46:13 GMT, Jiangli Zhou wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> src/java.
On Sun, 17 Jan 2021 18:39:55 GMT, Martin Buchholz wrote:
> 8259796: timed CompletableFuture.get may swallow InterruptedException
This pull request has now been integrated.
Changeset: f7b96d34
Author: Martin Buchholz
URL: https://git.openjdk.java.net/jdk16/commit/f7b96d34
St
host.isEmpty() from
URLStreamHandler.java.
Bug:
https://bugs.openjdk.java.net/browse/JDK-7146776
Original change:
https://git.openjdk.java.net/jdk/commit/db9c114d
11u backport:
http://cr.openjdk.java.net/~mdoerr/7146776_windows_deadlock_11u/webrev.00/
Please review.
Best regards,
Martin
> 8259796: timed CompletableFuture.get may swallow InterruptedException
Martin Buchholz has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains one commit:
JDK-8259796
-
Changes: https://git.openjdk.java.net/jdk16/pull/
On Sun, 17 Jan 2021 18:52:04 GMT, Doug Lea wrote:
>> Martin Buchholz has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> JDK-8259796
>
> Marked as reviewed by dl (Reviewer).
we addi
> 8252412: [macos11] system dynamic libraries removed from filesystem
Martin Buchholz has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains
8252412: [macos11] File-based loading of dynamic libraries deprecated
-
Commit messages:
- JDK-8252412: [macos11] File-based loading of dynamic libraries deprecated
Changes: https://git.openjdk.java.net/jdk/pull/2119/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2119&
8259796: timed CompletableFuture.get may swallow InterruptedException
-
Commit messages:
- JDK-8259796
Changes: https://git.openjdk.java.net/jdk16/pull/126/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=126&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8
On Thu, 14 Jan 2021 13:59:50 GMT, Kezhu Wang
wrote:
>> 8254350: CompletableFuture.get may swallow InterruptedException
>
> @Martin-Buchholz @DougLea @AlanBateman Sorry for rough in. After change
> `future.get()` to `future.get(1, TimeUnit.DAYS)`,
> `SwallowedInterrupte
On Wed, 6 Jan 2021 15:33:59 GMT, Martin Balao wrote:
> As described in JDK-8259319 [1], this fix proposal is to set proper access
> permissions so the SunPKCS11 provider can create instances of SunJCE classes
> when a Security Manager is installed and the fallback scheme is used
On Sun, 10 Jan 2021 20:13:07 GMT, Martin Buchholz wrote:
> 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in
> #execute
This pull request has now been integrated.
Changeset: 9154f643
Author:Martin Buchholz
URL: https://git.openjdk.java.net/jdk/commit/91
8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute
-
Commit messages:
- JDK-8254973
Changes: https://git.openjdk.java.net/jdk/pull/2018/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2018&range=00
Issue: https://bugs.openjdk.java.net/brow
On Sat, 9 Jan 2021 23:44:13 GMT, Martin Buchholz wrote:
> JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue
This pull request has now been integrated.
Changeset: e7c17408
Author: Martin Buchholz
URL: https://git.openjdk.java.net/jdk/commit/e7c17408
Stats: 30 lines
On Sun, 10 Jan 2021 12:01:44 GMT, Doug Lea wrote:
>> 8259518: Fixes for rare test failures due to 8246585: ForkJoin updates
>
> Marked as reviewed by dl (Reviewer).
The code is good, but this is actually a fix for
JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue
I will fiddle with
On Sat, 9 Jan 2021 23:41:24 GMT, Martin Buchholz wrote:
> 8258217: PriorityBlockingQueue constructor spec and behavior mismatch
This pull request has now been integrated.
Changeset: 11d5b047
Author: Martin Buchholz
URL: https://git.openjdk.java.net/jdk/commit/11d5b047
Stats:
8259518: Fixes for rare test failures due to 8246585: ForkJoin updates
-
Commit messages:
- JDK-8259518
Changes: https://git.openjdk.java.net/jdk/pull/2015/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2015&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-82
8258217: PriorityBlockingQueue constructor spec and behavior mismatch
-
Commit messages:
- JDK-8258217
Changes: https://git.openjdk.java.net/jdk/pull/2014/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2014&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-825
1 - 100 of 2351 matches
Mail list logo
