Re: RRF(XS)(10): 8176797: [TESTBUG] tools/launcher/Settings.java -Xss size is too small

2017-03-16 Thread Stanislav Smirnov
s", "-jar", testJar.getAbsolutePath()); Best regards, Stanislav Smirnov > On 16 Mar 2017, at 07:59, Chris Plummer wrote: > > Hello, > > Please review the following: > > https://bugs.openjdk.java.net/browse/JDK-8176797 > http://cr.openjdk.java.n

Re: RFR 8171441: tools/launcher/VersionCheck.java doesn't report names of tools which failed checks

2016-12-26 Thread Stanislav Smirnov
Hi, thanks, looks good Best regards, Stanislav Smirnov > On 23 Dec 2016, at 19:13, Dmitry Fazunenenko > wrote: > > Hi, > > new version: http://cr.openjdk.java.net/~dfazunen/8171441/webrev.02/ > <http://cr.openjdk.java.net/~dfazunen/8171441/webrev.02/> >

Re: RFR 8171441: tools/launcher/VersionCheck.java doesn't report names of tools which failed checks

2016-12-23 Thread Stanislav Smirnov
*/ 157 static String testToolVersion() { It confuses me, can you please rephrase it? Best regards, Stanislav Smirnov > On 23 Dec 2016, at 11:55, Dmitry Fazunenko > wrote: > > Hi Stanislav, > > Thanks for looking. > Updated webrev: > http://cr.openjdk.java.net/~df

Re: RFR 8171441: tools/launcher/VersionCheck.java doesn't report names of tools which failed checks

2016-12-22 Thread Stanislav Smirnov
(x.trim()); } tr.testOutput.stream.map(String::trim).forEach(aList:add) Best regards, Stanislav Smirnov > On 21 Dec 2016, at 17:16, Dmitry Fazunenenko > wrote: > > Hello, > > I'm looking for reviews of a relatively simple test change: >http://cr.

Re: RFR: 8163984: Fix license and copyright headers in jdk9 under test/lib

2016-10-18 Thread Stanislav Smirnov
David, thank you Best regards, Stanislav Smirnov > On 19 Oct 2016, at 04:27, David Holmes wrote: > > Hi Stanislav, > > On 19/10/2016 1:06 AM, Stanislav Smirnov wrote: >> Hi, >> >> I'm still looking for volunteers to review > > This is trivial

Re: RFR: 8163984: Fix license and copyright headers in jdk9 under test/lib

2016-10-18 Thread Stanislav Smirnov
Hi, I'm still looking for volunteers to review Best regards, Stanislav Smirnov > On 05 Oct 2016, at 19:44, Stanislav Smirnov > wrote: > > Hi, > > Please review this fix for JDK-8163984 > <https://bugs.openjdk.java.net/browse/JDK-8163984>. > This on

Re: RFR: 8163984: Fix license and copyright headers in jdk9 under test/lib

2016-10-06 Thread Stanislav Smirnov
adding core-libs-dev mailing list, since my change affect some files for testing APIs in java.util.function Best regards, Stanislav Smirnov > On 05 Oct 2016, at 19:44, Stanislav Smirnov > wrote: > > Hi, > > Please review this fix for JDK-8163984 > <https://bugs.ope