Re: [11] RFR: 8206445: JImageListTest.java failed in Windows

: alan.bate...@oracle.com To: srinivas.d...@oracle.com, core-libs-dev@openjdk.java.net Sent: Monday, 9 July, 2018 4:23:48 PM GMT +05:30 Chennai, Kolkata, Mumbai, New Delhi Subject: Re: [11] RFR: 8206445: JImageListTest.java failed in Windows On 09/07/2018 11:38, Srinivas Dama wrote: > Hi, > &g

[11] RFR: 8206445: JImageListTest.java failed in Windows

Hi, Please review webrev: http://cr.openjdk.java.net/~sdama/8206445/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8206445 Regards, Srinivas

Re: [11] RFR: 8198405: JImageExtractTest.java & JImageListTest.java failed in Windows.

ied. See link in bug report. David On 6/07/2018 3:44 AM, Jim Laskey wrote: > +1 > >> On Jul 5, 2018, at 2:42 PM, Srinivas Dama wrote: >> >> Hi, >> >> Please review >> Webrev: http://cr.openjdk.java.net/~sdama/8198405/webrev.00/ >> Bug: https

[11] RFR: 8198405: JImageExtractTest.java & JImageListTest.java failed in Windows.

Hi, Please review Webrev: http://cr.openjdk.java.net/~sdama/8198405/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8198405 Regards, Srinivas

[11]RFR: 8198819: tools/jimage/JImageExtractTest.java, fails intermittently at testExtract (macos)

Hi, Please review webrev: http://cr.openjdk.java.net/~sdama/8198819/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8198819 Modified test to work only on modules extracted using jimage instead of considering already existing files in current directory and treating them as bad Modules

Re: RFR: 8196988 (Resolve disabled warnings for libjimage)

ct: Re: RFR: 8196988 (Resolve disabled warnings for libjimage) Looks ok. Including Jim in case he is not listening in… I am guessing the comment selectively disables the warning in this code (rather than using a diagnostic pragma). Thanks, Paul. > On Jun 7, 2018, at 11:17 PM, Srinivas Da

Re: RFR: 8204967: Resolve disabled warnings for libunpack

@openjdk.java.net Sent: Thursday, 14 June, 2018 3:23:23 PM GMT +05:30 Chennai, Kolkata, Mumbai, New Delhi Subject: Re: RFR: 8204967: Resolve disabled warnings for libunpack On 2018-06-13 18:57, Srinivas Dama wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8204967/webrev.00/ &g

RFR: 8204967: Resolve disabled warnings for libunpack

Hi, Please review http://cr.openjdk.java.net/~sdama/8204967/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8204967 Regards, Srinivas

RFR: 8204861 : fix for 8196993 has broken the build on linux

Hi, My earlier fix for https://bugs.openjdk.java.net/browse/JDK-8196993 has broken the build on linux. So I am reverting my fix for now. Bug : https://bugs.openjdk.java.net/browse/JDK-8204861 webrev: http://cr.openjdk.java.net/~sdama/8204861/webrev.00/ Regards, Srinivas

RE: RFR: 8196988 (Resolve disabled warnings for libjimage)

Gentle reminder. May I have review for the below changeset. Regards, Srinivas -Original Message- From: Srinivas Dama Sent: Friday, June 08, 2018 11:47 AM To: core-libs-dev@openjdk.java.net Subject: Re: RFR: 8196988 (Resolve disabled warnings for libjimage) Hi, Please review http

RE: RFR: 8196993: Resolve disabled warnings for libunpack

Gentle reminder . May I have review for the below changeset. Regards, Srinivas -Original Message- From: Srinivas Dama Sent: Friday, June 08, 2018 6:33 PM To: Core-Libs-Dev Subject: RFR: 8196993: Resolve disabled warnings for libunpack Hi, Please review http://cr.openjdk.java.net

RFR: 8196993: Resolve disabled warnings for libunpack

Hi, Please review http://cr.openjdk.java.net/~sdama/8196993/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8196993 Regards, Srinivas

Re: RFR: 8196988 (Resolve disabled warnings for libjimage)

Hi, Please review http://cr.openjdk.java.net/~sdama/8196988/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8196988 Note: Modified earlier fix to handle warning messages specific to libjimage only. Regards, Srinivas - Original Message - From: srinivas.d...@oracle.com To: core

Re: RFR: 8196990 :Resolve disabled warnings for libjli

at 11:01 AM, Srinivas Dama wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8196990/webrev.00/ > for https://bugs.openjdk.java.net/browse/JDK-8196990 > > Regards, > Srinivas

RFR: 8196990 :Resolve disabled warnings for libjli

Hi, Please review http://cr.openjdk.java.net/~sdama/8196990/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8196990 Regards, Srinivas

RFR: 8196988 (Resolve disabled warnings for implicit-fallthrough gcc option)

Hi, Please review http://cr.openjdk.java.net/~sdama/8196988/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8196988 Note: gcc 7.3 compiler emits warnings for implicit fall-through switch cases,but these warnings are disabled earlier.I have enabled these warnings and fixed in sources. R

RFR: 8196959: NullPointerException in discovery003.java

Hi, Please review http://cr.openjdk.java.net/~sdama/8196959/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8196959 This is small modification of fix for https://bugs.openjdk.java.net/browse/JDK-8011697. Fix is to handle the corner case where the engineName is null. Regards, Srinivas

RE: RFR: 8011697(ScriptEngine "js" randomly means either "rhino" or "nashorn", but should instead select one)

Subject: Re: RFR: 8011697(ScriptEngine "js" randomly means either "rhino" or "nashorn", but should instead select one) +1 (with the copyright header change suggested by Alan) -Sundar On 30/01/18, 8:28 PM, Alan Bateman wrote: > On 30/01/2018 09:17, Srinivas Dama

RE: RFR: 8011697(ScriptEngine "js" randomly means either "rhino" or "nashorn", but should instead select one)

Hi, Please review the revised webrev at http://cr.openjdk.java.net/~sdama/8011697/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8011697 Regards, Srinivas -Original Message- From: Alan Bateman Sent: Monday, December 11, 2017 10:05 PM To: Srinivas Dama ; core-libs-dev

RFR: 8011697(ScriptEngine "js" randomly means either "rhino" or "nashorn", but should instead select one)

Hi, Please review http://cr.openjdk.java.net/~sdama/8011697/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8011697 Fix is to make sure ScriptEngineManager always returns a particular engine on all platforms consistently. Regards, Srinivas

RFR:8055033: Shell tests for jrunscript don't pass through VM options

Hi, Please review http://cr.openjdk.java.net/~sdama/8055033/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8055033 When launching java and javac from shell script, ${TESTVMOPTS}, ${TESTJAVAOPTS} and ${TESTTOOLVMOPTS}, ${TESTJAVACOPTS} should be passed in respectively since jtreg sets

RFR:8163793: jlink has typo in copy-files plugin help text example

Hi, This patch fixes very small typo error. Please review http://cr.openjdk.java.net/~sdama/8163793/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8163793 Regards, Srinivas