On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
Overall, looks good other than the various minor issues called out.
I wonder if the tests would have turned out to be a good bit simpler if we
simply checked diagnostics against a golden file and skipped the
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 1326:
> 1324: private void warnOnExplicitStrictfp(DiagnosticPosition pos, JCTree
> tree) {
> 1325: DiagnosticPosition prevL
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 228:
> 226: SEALED_CLASSES(JDK17, Fragments.FeatureSealedClasses,
> DiagKind.PLURAL),
> 227: // todo: will need to sup
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
line 1769:
> 1767: compiler.warn.strictfp=\
> 1768: as of release 17, all floating-point expressions are evaluated
> stri
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line
1704:
> 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source))
> 1703: result = result & ~STRICTFP;
> 1
> Hi Srikanth,
>
> I would mention that Object is not annotated in the following statements:
> - AnnotatedWildcardType.getAnnotatedUpperBounds(): "Note that if no
> upper bound is explicitly declared, the upper bound is Object."
> - AnnotatedTypeVariable.getAnnotat
backport from a process p.o.v as
this calls for
a specification change.
Thanks!
Srikanth.
://bugs.openjdk.java.net/browse/JDK-8076039
Webrev: http://cr.openjdk.java.net/~sadayapalam/8076039/webrev/
Thanks!
Srikanth
where
such refactorings are possible.
We appreciate your testing and any feedback and defect reports.
Thanks!
Srikanth
