Re: RFR: 8287496: Alternative virtual thread implementation that maps to OS thread [v2]

2022-05-31 Thread Robbin Ehn
On Tue, 31 May 2022 15:39:39 GMT, Alan Bateman wrote: >> This patch adds an alternative virtual thread implementation where each >> virtual thread is backed by an OS thread. It doesn't scale but it can be >> used by ports that don't have continuations support in the VM. Aside from >> scalabili

Re: RFR: 8286825: Linker naming cleanup [v2]

2022-05-22 Thread Robbin Ehn
On Fri, 20 May 2022 10:57:44 GMT, Jorn Vernee wrote: >> This patch is a batch naming cleanup for the foreign linker implementation. >> >> The naming changes are as follows: >> >> - ProgrammableInvoker -> DowncallLinker >> - ProgrammableUpcallHandler -> UpcallLinker >> - 'native invoker' -

Re: RFR: 8283689: Update the foreign linker VM implementation [v22]

2022-05-17 Thread Robbin Ehn
On Tue, 17 May 2022 10:38:39 GMT, Jorn Vernee wrote: >> Hi, >> >> This PR updates the VM implementation of the foreign linker, by bringing >> over commits from the panama-foreign repo. >> >> This is split off from the main JEP integration for 19, since we have >> limited resources to handle t

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v7]

2022-04-27 Thread Robbin Ehn
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR(S): 8222518: Remove unnecessary caching of Parker object in java.lang.Thread

2019-04-26 Thread Robbin Ehn
I'll file a RFE for that. Great, thanks! /Robbin Thanks, David Thanks, Robbin On 4/24/19 9:12 AM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8222518 webrev: http://cr.openjdk.java.net/~dholmes/8222518/webrev/ The original implementation of Unsafe.unpark simply e

Re: RFR(S): 8222518: Remove unnecessary caching of Parker object in java.lang.Thread

2019-04-25 Thread Robbin Ehn
Hi David, Looks good. Just a question: It seems like we could just hold the ThreadsList over p->unpark() and not rely on TSM ? Not sure in how many places we do rely on it, but it would be nice to remove TSM for parkers. The exiting thread would set parker to NULL before removing itself from t

Re: Ping!! Re: RFR: 8203357 Container Metrics

2018-06-11 Thread Robbin Ehn
Hi Bob, On 06/07/2018 07:43 PM, Bob Vandette wrote: Can I get one more reviewer for this RFE so I can integrate it? http://cr.openjdk.java.net/~bobv/8203357/webrev.01 Seems okay. Metrics.java "Returns the length of the operating system time slice" Note that is is only true if you are using