Withdrawn: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput

2021-06-16 Thread Richard Fussenegger
On Thu, 26 Nov 2020 18:24:22 GMT, Richard Fussenegger wrote: > Made byte constructor public and changed the length assertion to an > `IllegalArgumentException`, added a `getBytes` method that allows users to > retrieve the raw bytes of the UUID, and created a new private constructo

Withdrawn: 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant

2021-06-16 Thread Richard Fussenegger
On Thu, 26 Nov 2020 18:51:10 GMT, Richard Fussenegger wrote: > 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/1467

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput [v3]

2021-05-19 Thread Richard Fussenegger
On Sat, 28 Nov 2020 10:12:10 GMT, Richard Fussenegger wrote: >> Made byte constructor public and changed the length assertion to an >> `IllegalArgumentException`, added a `getBytes` method that allows users to >> retrieve the raw bytes of the UUID, and created a new p

Re: RFR: 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant

2021-05-19 Thread Richard Fussenegger
On Thu, 26 Nov 2020 18:51:10 GMT, Richard Fussenegger wrote: > 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant @bridgekeeper I guess it will stay open for a little longer. 😜 - PR: https://git.openjdk.java.net/jdk/pull/1467

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput [v3]

2021-04-21 Thread Richard Fussenegger
On Sat, 28 Nov 2020 10:12:10 GMT, Richard Fussenegger wrote: >> Made byte constructor public and changed the length assertion to an >> `IllegalArgumentException`, added a `getBytes` method that allows users to >> retrieve the raw bytes of the UUID, and created a new p

Re: RFR: 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant

2021-04-21 Thread Richard Fussenegger
On Thu, 26 Nov 2020 18:51:10 GMT, Richard Fussenegger wrote: > 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant Active - PR: https://git.openjdk.java.net/jdk/pull/1467

Re: RFR: 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant

2021-02-12 Thread Richard Fussenegger
On Fri, 15 Jan 2021 07:14:49 GMT, Richard Fussenegger wrote: >> Often an enhancement is created when there's an idea of an improvement but >> no resources to do the research and develop a justification. That work has >> to be done when someone has time. Usually ideas

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput

2021-02-09 Thread Richard Fussenegger
On Tue, 12 Jan 2021 07:26:44 GMT, Richard Fussenegger wrote: >> Requested feedback on the API addition/modifications: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072530.html > > Active Active - PR: https://git.openjdk.java.net/jdk/pull/1465

Re: RFR: 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant

2021-01-14 Thread Richard Fussenegger
On Thu, 17 Dec 2020 22:16:12 GMT, Roger Riggs wrote: >> I cannot create CSRs, only members can. Deprecating and switching to another >> function results in much more work for users overall because it affects all >> those who use it correctly as well. In other words: 100% >> >> I'm in favor of

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput

2021-01-11 Thread Richard Fussenegger
On Mon, 14 Dec 2020 20:18:01 GMT, Roger Riggs wrote: >> Made byte constructor public and changed the length assertion to an >> `IllegalArgumentException`, added a `getBytes` method that allows users to >> retrieve the raw bytes of the UUID, and created a new private constructor >> with an opti

Re: RFR: 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant

2020-12-17 Thread Richard Fussenegger
On Thu, 17 Dec 2020 17:18:37 GMT, Lance Andersen wrote: >>> There is very little value in adding the exception doing so might prevent >>> existing applications from continuing to function. >> >> I disagree on the value and am with the author of the original issue. All >> these existing applica

Re: RFR: 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant

2020-12-16 Thread Richard Fussenegger
On Mon, 14 Dec 2020 19:36:45 GMT, Roger Riggs wrote: > There is very little value in adding the exception doing so might prevent > existing applications from continuing to function. I disagree on the value and am with the author of the original issue. All these existing applications are functi

Withdrawn: 8207329: Add NIL Constant to UUID

2020-12-01 Thread Richard Fussenegger
On Thu, 26 Nov 2020 15:54:46 GMT, Richard Fussenegger wrote: > Adds a constant for the special NIL UUID where all bits are zero to > `java.util.UUID`. The > [8207329](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8207329) > mentions the usage of it to avoid `null`, it for

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput [v2]

2020-11-28 Thread Richard Fussenegger
On Thu, 26 Nov 2020 19:08:54 GMT, Richard Fussenegger wrote: >> src/java.base/share/classes/java/util/UUID.java line 168: >> >>> 166: /** >>> 167: * Constructs a new {@code UUID} using the specified data. {@code >>> 168: * mostSigBits} is u

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput [v3]

2020-11-28 Thread Richard Fussenegger
directly write as well (e.g. `output.write(uuid.getBytes())` vs > `uuid.write(output)`). Hence, I consider this change to satisfy the feature > request. Richard Fussenegger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show

Integrated: 8170432: Class java.util.UUID & @Override

2020-11-27 Thread Richard Fussenegger
On Thu, 26 Nov 2020 17:01:59 GMT, Richard Fussenegger wrote: > Adds `@Override` annotation to all methods in `java.util.UUID` that implement > methods from the implemented interfaces. This pull request has now been integrated. Changeset: b4cba15a Author:Fleshgrinder Committer:

Re: RFR: 8207329: Add NIL Constant to UUID

2020-11-27 Thread Richard Fussenegger
On Fri, 27 Nov 2020 17:55:27 GMT, Roger Riggs wrote: >> Adds a constant for the special NIL UUID where all bits are zero to >> `java.util.UUID`. The >> [8207329](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8207329) >> mentions the usage of it to avoid `null`, it for sure is also very

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput [v2]

2020-11-26 Thread Richard Fussenegger
On Thu, 26 Nov 2020 18:53:06 GMT, Alan Bateman wrote: >> Richard Fussenegger has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > src

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput [v2]

2020-11-26 Thread Richard Fussenegger
directly write as well (e.g. `output.write(uuid.getBytes())` vs > `uuid.write(output)`). Hence, I consider this change to satisfy the feature > request. Richard Fussenegger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show

RFR: 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant

2020-11-26 Thread Richard Fussenegger
6594730: UUID.getVersion() is only meaningful for Leach-Salz variant - Commit messages: - 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant Changes: https://git.openjdk.java.net/jdk/pull/1467/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1467&range=

RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput

2020-11-26 Thread Richard Fussenegger
Made byte constructor public and changed the length assertion to an `IllegalArgumentException`, added a `getBytes` method that allows users to retrieve the raw bytes of the UUID, and created a new private constructor with an optimized construction for byte arrays that can set the version as desi

RFR: 8170432: Class java.util.UUID & @Override

2020-11-26 Thread Richard Fussenegger
Adds `@Override` annotation to all methods in `java.util.UUID` that implement methods from the implemented interfaces. - Commit messages: - 8170432: Class java.util.UUID & @Override Changes: https://git.openjdk.java.net/jdk/pull/1463/files Webrev: https://webrevs.openjdk.java.net/

RFR: 8207329: Add NIL Constant to UUID

2020-11-26 Thread Richard Fussenegger
Adds a constant for the special NIL UUID where all bits are zero to `java.util.UUID`. The [8207329](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8207329) mentions the usage of it to avoid `null`, it for sure is also very handy in testing where a UUID is required and we do not care about