Integrated: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms

2021-09-17 Thread Remilia Scarlet
On Wed, 15 Sep 2021 06:28:25 GMT, Remilia Scarlet wrote: > The test assumes that it always runs on 64-bit platform and > classes_nocoops.jsa is always created. > It's a test bug. The test should only expect classes_nocoops.jsa exists if > it's running on a supported 64-b

Re: RFR: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms [v5]

2021-09-16 Thread Remilia Scarlet
's unknown if it's 64-bit or not. > > This patch fix the test to check if classes_nocoops.jsa exists only on one of > the JDK supported platforms (x64 or aarch64) via the sun.arch.data.model > system property. > > Please review this change. Thanks! Remilia Scarlet

Re: RFR: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms [v4]

2021-09-16 Thread Remilia Scarlet
On Fri, 17 Sep 2021 01:52:30 GMT, Mandy Chung wrote: >> Remilia Scarlet has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request &

Re: RFR: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms [v4]

2021-09-16 Thread Remilia Scarlet
On Fri, 17 Sep 2021 01:47:05 GMT, Remilia Scarlet wrote: >> The test assumes that it always runs on 64-bit platform and >> classes_nocoops.jsa is always created. >> It's a test bug. The test should only expect classes_nocoops.jsa exists if >> it's runn

Re: RFR: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms [v4]

2021-09-16 Thread Remilia Scarlet
's unknown if it's 64-bit or not. > > This patch fix the test to check if classes_nocoops.jsa exists only on one of > the JDK supported platforms (x64 or aarch64) via the sun.arch.data.model > system property. > > Please review this change. Thanks! Remilia Scarlet

Re: RFR: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms [v3]

2021-09-15 Thread Remilia Scarlet
f("64") != -1); > } > > > Please review this change. Thanks! Remilia Scarlet has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull

Re: RFR: 8273774: jdk.tools.jlink.internal.Platform::is64Bit() should not hard code for x64 and AARCH64 [v2]

2021-09-15 Thread Remilia Scarlet
f("64") != -1); > } > > > Please review this change. Thanks! Remilia Scarlet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contai

RFR: 8273774: jdk.tools.jlink.internal.Platform::is64Bit() should not hard code for x64 and AARCH64

2021-09-15 Thread Remilia Scarlet
Currently, the Platform.is64Bit() hard coded for judging whether the target arch is 64-bit. The `classes_nocoops.jsa not found` issue can be found while testing CDSPluginTest.java on 64-bit platform, excluding x64 and AARCH64, like mips64. For solving this issue, we assume that the bits of targe