Re: Reviewer needed: (JDK7) fixed three typos in a class ScriptEngineManager

2012-02-28 Thread Pavel Tisnovsky
Alan Bateman wrote: > On 28/02/2012 13:36, Pavel Tisnovsky wrote: >> Hi, >> >> I'd like to fix three typos in ScriptEngineManager class's JavaDoc. >> This class contains method getEngineFactories() which returns >> list of factories, not an array o

Reviewer needed: (JDK7) fixed three typos in a class ScriptEngineManager

2012-02-28 Thread Pavel Tisnovsky
an anybody review this change please? PS: similar typos exist in OpenJDK6 too. Thank you in advance, Pavel Tisnovsky

Re: Reviewer needed - fix for regression test LastErrorString

2011-05-09 Thread Pavel Tisnovsky
Alan Bateman wrote: > Alan Bateman wrote: >> I also need to create a bug for this as I don't think we have one already > Here it is: > > 7042603: TEST_BUG: test/java/io/IOException/LastErrorString.java touches > system files Hi Alan, thank you for creating bug# for this issue. I changed this re

Re: Reviewer needed - fix for regression test LastErrorString

2011-05-06 Thread Pavel Tisnovsky
Alan Bateman wrote: > Pavel Tisnovsky wrote: >> : >>> I agree that this test should be fixed but I don't know about jdk7 as >>> it's being stabilized now and only critical changes are allowed. >>> >>> >> >> just to be sur

Re: Reviewer needed - fix for regression test LastErrorString

2011-05-06 Thread Pavel Tisnovsky
Alan Bateman wrote: > Pavel Tisnovsky wrote: >> Hi all, >> >> I'd like to push fix for regression test >> java/io/IOException/LastErrorString.java to OpenJDK7 and OpenJDK6. This >> fix ensures that no system-important files can be erased and/or >> rewri

Reviewer needed - fix for regression test LastErrorString

2011-05-05 Thread Pavel Tisnovsky
file attributes. Webrev is available at: http://cr.openjdk.java.net/~ptisnovs/jtreg-jdk-test-LastErrorString-fix/ Can anybody please review it? Thank you in advance, Pavel Tisnovsky

Re: Reviewer needed - more test cases added to regression java/lang/Double/ToString.java

2011-03-10 Thread Pavel Tisnovsky
Alan Bateman wrote: > Pavel Tisnovsky wrote: >> Hi, >> >> I'd like to change regression test java/lang/Double/ToString.java to >> check some issues described in bug #4511638 in addition to bug #4428022. >> >> Webrev containing new version of the regr

Reviewer needed - more test cases added to regression java/lang/Double/ToString.java

2011-03-09 Thread Pavel Tisnovsky
New version of the test firstly check all numbers+their string form and then throws an exception in case at least one number is converted incorrectly (this means that all conversions are printed to stdout). Can anybody please review this change? Thank you in advance Pavel Tisnovsky

Re: Please review correction of regression test Test6929067

2010-11-15 Thread Pavel Tisnovsky
Alan Bateman wrote: > Pavel Tisnovsky wrote: >> Hi, >> >> can anybody please review correction of regression test >> runtime/6929067/Test6929067? >> >> I changed this test in a way that it now correctly works on x86_64 >> platform for e

Please review correction of regression test Test6929067

2010-11-15 Thread Pavel Tisnovsky
Hi, can anybody please review correction of regression test runtime/6929067/Test6929067? I changed this test in a way that it now correctly works on x86_64 platform for example. Webrev is available at: http://cr.openjdk.java.net/~ptisnovs/JTreg_Test6929067/ Thank you in advance Pavel

Please review changes in regression test test/java/security/Provider/Turkish.java

2010-01-18 Thread Pavel Tisnovsky
-dev/2009-December/thread.html#1056 Thanks in advance Pavel Tisnovsky Red Hat QA

Re: Please review changes in regression test java/util/jar/JarFile/TurkCert.java

2009-12-22 Thread Pavel Tisnovsky
hange seems reasonable. -Chris. Pavel Tisnovsky wrote: Hi, please review changes in regression test java/util/jar/JarFile/TurkCert.java. Webrev is available at http://cr.openjdk.java.net/~ptisnovs/TurkCert/ We discussed this issue on jdk6-dev mailing list, concretely in this thread:

Please review changes in regression test java/util/jar/JarFile/TurkCert.java

2009-12-18 Thread Pavel Tisnovsky
/thread.html#1056 Thanks in advance Pavel Tisnovsky Red Hat QA

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Pavel Tisnovsky
dress. Pavel Christopher Hegarty -Sun Microsystems Ireland wrote: [cc'ing net-dev] Alan Bateman wrote: Pavel Tisnovsky wrote: Hi, two-lines patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinIf/

Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Pavel Tisnovsky
) returned by NetworkInterface.getNetworkInterfaces(). Patch check, if the given network interface is able to send multicast packets. I think, the patch could be applied to OpenJDK6 too. Pavel Tisnovsky