Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

evant test set, > which came back all clear. > > The change is pushed now. > > Thanks, > > Julia > > On 19/07/2020 11:48, Lisa Li wrote: > > Hi Julia， > > > > Apologies for the delay. Please review the updated fix for JDK-8245694 > > <https://bug

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

bEntrySet.size(), 1); + +assertTrue(bEntrySet.retainAll(aEntrySet)); +assertTrue(bEntrySet.isEmpty()); +assertEquals(aEntrySet.size(), 2); + +aEntrySet.clear(); +assertTrue(aEntrySet.isEmpty()); +} + +@Test +public void testEntrySetExceptionWhenAdd()

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Great, thanks Julia! Best regards, Yu L. On Mon, Jun 22, 2020 at 9:56 PM Julia Boes wrote: > Hi Yu, > > Just to confirm, for src/java.base/share/classes/java/util/Properties.java > the copyright should be updated as : > > + * Copyright (c) 1995, 2020, Oracle and/or its affiliates. All rights >

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Hi Julia, Sorry 'bout the rookie mistake. Thanks a lot for the clarification! Just to confirm, for src/java.base/share/classes/java/util/Properties.java the copyright should be updated as : + * Copyright (c) 1995, 2020, Oracle and/or its affiliates. All rights Because 1995 was the year when the

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

, 1); + +assertTrue(bEntrySet.retainAll(aEntrySet)); +assertTrue(bEntrySet.isEmpty()); +assertEquals(aEntrySet.size(), 2); + +aEntrySet.clear(); + assertTrue(aEntrySet.isEmpty()); +} + +@Test +public void testEntrySetExceptionWhenAdd() { +Properties

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Thanks for all your suggestions Brent! They helped a lot. Best regards, Yu L. On Tue, Jun 9, 2020 at 7:24 AM Brent Christian wrote: > Looks good to me as well. Thanks for making the updates to the test case. > > -Brent > > On 6/8/20 2:38 AM, Julia Boes wrote: > > Hi Yu Li, > > > > The copyrigh

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Hi Julia, Thanks a lot! Didn't realise I was allowed to modify the copyright of Properties.java. Sure, will do! Best regards, Yu L. On Mon, Jun 8, 2020 at 5:41 PM Julia Boes wrote: > Hi Yu Li, > > The copyright year of Properties.java needs to be updated to 2020. > Otherwise looks good to me!

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

ntrySet.clear(); +assertTrue(aEntrySet.isEmpty()); +} + +@Test +public void testEntrySetExceptionWhenAdd() { +Properties a = new Properties(); +a.setProperty("p1", "1"); +var aEntrySet = a.entrySet(); + +Properties b = new

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

> return this == o || entrySet.equals(o); > } > > This is consistent with the collection wrapper classes in j.u.Collections. > > Jason > > ____ > From: core-libs-dev on behalf of > Lisa Li > Sent: Saturday, May 30, 2020 9:28 A

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

et() to the Properties object as either > >> key or value; in Java 8 this would cause "(this Collection)" to be > >> included, while even with this fix that would cause a > >> StackOverflowError. However, given that it's only a corner case for > >>

[PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Hi, Please help review the fix for JDK-8245694 . And this is my very first patch submission. I know it's not perfect. *BUG DESCRIPTION*: JDK-8245694

[PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Hi, Please help review the fix for JDK-8245694 . And this is my very first patch submission. I know it's not perfect. *BUG DESCRIPTION*: JDK-8245694