Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Julian Waters
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. No need to worry, all you need to do is comment to reset the timer. There's nothing much else to do besides creating a JBS issue related to the PR (You do need one for the checks to pass, unfortunately I can't help you

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Julian Waters
On Mon, 7 Mar 2022 13:40:48 GMT, Erik Joelsson wrote: > > Should I change the JBS issue title to match the PR title, or is it > > preferred for the PR title to change? > > They need to match. You can either do it manually, or change the title to > just the bug number and the bot will change it

Re: New methods in PriorityQueue

2022-03-06 Thread Julian Waters
s to @TheShermanTanker! best regards, Julian On Fri, Mar 4, 2022 at 3:08 PM Julian Waters wrote: > Hi all, > > I apologize for the confusion, it seems like something went awry on my end > with the mailing lists, since there are apparently now 2 copies of the same > thread with

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Julian Waters
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Nice, good work matteo Should I change the JBS issue title to match the PR title, or is it preferred for the PR title to chang

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Julian Waters
On Fri, 25 Feb 2022 15:40:09 GMT, Matteo Baccan wrote: >> Hi >> >> I have reviewed the code for removing double semicolons at the end of lines >> >> all the best >> matteo > > Hi > > I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted. > Now: what is the next step? > > T

Re: New methods in PriorityQueue

2022-03-03 Thread Julian Waters
orityQueue. > > > > Regards, Roger > > > > > > On 3/3/22 6:59 AM, Jules W. wrote: > >> Hi all, > >> > >> A new PR that adds methods to PriorityQueue was created some time ago at > >> https://github.com/openjdk/jdk/pull/6938 but has no corresponding > issue. As > >> I'm not too familiar with this part of the JDK I'm querying this mailing > >> list for anyone to properly review the PR before I create an issue for > it > >> in the JBS > >> > >> best regards, > >> Julian Waters > > >

Re: PriorityQueue PR requiring review

2022-03-03 Thread Julian Waters
I understand, I'll notify the author about this. I'm not sure if they'll be alright with discussing on the mailing lists though, since they have expressed that they prefer discussing it on the PR itself best regards, Julian Waters On Thu, Mar 3, 2022 at 8:57 PM David Holmes wr

Re: PriorityQueue PR requiring review

2022-03-03 Thread Julian Waters
> an issue, the system will not send the email to the mailing lists. > > I see someone is helping you create the issue so things should progress > in that sense. But note the bar for adding to a public API is set very > high. > > Cheers, > David > > > best regards, > > Julian Waters >

Re: PriorityQueue PR requiring review

2022-03-03 Thread Julian Waters
ss they go looking for it, as without the association with > > an issue, the system will not send the email to the mailing lists. > > > > I see someone is helping you create the issue so things should progress > > in that sense. But note the bar for adding to a public API is set very > > high. > > > > Cheers, > > David > > > >> best regards, > >> Julian Waters >