On Tue, 4 May 2021 13:07:34 GMT, Jason Zaugg wrote:
> If the given Path represents a file, use the overload of read defined
> in FileChannel that accepts an explicit position and avoid serializing
> reads.
>
> Note: The underlying NIO implementation is not requir
On Thu, 6 May 2021 08:05:12 GMT, Jason Zaugg wrote:
>> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 1235:
>>
>>> 1233: synchronized(ch) {
>>> 1234: return ch.position(pos).read(bb);
>>> 1235: }
3.301 ms/op
>
>
> To:
>
>
> BenchmarkMode Cnt Score Error Units
> ZipFileSystemBenchmark.read avgt 10 12.520 ? 0.875 ms/op
Jason Zaugg has updated the pull request incrementally with one additional
commit since the last revision:
[zipfs] Add
On Thu, 6 May 2021 07:41:00 GMT, Alan Bateman wrote:
>> Jason Zaugg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove redundant cast from previous commit.
>
> src/jdk.zipfs/share/classes/jdk/nio/zipf
3.301 ms/op
>
>
> To:
>
>
> BenchmarkMode Cnt Score Error Units
> ZipFileSystemBenchmark.read avgt 10 12.520 ? 0.875 ms/op
Jason Zaugg has updated the pull request incrementally with one additional
commit since the last revision:
Remove redund
On Wed, 5 May 2021 23:23:21 GMT, Jason Zaugg wrote:
>> I think using the positional read on the underlying FileChannel is okay. I'm
>> puzzled by the previous code as I would have expected it to restore the
>> position (make me wonder if there are zipfs tests for this)
3.301 ms/op
>
>
> To:
>
>
> BenchmarkMode Cnt Score Error Units
> ZipFileSystemBenchmark.read avgt 10 12.520 ? 0.875 ms/op
Jason Zaugg has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 5 May 2021 16:03:17 GMT, Alan Bateman wrote:
>> Yes, I plan to look at this. It would also be good to have a couple of
>> additional reviews as well :-)
>
> I think using the positional read on the underlying FileChannel is okay. I'm
> puzzled by the previous code as I would have expec
3.301 ms/op
>
>
> To:
>
>
> BenchmarkMode Cnt Score Error Units
> ZipFileSystemBenchmark.read avgt 10 12.520 ? 0.875 ms/op
Jason Zaugg has updated the pull request incrementally with one additional
commit since the last revision:
Use patt
If the given Path represents a file, use the overload of read defined
in FileChannel that accepts an explicit position and avoid serializing
reads.
Note: The underlying NIO implementation is not required to implement
FileChannel.read(ByteBuffer, long) concurrently; Windows still appears
to lock, a
10 matches
Mail list logo
