Integrated: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS

2022-03-28 Thread Ian Graves
On Fri, 18 Feb 2022 19:47:09 GMT, Ian Graves wrote: > Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters This pull request has now been integrated. Changeset: f01cce23 Author: Ian Graves URL: https://git.openjdk.java.net/jdk/

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v7]

2022-03-10 Thread Ian Graves
On Thu, 10 Mar 2022 16:23:13 GMT, Ian Graves wrote: >> Proposed change in behavior to correct inconsistencies between `\w` and `\b` >> metacharacters > > Ian Graves has refreshed the contents of this pull request, and previous > commits have been removed. Incremental vi

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v7]

2022-03-10 Thread Ian Graves
On Thu, 10 Mar 2022 16:23:13 GMT, Ian Graves wrote: >> Proposed change in behavior to correct inconsistencies between `\w` and `\b` >> metacharacters > > Ian Graves has updated the pull request incrementally with 196 additional > commits since the last revision: >

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v7]

2022-03-10 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with 196 additional commits since the last revision: - Merge branch 'bug-8264160' of github.com:igraves/jdk into bug-8

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v6]

2022-03-10 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding description of word-boundary regex - Changes: - all:

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v5]

2022-03-09 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing superfluous 'if' - Changes: - all: https://git.

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v4]

2022-03-09 Thread Ian Graves
On Wed, 9 Mar 2022 16:30:24 GMT, Brian Burkhalter wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updating with additional descriptors. Removing DataProvider import > > src/java.base

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v3]

2022-03-08 Thread Ian Graves
On Tue, 8 Mar 2022 18:54:13 GMT, Lance Andersen wrote: >> Ian Graves has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains six commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v4]

2022-03-08 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Updating with additional descriptors. Removing DataProvider import - C

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v3]

2022-03-08 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' of https://github.com/

Re: RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v2]

2022-03-08 Thread Ian Graves
> Proposed change in behavior to correct inconsistencies between `\w` and `\b` > metacharacters Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Bug id's to header and some other cleanup - Changes: -

Integrated: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag.

2022-03-08 Thread Ian Graves
On Mon, 14 Feb 2022 19:54:00 GMT, Ian Graves wrote: > Fixing a bug in `NFCCharProperty` where code falling through an if-statement > can prematurely set the matcher's `hitEnd` field to true. This pull request has now been integrated. Changeset: 3fc009be Author: Ian

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v4]

2022-03-07 Thread Ian Graves
> Fixing a bug in `NFCCharProperty` where code falling through an if-statement > can prematurely set the matcher's `hitEnd` field to true. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding back some missing CAN

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v2]

2022-03-07 Thread Ian Graves
On Tue, 8 Mar 2022 03:49:43 GMT, Jaikiran Pai wrote: >> Ian Graves has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - merging master >> - Catching erronious setting of matcher

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v3]

2022-03-07 Thread Ian Graves
> Fixing a bug in `NFCCharProperty` where code falling through an if-statement > can prematurely set the matcher's `hitEnd` field to true. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing errant newline ---

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v3]

2022-03-07 Thread Ian Graves
On Mon, 7 Mar 2022 23:05:55 GMT, Lance Andersen wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing errant newline > > src/java.base/share/classes/java/util/regex/Patt

RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS

2022-03-07 Thread Ian Graves
Proposed change in behavior to correct inconsistencies between `\w` and `\b` metacharacters - Commit messages: - Fixing bad javadoc - Merge remote-tracking branch 'upstream/master' into bug-8264160 - Updating spec - Proposed change for \b metacharacter Changes: https://git.openj

Re: RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. [v2]

2022-03-07 Thread Ian Graves
> Fixing a bug in `NFCCharProperty` where code falling through an if-statement > can prematurely set the matcher's `hitEnd` field to true. Ian Graves has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - mer

Integrated: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception

2022-02-22 Thread Ian Graves
On Wed, 16 Feb 2022 18:45:29 GMT, Ian Graves wrote: > This is a fix in the buggy way CIBackRef traverses unicode characters that > could be variable-length. Originally it followed the approach that BackRef > does, but failed to account for unicode characters that could be 2 > cha

Integrated: 8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java

2022-02-22 Thread Ian Graves
On Thu, 17 Feb 2022 18:02:20 GMT, Ian Graves wrote: > Adding a missing period per this doc bug. This pull request has now been integrated. Changeset: 41355e2d Author: Ian Graves URL: https://git.openjdk.java.net/jdk/commit/41355e2daa43fa8433bf77ed187979c49d453f4a Stats: 1 l

RFR: 8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java

2022-02-17 Thread Ian Graves
Adding a missing period per this doc bug. - Commit messages: - Adding missing period Changes: https://git.openjdk.java.net/jdk/pull/7521/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7521&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276686 Stats: 1 li

Re: RFR: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception [v2]

2022-02-16 Thread Ian Graves
this could potentially > result in multiple scans and codepoint conversions of the same matcher group > which could be long. The solution that adjusts the loop bounds on the fly > avoids this case. Ian Graves has updated the pull request incrementally with one additional commit since

Re: RFR: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception

2022-02-16 Thread Ian Graves
On Wed, 16 Feb 2022 21:00:00 GMT, Naoto Sato wrote: >> This is a fix in the buggy way CIBackRef traverses unicode characters that >> could be variable-length. Originally it followed the approach that BackRef >> does, but failed to account for unicode characters that could be 2 >> chars-long. T

RFR: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception

2022-02-16 Thread Ian Graves
This is a fix in the buggy way CIBackRef traverses unicode characters that could be variable-length. Originally it followed the approach that BackRef does, but failed to account for unicode characters that could be 2 chars-long. The upper bound (groupSize) for the traversing loop is set by the d

RFR: 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag.

2022-02-14 Thread Ian Graves
Fixing a bug in `NFCCharProperty` where code falling through an if-statement can prematurely set the matcher's `hitEnd` field to true. - Commit messages: - Catching erronious setting of matcher.hitEnd Changes: https://git.openjdk.java.net/jdk/pull/7466/files Webrev: https://webrev

Integrated: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException This pull request has now been integrated. Changeset: e3076552 Author: Ian Graves URL: https://git.openjdk.java.n

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Thanks @turbanoff , left off the JBS ID in the comment. - PR: https://git.openjdk.java.net/jdk/pull/7201

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match [v2]

2022-01-24 Thread Ian Graves
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Fixing docs and dates - Changes: - all:

RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
Replacing a buggy NullPointerException in `Pattern.compile()` with the proper PatternSyntaxException - Commit messages: - 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match Changes: https://git.openjdk.java.net/jdk/pull/7201/files Webrev: https://webre

Withdrawn: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
On Mon, 24 Jan 2022 16:22:08 GMT, Ian Graves wrote: > Replacing a buggy NPE with a PatternSyntaxException for cases with a bad > intersection operator. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/7199

RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
Replacing a buggy NPE with a PatternSyntaxException for cases with a bad intersection operator. - Commit messages: - 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match Changes: https://git.openjdk.java.net/jdk/pull/7199/files Webrev: https://webrevs.op

Re: RFR: 8276694: Pattern trailing unescaped backslash causes internal error

2022-01-11 Thread Ian Graves
On Mon, 20 Dec 2021 09:57:14 GMT, Masanori Yano wrote: > Could you please review the 8276694 bug fixes? > > A message specific for this exception should be printed instead of an > internal error. This fix adds a new check to output an appropriate exception > message when the regular expression

RFR: 8217496: Matcher.group() can return null after usePattern

2021-10-05 Thread Ian Graves
Specification update to clarify Matcher behavior to include a null return value. - Commit messages: - 8217496 Matcher.group() can return null after usePattern Changes: https://git.openjdk.java.net/jdk/pull/5827/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5827&range=

RFR: 8217501: Matcher.hitEnd returns false for incomplete surrogate pairs

2021-09-27 Thread Ian Graves
Fixing a bug where character matcher doesn't mark hitEnd as true if it's a code point with more than one character. - Commit messages: - 8217501: Matcher.hitEnd returns false for incomplete surrogate pairs Changes: https://git.openjdk.java.net/jdk/pull/5725/files Webrev: https://w

Integrated: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure

2021-09-15 Thread Ian Graves
On Thu, 9 Sep 2021 04:19:07 GMT, Ian Graves wrote: > Relaxing some assertion bounds to allow for small error values that still > show improvement over previous summation method. This pull request has now been integrated. Changeset: f531b5c7 Author: Ian Graves URL:

Re: RFR: 8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice

2021-09-13 Thread Ian Graves
On Tue, 14 Sep 2021 00:15:31 GMT, David Holmes wrote: > Please review this trivial fix to add the missing comma. > > Thanks, > David LGTM. Thanks @dholmes-ora - PR: https://git.openjdk.java.net/jdk/pull/5504

Integrated: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark

2021-09-13 Thread Ian Graves
On Wed, 8 Sep 2021 20:24:31 GMT, Ian Graves wrote: > The duplicate condition in this chain of expressions needs to be shrunk to > drop a couple of character that are not excluded spacing marks. This pull request has now been integrated. Changeset: 3d9dc8f8 Author: Ian Grave

Re: RFR: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure [v3]

2021-09-13 Thread Ian Graves
> Relaxing some assertion bounds to allow for small error values that still > show improvement over previous summation method. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Factoring out Math.pow for squares - C

Re: RFR: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure [v2]

2021-09-13 Thread Ian Graves
On Mon, 13 Sep 2021 00:08:20 GMT, Joe Darcy wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tweaking asserts > > test/jdk/java/util/DoubleStreamSums/Compensa

Re: RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark [v2]

2021-09-10 Thread Ian Graves
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote: >> The duplicate condition in this chain of expressions needs to be shrunk to >> drop a couple of character that are not excluded spacing marks. > > Ian Graves has updated the pull request incrementally with one additional

Re: RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark [v2]

2021-09-10 Thread Ian Graves
> The duplicate condition in this chain of expressions needs to be shrunk to > drop a couple of character that are not excluded spacing marks. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Refactoring test to wh

Re: RFR: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure [v2]

2021-09-09 Thread Ian Graves
> Relaxing some assertion bounds to allow for small error values that still > show improvement over previous summation method. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Tweaking asserts - Changes: - all:

RFR: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure

2021-09-08 Thread Ian Graves
Relaxing some assertion bounds to allow for small error values that still show improvement over previous summation method. - Commit messages: - Dropping unnecessary equals case - Dropping equals zero assert Changes: https://git.openjdk.java.net/jdk/pull/5430/files Webrev: https:/

RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark

2021-09-08 Thread Ian Graves
The duplicate condition in this chain of expressions needs to be shrunk to drop a couple of character that are not excluded spacing marks. - Commit messages: - 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark Changes: https://git.openjdk.ja

Integrated: 8214761: Bug in parallel Kahan summation implementation

2021-09-02 Thread Ian Graves
On Fri, 2 Jul 2021 20:12:39 GMT, Ian Graves wrote: > 8214761: Bug in parallel Kahan summation implementation This pull request has now been integrated. Changeset: dd871819 Author: Ian Graves URL: https://git.openjdk.java.net/jdk/commit/dd871819a05886ee09fc00c7c778268440ebedb7 St

Re: RFR: 8214761: Bug in parallel Kahan summation implementation [v4]

2021-09-01 Thread Ian Graves
> 8214761: Bug in parallel Kahan summation implementation Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Fixing compensation test - Changes: - all: https://git.openjdk.java.net/jdk/pull/4674/files - new: ht

Re: RFR: 8214761: Bug in parallel Kahan summation implementation [v3]

2021-08-31 Thread Ian Graves
> 8214761: Bug in parallel Kahan summation implementation Ian Graves has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since

Integrated: 8271302: Regex Test Refresh

2021-08-30 Thread Ian Graves
On Wed, 11 Aug 2021 18:22:42 GMT, Ian Graves wrote: > 8271302: Regex Test Refresh This pull request has now been integrated. Changeset: fecefb85 Author: Ian Graves URL: https://git.openjdk.java.net/jdk/commit/fecefb8541d5056b1a8b105126ac9c566875e056 Stats: 2253 lines in 3 fi

Re: RFR: 8271302: Regex Test Refresh [v5]

2021-08-30 Thread Ian Graves
> 8271302: Regex Test Refresh Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing some notes re JUnit5 - Changes: - all: https://git.openjdk.java.net/jdk/pull/5092/files - new: https://git.openjdk.java.net/

Re: RFR: 8271302: Regex Test Refresh [v4]

2021-08-30 Thread Ian Graves
On Fri, 27 Aug 2021 23:18:34 GMT, Stuart Marks wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Additional cleanup > > test/jdk/java/util/regex/RegExTest.java line 85: > >> 8

Re: RFR: 8271302: Regex Test Refresh [v4]

2021-08-20 Thread Ian Graves
> 8271302: Regex Test Refresh Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Additional cleanup - Changes: - all: https://git.openjdk.java.net/jdk/pull/5092/files - new: https://git.openjdk.java.net/jdk/pull/5

Re: RFR: 8271302: Regex Test Refresh [v3]

2021-08-20 Thread Ian Graves
> 8271302: Regex Test Refresh Ian Graves has updated the pull request incrementally with one additional commit since the last revision: some quick fixes - Changes: - all: https://git.openjdk.java.net/jdk/pull/5092/files - new: https://git.openjdk.java.net/jdk/pull/5092/fi

Re: RFR: 8271302: Regex Test Refresh [v2]

2021-08-20 Thread Ian Graves
On Fri, 20 Aug 2021 13:32:24 GMT, Pavel Rappo wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Couple of fixes > > test/jdk/java/util/regex/NegativeArraySize.java line 29: > >>

Re: RFR: 8271302: Regex Test Refresh [v2]

2021-08-18 Thread Ian Graves
On Fri, 13 Aug 2021 20:17:56 GMT, Brent Christian wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Couple of fixes > > test/jdk/java/util/regex/RegExTest.java line 3952: >

Re: RFR: 8271302: Regex Test Refresh [v2]

2021-08-18 Thread Ian Graves
> 8271302: Regex Test Refresh Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Couple of fixes - Changes: - all: https://git.openjdk.java.net/jdk/pull/5092/files - new: https://git.openjdk.java.net/jdk/pull/5092/fi

Re: RFR: 8271302: Regex Test Refresh

2021-08-18 Thread Ian Graves
On Fri, 13 Aug 2021 20:16:22 GMT, Brent Christian wrote: >> 8271302: Regex Test Refresh > > test/jdk/java/util/regex/RegExTest.java line 2362: > >> 2360: >> 2361: { "test\ud834\uddc0", "test\ud834\uddc0", >>"m", true }, >> 2362: //{ "test\ud834\uddbc\ud

RFR: 8271302: Regex Test Refresh

2021-08-11 Thread Ian Graves
8271302: Regex Test Refresh - Commit messages: - Migrating regular expression tests to TestNG Changes: https://git.openjdk.java.net/jdk/pull/5092/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5092&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271302 St

Re: RFR: 8271302: Regex Test Refresh

2021-08-11 Thread Ian Graves
On Wed, 11 Aug 2021 18:22:42 GMT, Ian Graves wrote: > 8271302: Regex Test Refresh This PR migrates all regular expression tests in the jdk/java/util/regex directory to use TestNG assertions and annotations. The assertions utilized for this refresh are shared in common with standard ones f

Integrated: 8269753: Misplaced caret in PatternSyntaxException's detail message

2021-07-26 Thread Ian Graves
On Mon, 26 Jul 2021 18:10:03 GMT, Ian Graves wrote: > Fixes a bug where carets aren't indented correctly in PatternSyntaxException > messages because tab characters are converted to spaces in their indentation. This pull request has now been integrated. Changeset: bb508e13 Aut

Re: RFR: 8269753: Misplaced caret in PatternSyntaxException's detail message [v3]

2021-07-26 Thread Ian Graves
> Fixes a bug where carets aren't indented correctly in PatternSyntaxException > messages because tab characters are converted to spaces in their indentation. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Tweaking s

Re: RFR: 8269753: Misplaced caret in PatternSyntaxException's detail message [v2]

2021-07-26 Thread Ian Graves
> Fixes a bug where carets aren't indented correctly in PatternSyntaxException > messages because tab characters are converted to spaces in their indentation. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Copy

Re: RFR: 8269753: Misplaced caret in PatternSyntaxException's detail message

2021-07-26 Thread Ian Graves
On Mon, 26 Jul 2021 18:10:03 GMT, Ian Graves wrote: > Fixes a bug where carets aren't indented correctly in PatternSyntaxException > messages because tab characters are converted to spaces in their indentation. @pavelrappo - PR: https://git.openjdk.java.net/jdk/pull/4906

RFR: 8269753: Misplaced caret in PatternSyntaxException's detail message

2021-07-26 Thread Ian Graves
Fixes a bug where carets aren't indented correctly in PatternSyntaxException messages because tab characters are converted to spaces in their indentation. - Commit messages: - 8269753: Misplaced caret in PatternSyntaxException's detail message Changes: https://git.openjdk.java.net/

Integrated: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-07-23 Thread Ian Graves
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote: > 8199594: Add doc describing how (?x) ignores spaces in character classes This pull request has now been integrated. Changeset: a1c0a6aa Author: Ian Graves URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8214761: Bug in parallel Kahan summation implementation [v2]

2021-07-22 Thread Ian Graves
On Wed, 21 Jul 2021 20:19:31 GMT, Ian Graves wrote: >> 8214761: Bug in parallel Kahan summation implementation > > Ian Graves has updated the pull request incrementally with three additional > commits since the last revision: > > - Updates with more test coverage >

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-21 Thread Ian Graves
> 8199594: Add doc describing how (?x) ignores spaces in character classes Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Rewording repetitive phrase - Changes: - all: https://git.openjdk.java.net/jdk/pull/4618/fi

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
On Wed, 21 Jul 2021 21:30:01 GMT, Lance Andersen wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete errant line > > src/java.base/share/classes/java/util/regex/Pattern.java line 75

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
On Wed, 21 Jul 2021 20:22:04 GMT, Pavel Rappo wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete errant line > > src/java.base/share/classes/java/util/regex/Pattern.java line 83

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
> 8199594: Add doc describing how (?x) ignores spaces in character classes Ian Graves has updated the pull request incrementally with one additional commit since the last revision: delete errant line - Changes: - all: https://git.openjdk.java.net/jdk/pull/4618/files -

Re: RFR: 8214761: Bug in parallel Kahan summation implementation [v2]

2021-07-21 Thread Ian Graves
> 8214761: Bug in parallel Kahan summation implementation Ian Graves has updated the pull request incrementally with three additional commits since the last revision: - Updates with more test coverage - stashing - Stashing - Changes: - all: https://git.openjdk.java.net/

Re: RFR: 8214761: Bug in parallel Kahan summation implementation

2021-07-06 Thread Ian Graves
On Fri, 2 Jul 2021 21:30:56 GMT, stefan-zobel wrote: >> 8214761: Bug in parallel Kahan summation implementation > > src/java.base/share/classes/java/util/DoubleSummaryStatistics.java line 161: > >> 159: >> 160: //Negating this value because low-order bits are in negated form >> 161:

RFR: 8214761: Bug in parallel Kahan summation implementation

2021-07-02 Thread Ian Graves
8214761: Bug in parallel Kahan summation implementation - Commit messages: - 8214761: Bug in parallel Kahan summation implementation Changes: https://git.openjdk.java.net/jdk/pull/4674/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4674&range=00 Issue: https://bugs.o

Integrated: 8268664: The documentation of the Scanner.hasNextLine is incorrect

2021-07-02 Thread Ian Graves
On Tue, 22 Jun 2021 04:22:34 GMT, Ian Graves wrote: > 8268664: The documentation of the Scanner.hasNextLine is incorrect This pull request has now been integrated. Changeset: 0d0f6a4b Author: Ian Graves URL: https://git.openjdk.java.net/jdk/com

RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-06-28 Thread Ian Graves
8199594: Add doc describing how (?x) ignores spaces in character classes - Commit messages: - Updating documentation on comments mode and character class whitespace Changes: https://git.openjdk.java.net/jdk/pull/4618/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4618&

RFR: 8268664: The documentation of the Scanner.hasNextLine is incorrect

2021-06-21 Thread Ian Graves
8268664: The documentation of the Scanner.hasNextLine is incorrect - Commit messages: - Clarifying docs on Scanner.hasNextLine() regarding line separators Changes: https://git.openjdk.java.net/jdk/pull/4547/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4547&range=00

Integrated: 8266155: Convert java.base to use Stream.toList()

2021-04-30 Thread Ian Graves
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote: > 8266155: Convert java.base to use Stream.toList() This pull request has now been integrated. Changeset: dd05158b Author: Ian Graves Committer: Pavel Rappo URL: https://git.openjdk.java.net/jdk/com

Integrated: 8260560: convert jdeps and jdeprscan tools to use Stream.toList()

2021-04-30 Thread Ian Graves
On Tue, 27 Apr 2021 00:20:49 GMT, Ian Graves wrote: > 8260560: convert jdeps and jdeprscan tools to use Stream.toList() This pull request has now been integrated. Changeset: c36c63a0 Author: Ian Graves Committer: Pavel Rappo URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8266155: Convert java.base to use Stream.toList() [v2]

2021-04-28 Thread Ian Graves
> 8266155: Convert java.base to use Stream.toList() Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Removing redundant imports - Changes: - all: https://git.openjdk.java.net/jdk/pull/3734/files - new: ht

RFR: 8266155: Convert java.base to use Stream.toList()

2021-04-27 Thread Ian Graves
8266155: Convert java.base to use Stream.toList() - Commit messages: - Migrating java.base to use Stream.toList() Changes: https://git.openjdk.java.net/jdk/pull/3734/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3734&range=00 Issue: https://bugs.openjdk.java.net/bro

RFR: 8260560: convert jdeps and jdeprscan tools to use Stream.toList()

2021-04-26 Thread Ian Graves
8260560: convert jdeps and jdeprscan tools to use Stream.toList() - Commit messages: - Updating jdeps and jdeprscan to use Stream.toList() Changes: https://git.openjdk.java.net/jdk/pull/3705/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3705&range=00 Issue: https://

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-04-21 Thread Ian Graves
> Clarifying note on comments mode to explicitly note that whitespace within > character classes is ignored. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Tweaking wording and placement - Changes: - all:

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-04-21 Thread Ian Graves
On Wed, 21 Apr 2021 02:56:12 GMT, Stuart Marks wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding differences to Perl 5 note > > A few minor wording adjustments. Please updat

Integrated: 8037397: RegEx pattern matching loses character class after intersection (&&) operator

2021-04-21 Thread Ian Graves
On Wed, 31 Mar 2021 20:38:33 GMT, Ian Graves wrote: > Bug fix with the intersection `&&` operator in regex patterns. In > JDK-8037397, some character classes on the right hand side of the operator > are dropped in cases where nested `[..]` classes are used with non "neste

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-04-19 Thread Ian Graves
> Clarifying note on comments mode to explicitly note that whitespace within > character classes is ignored. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding differences to Perl 5 note - Changes: - all:

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-04-19 Thread Ian Graves
On Mon, 19 Apr 2021 20:43:26 GMT, Ian Graves wrote: > Clarifying note on comments mode to explicitly note that whitespace within > character classes is ignored. Will put a /csr in to be safe. - PR: https://git.openjdk.java.net/jdk/pull/3577

RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-04-19 Thread Ian Graves
Clarifying note on comments mode to explicitly note that whitespace within character classes is ignored. - Commit messages: - Note about comments mode and character class whitespace Changes: https://git.openjdk.java.net/jdk/pull/3577/files Webrev: https://webrevs.openjdk.java.net/

Integrated: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits

2021-04-16 Thread Ian Graves
On Tue, 6 Apr 2021 20:34:52 GMT, Ian Graves wrote: > This fixes a bug where the formatting code for `%g` flags incorrectly tries > to round `BigDecimal` after determining whether it should be a decimal > numeric format or a scientific numeric format. The solution rounds before >

Re: RFR: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits [v3]

2021-04-16 Thread Ian Graves
On Fri, 16 Apr 2021 16:08:53 GMT, Ian Graves wrote: >> This fixes a bug where the formatting code for `%g` flags incorrectly tries >> to round `BigDecimal` after determining whether it should be a decimal >> numeric format or a scientific numeric format. The solu

Re: RFR: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits [v2]

2021-04-16 Thread Ian Graves
On Fri, 16 Apr 2021 14:26:58 GMT, Roger Riggs wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding BigDecimal equivalents to tests > > src/java.base/share/classes/java/util/Format

Re: RFR: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits [v3]

2021-04-16 Thread Ian Graves
> This fixes a bug where the formatting code for `%g` flags incorrectly tries > to round `BigDecimal` after determining whether it should be a decimal > numeric format or a scientific numeric format. The solution rounds before > determining the correct format. Ian Graves has upda

Re: RFR: 8214761: Bug in parallel Kahan summation implementation

2021-04-12 Thread Ian Graves
On Mon, 12 Apr 2021 19:45:24 GMT, Ian Graves wrote: > Fixes a bug where the compensated sum should be negated when added together > in the merge step of a given collector. This impacts accuracy of parallel > summations with Double streams and creates larger deviations from a

Withdrawn: 8214761: Bug in parallel Kahan summation implementation

2021-04-12 Thread Ian Graves
On Mon, 12 Apr 2021 19:45:24 GMT, Ian Graves wrote: > Fixes a bug where the compensated sum should be negated when added together > in the merge step of a given collector. This impacts accuracy of parallel > summations with Double streams and creates larger deviations from a

RFR: 8214761: Bug in parallel Kahan summation implementation

2021-04-12 Thread Ian Graves
Fixes a bug where the compensated sum should be negated when added together in the merge step of a given collector. This impacts accuracy of parallel summations with Double streams and creates larger deviations from a standard sequential (ie non-parallel) compensated summation. - C

Re: RFR: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits [v2]

2021-04-06 Thread Ian Graves
On Tue, 6 Apr 2021 22:56:22 GMT, Joe Darcy wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding BigDecimal equivalents to tests > > test/jdk/java/util/Formatter/BigDecimalR

Re: RFR: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits [v2]

2021-04-06 Thread Ian Graves
> This fixes a bug where the formatting code for `%g` flags incorrectly tries > to round `BigDecimal` after determining whether it should be a decimal > numeric format or a scientific numeric format. The solution rounds before > determining the correct format. Ian Graves has upda

RFR: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits

2021-04-06 Thread Ian Graves
This fixes a bug where the formatting code for `%g` flags incorrectly tries to round `BigDecimal` after determining whether it should be a decimal numeric format or a scientific numeric format. The solution rounds before determining the correct format. - Commit messages: - Fixing

Re: RFR: 8037397: Lost nested character class after intersection && [v4]

2021-04-02 Thread Ian Graves
> Bug fix with the intersection `&&` operator in regex patterns. In > JDK-8037397, some character classes on the right hand side of the operator > are dropped in cases where nested `[..]` classes are used with non "nested" > ones. Ian Graves has updated the pull

Re: RFR: 8037397: Lost nested character class after intersection && [v3]

2021-04-02 Thread Ian Graves
On Thu, 1 Apr 2021 00:33:26 GMT, Florent Guillaume wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding a test. > > src/java.base/share/classes/java/util/regex/Patt

Re: RFR: 8037397: Lost nested character class after intersection && [v3]

2021-04-02 Thread Ian Graves
> Bug fix with the intersection `&&` operator in regex patterns. In > JDK-8037397, some character classes on the right hand side of the operator > are dropped in cases where nested `[..]` classes are used with non "nested" > ones. Ian Graves has updated the pull

Re: RFR: 8037397: Lost nested character class after intersection && [v3]

2021-04-02 Thread Ian Graves
On Thu, 1 Apr 2021 14:21:20 GMT, Roger Riggs wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding a test. > > Please add a test. Tagging with CSR because this will impact a

  1   2   >