On Sat, 20 Feb 2021 19:20:48 GMT, Craig Andrews
wrote:
> `java.net.URLClassLoader.getResource` can throw an undocumented
> `IllegalArgumentException`.
>
> According to the javadoc for the `getResource` and `findResource` methods,
> neither should be throwing `IllegalArgumentEx
On Mon, 15 Mar 2021 16:26:35 GMT, Kevin Rushforth wrote:
> You need to fix this error:
>
> > Title mismatch between PR and JBS for issue JDK-8262277
>
> by changing the title of this PR to match the JBS title. Then you should be
> able to integrate it.
Done - how's it look now?
-
On Tue, 9 Mar 2021 08:40:47 GMT, Prasanta Sadhukhan
wrote:
>> Craig Andrews has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull re
e, ParseUtil.encodePath(name, false));
> } catch (MalformedURLException e) {
> throw new IllegalArgumentException("name");
> }
>
> Instead of throwing `IllegalArgumentException`, that line should simply
> return `null`.
Crai
On Fri, 5 Mar 2021 23:35:46 GMT, Brent Christian wrote:
>> Craig Andrews has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request co
On Thu, 4 Mar 2021 21:10:56 GMT, Craig Andrews
wrote:
>> Hi, Craig
>> The commented-out lines should be removed from the change.
>>
>> As Alan said, a regression test will be needed. At minimum, it should test
>> a method that returns a URL, as we
On Fri, 5 Mar 2021 15:46:40 GMT, Craig Andrews
wrote:
>> test/jdk/java/net/URLClassLoader/TestBug8262277.java line 30:
>>
>>> 28: * @summary Test to see if URLClassLoader.getResource and
>>> URLClassLoader.getResources
>>> 29: * throw IllegalArgument
On Fri, 5 Mar 2021 15:42:11 GMT, Alan Bateman wrote:
> I'd prefer if the test checked that findResource returned null and that
> findResources returned an empty enumeration.
I'll update the test accordingly.
> think we should be able to find a better name for the test too.
> Do you really wan
e, ParseUtil.encodePath(name, false));
> } catch (MalformedURLException e) {
> throw new IllegalArgumentException("name");
> }
>
> Instead of throwing `IllegalArgumentException`, that line should simply
> return `null`.
Crai
e, ParseUtil.encodePath(name, false));
> } catch (MalformedURLException e) {
> throw new IllegalArgumentException("name");
> }
>
> Instead of throwing `IllegalArgumentException`, that line should simply
> return `null`.
Crai
e, ParseUtil.encodePath(name, false));
> } catch (MalformedURLException e) {
> throw new IllegalArgumentException("name");
> }
>
> Instead of throwing `IllegalArgumentException`, that line should simply
> return `null`.
Crai
On Wed, 3 Mar 2021 18:10:25 GMT, Brent Christian wrote:
>The commented-out lines should be removed from the change.
Done! 👍
> As Alan said, a regression test will be needed. At minimum, it should test a
> method that returns a URL, as well as a method that returns an Enumeration
> (which can
On Sat, 20 Feb 2021 19:22:10 GMT, Craig Andrews
wrote:
>> _NOTE_: I've reported this issue at https://bugreport.java.com/ (internal
>> review ID : 9069151)
>>
>> `java.net.URLClassLoader.getResource` can throw an undocumented
>> `IllegalArgumentException`.
On Sat, 20 Feb 2021 19:20:48 GMT, Craig Andrews
wrote:
> _NOTE_: I've reported this issue at https://bugreport.java.com/ (internal
> review ID : 9069151)
>
> `java.net.URLClassLoader.getResource` can throw an undocumented
> `IllegalArgumentException`.
>
> Accord
_NOTE_: I've reported this issue at https://bugreport.java.com/ (internal
review ID : 9069151)
`java.net.URLClassLoader.getResource` can throw an undocumented
`IllegalArgumentException`.
According to the javadoc for the `getResource` and `findResource` methods,
neither should be throwing `Ille
15 matches
Mail list logo
