On Fri, 10 Jun 2022 08:36:57 GMT, Raffaello Giulietti
wrote:
> This fixes a bug introduced with JDK-8202449.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9120
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or
On Mon, 6 Jun 2022 22:24:03 GMT, Joe Darcy wrote:
>> Generally add apiNote's to map from Java library methods to particular IEEE
>> 754 operations. For now, I only added such notes to java.lang.Math and not
>> java.lang.StrictMath.
>
> Joe Darcy has updated the pull request incrementally with o
On Fri, 3 Jun 2022 16:48:46 GMT, Naoto Sato wrote:
> The code path calls `String.getBytesNoRepl()`, but it blindly replaces
> unmappable characters with replacements if the encoder is an `ArrayEncoder`.
> Changed only to do so if `doReplace` is `true` in
> `String.encodeWithEncoder()`.
Marked
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
`java.io` and `java.nio` look all right.
-
Marked as reviewed by bpb (Reviewer
On Wed, 1 Jun 2022 10:37:23 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
> On Jun 1, 2022, at 3:32 AM, Raffaello Giulietti wrote:
>
> On Tue, 31 May 2022 22:11:54 GMT, Brian Burkhalter wrote:
>
>>> Raffaello Giulietti has updated the pull request incrementally with one
>>> additional commit since the last revision:
>>>
On Jun 1, 2022, at 2:25 AM, Raffaello Giulietti
mailto:d...@openjdk.java.net>> wrote:
On Tue, 31 May 2022 21:57:44 GMT, Brian Burkhalter
mailto:b...@openjdk.org>> wrote:
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the l
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Wed, 25 May 2022 23:08:38 GMT, Brian Burkhalter wrote:
> If only a leftover `char` remains in the stream, do not add `-1` to the
> return value in `lockedRead()`.
This pull request has now been integrated.
Changeset: 6520843f
Author: Brian Burkhalter
URL:
If only a leftover `char` remains in the stream, do not add `-1` to the return
value in `lockedRead()`.
-
Commit messages:
- 8287003: InputStreamReader::read() can return zero despite writing a char in
the buffer
Changes: https://git.openjdk.java.net/jdk/pull/8895/files
Webrev: h
On Thu, 12 May 2022 07:59:36 GMT, John Hendrikx wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or
On Mon, 16 May 2022 21:29:22 GMT, Brian Burkhalter wrote:
> Add constant `java.math.BigDecimal.TWO`.
This pull request has now been integrated.
Changeset: 1d8e92ae
Author: Brian Burkhalter
URL:
https://git.openjdk.java.net/jdk/commit/1d8e92ae0d2d0d6740e2171abef45545439e6414
St
> Add constant `java.math.BigDecimal.TWO`.
Brian Burkhalter has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commit
since the l
Add constant `java.math.BigDecimal.TWO`.
-
Commit messages:
- 8213045: Add commonly used symbolic math constants to the JDK
Changes: https://git.openjdk.java.net/jdk/pull/8735/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8735&range=00
Issue: https://bugs.openjdk.ja
On Mon, 16 May 2022 15:43:45 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8286810: Use public [Double|Float].PRECISION fields in
>> jdk.internal.math.[Double|Float]Consts
>
> src/java.ba
On Mon, 16 May 2022 15:51:43 GMT, Raffaello Giulietti
wrote:
>> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8286810: Use public [Doubl
On Wed, 11 May 2022 20:47:52 GMT, Brian Burkhalter wrote:
> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
> indicate that `-1` is returned at the EOF of the last stream even if `len` is
> zero.
This pull request has now been integrated.
Changeset: dbd373
On Thu, 12 May 2022 19:00:05 GMT, Roger Riggs wrote:
> In the throws clauses, I think I would have put the additional conditional at
> the end of the sentence since the existing throws text corresponds to the
> exception. But the logic is correct as is.
I put it at the beginning as that is the
On Fri, 13 May 2022 21:17:22 GMT, Joe Darcy wrote:
> Update reference to the latest "Effective Java" version and switch to cite
> tags.
Looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8707
On Fri, 13 May 2022 07:14:30 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change that addresses
>> https://bugs.openjdk.java.net/browse/JDK-8286559?
>>
>> The commit here removes the `synchronized` on `mark` and `reset` methods of
>> `InflaterInputStream`. The `mark` method i
On Thu, 12 May 2022 15:56:34 GMT, Brian Burkhalter wrote:
> > I think the same change shall apply to the `@throws NullPointerException`
> > clause.
>
> Yeah looks like it.
Fixed by commit 111ea3e2f4203f05d17431953a5ffaa868176f98.
-
PR: https://git.openjdk.java.net/jdk/pull/8664
On Thu, 12 May 2022 15:50:47 GMT, Raffaello Giulietti
wrote:
> I think the same change shall apply to the `@throws NullPointerException`
> clause.
Yeah looks like it.
-
PR: https://git.openjdk.java.net/jdk/pull/8664
> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
> indicate that `-1` is returned at the EOF of the last stream even if `len` is
> zero.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
828620
On Thu, 12 May 2022 08:41:47 GMT, Raffaello Giulietti
wrote:
> Also, in the current implementation, when the end of the last contained
> stream has been reached and `-1` is returned, none of the arguments is
> checked, so a caller can pass `null` for `b` or out of bounds indices `off`
> and `
> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
> indicate that `-1` is returned at the EOF of the last stream even if `len` is
> zero.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
828620
On Thu, 12 May 2022 00:10:28 GMT, Joe Darcy wrote:
> Noticed by inspection during a CSR review, small refactoring to use a
> message-cause exception constructor when one is available.
>
> Will update the copyright before a push.
Marked as reviewed by bpb (Reviewer).
-
PR: https:/
On Wed, 11 May 2022 20:40:30 GMT, Joe Darcy wrote:
> While doing a CSR review of another issue, I noticed some cases in
> InputStream and OutputStream what would benefit from being upgraded to
> implSpec and related javadoc tags.
>
> The "A subclass must provide an implementation of this metho
On Wed, 11 May 2022 20:47:52 GMT, Brian Burkhalter wrote:
> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
> indicate that `-1` is returned at the EOF of the last stream even if `len` is
> zero.
The `InputStream.read(byte[],int,int)` specification indicates
Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
indicate that `-1` is returned at the EOF of the last stream even if `len` is
zero.
-
Commit messages:
- 8286200: SequenceInputStream::read(b, off, 0) returns -1 at EOF
Changes: https://git.openjdk.java.net/
On Wed, 11 May 2022 16:30:41 GMT, Roger Riggs wrote:
>> PR#8599 8244681: proposes to add compiler warnings for possible lossy
>> conversions
>> From the CSR:
>>
>> "If the type of the right-hand operand of a compound assignment is not
>> assignment compatible with the type of the variable, a c
Redirect discussion to nio-dev.
Brian
> On May 11, 2022, at 7:29 AM, Maxim Kartashev
> wrote:
>
> Win32 documentation [1] kind of discourages the use of space at the very
> end of a file name. Based on that, JDK-8190546 (File.toPath() reject
> directory names with trailing space) had been clos
On Tue, 10 May 2022 20:22:39 GMT, Naoto Sato wrote:
> `String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter
> replaces on malformed/unmappable characters with replacements. However, there
> was a code path that lacked to set the `CodingErrorAction.REPLACE` on the
> decode
On Tue, 10 May 2022 21:32:10 GMT, Roger Riggs wrote:
> PR#8599 8244681: proposes to add compiler warnings for possible lossy
> conversions
> From the CSR:
>
> "If the type of the right-hand operand of a compound assignment is not
> assignment compatible with the type of the variable, a cast is
On Mon, 9 May 2022 15:26:20 GMT, Brian Burkhalter wrote:
> Add missing `@since 19` tag.
This pull request has now been integrated.
Changeset: 04bba07d
Author: Brian Burkhalter
URL:
https://git.openjdk.java.net/jdk/commit/04bba07d6588cb96e371f3acdb49d735c9e6536d
Stats: 1 line
Add missing `@since 19` tag.
-
Commit messages:
- 8286363: BigInteger.parallelMultiply missing @since 19
Changes: https://git.openjdk.java.net/jdk/pull/8598/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8598&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8
On Fri, 6 May 2022 11:32:25 GMT, Claes Redestad wrote:
> A few untested and unused methods in `VerifyType` which can be removed.
> (Possibly used by native JSR 292 implementations in JDK 7).
Looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/
On Tue, 19 Apr 2022 08:40:51 GMT, Raffaello Giulietti
wrote:
> Please review these small changes to address intermittent failures, as of
> JDK-8274517.
>
> - Usage of jdk.test.lib.RandomFactory for reproducible random generation.
> - Slightly less restrictive assertion about badParallelStreamE
On Thu, 28 Apr 2022 20:02:36 GMT, Brian Burkhalter wrote:
>> Modify native multi-byte read-write code used by the `java.io` classes to
>> limit the size of the allocated native buffer thereby decreasing off-heap
>> memory footprint and increasing throughput.
>
> Bria
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE home page
> for "75
On Wed, 27 Apr 2022 20:10:03 GMT, Brian Burkhalter wrote:
> Please review this request to remove the `synchronized` keyword from the
> `mark(int)` and `reset()` methods of `java.io.PushbackInputStream`.
This pull request has now been integrated.
Changeset: 9d8c3bf9
Author: Brian Burk
On Sat, 30 Apr 2022 00:14:29 GMT, Tyler Steele wrote:
> PollingWatchService.java contains the WatchService and WatchKey
> implementation for AIX and BSD. When a Path is
> [register](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/file/Path.html#register(java.nio.file.Watch
On Thu, 28 Apr 2022 20:13:48 GMT, Uwe Schindler wrote:
> By the way: FileOutputStream has exactly the same problem with
> `write(byte[])`. I see no test for it, but I assume this is now also fixed.
> That's a longstanding issue in Lucene (this is why we use a
> ChunkedOutputStream when writing
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Brian Burkhalter has updated the pull request incrementally with one additional
commit
On Mon, 25 Apr 2022 04:35:13 GMT, Sergey Bylokhov wrote:
> The new test added as part of the
> [JDK-8285445](https://bugs.openjdk.java.net/browse/JDK-8285445) cannot
> trigger that bug and pass w/ and w/o fix.
>
> An updated test validates the "default" case when the `jdk.io.File.enableADS`
>
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Wed, 27 Apr 2022 20:10:03 GMT, Brian Burkhalter wrote:
> Please review this request to remove the `synchronized` keyword from the
> `mark(int)` and `reset()` methods of `java.io.PushbackInputStream`.
Please see also https://github.com/openjdk/jdk/pull/8309.
-
PR:
Please review this request to remove the `synchronized` keyword from the
`mark(int)` and `reset()` methods of `java.io.PushbackInputStream`.
-
Commit messages:
- 8285745: Re-examine PushbackInputStream mark/reset
Changes: https://git.openjdk.java.net/jdk/pull/8433/files
Webrev: ht
On Wed, 27 Apr 2022 07:34:29 GMT, Raffaello Giulietti
wrote:
>> The spec of the interface `java.util.random.RandomGenerator` is slightly
>> incorrect when it discusses `float` and `double` random values.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional c
On Tue, 26 Apr 2022 16:55:44 GMT, Raffaello Giulietti
wrote:
>> The spec of the interface `java.util.random.RandomGenerator` is slightly
>> incorrect when it discusses `float` and `double` random values.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional c
On Tue, 19 Apr 2022 23:26:44 GMT, Brian Burkhalter wrote:
> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
> of `java.io.FilterInputStream`.
This pull request has now been integrated.
Changeset: a3b78814
Author: Brian Burkhalter
URL:
On Sat, 23 Apr 2022 01:11:56 GMT, Brian Burkhalter wrote:
> Change the default value of the `jdk.io.File.enableADS` property to `true`.
This pull request has now been integrated.
Changeset: 03cbb48e
Author: Brian Burkhalter
URL:
https://git.openjdk.java.net/jdk/com
On Sat, 23 Apr 2022 01:11:56 GMT, Brian Burkhalter wrote:
> Change the default value of the `jdk.io.File.enableADS` property to `true`.
This topic will be examined further under JDK-8285511.
-
PR: https://git.openjdk.java.net/jdk/pull/8373
Change the default value of the `jdk.io.File.enableADS` property to `true`.
-
Commit messages:
- 8285445: cannot open file "NUL:"
Changes: https://git.openjdk.java.net/jdk/pull/8373/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8373&range=00
Issue: https://bugs.open
On Thu, 21 Apr 2022 10:13:11 GMT, Lance Andersen wrote:
> Looks fine Brian. Any thoughts as to whether a release note is warranted?
Thanks, @LanceAndersen. The issue is labelled as needing a release note so you
are spot on.
-
PR: https://git.openjdk.java.net/jdk/pull/8309
On Thu, 21 Apr 2022 00:00:47 GMT, Stuart Marks wrote:
>
> I think it's a vanishingly small possibility that anything is relying on the
> synchronization in these methods. Synchronization here would provide proper
> memory visibility effects across threads. To use input streams from multiple
>
On Tue, 19 Apr 2022 23:34:01 GMT, Joe Darcy wrote:
> Simple refactoring to use new-in19 library code.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8310
> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
> of `java.io.FilterInputStream`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8284930: Also remove synchronized keyword from mark() and
Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods of
`java.io.FilterInputStream`.
-
Commit messages:
- 8284930: Re-examine FilterInputStream mark/reset
Changes: https://git.openjdk.java.net/jdk/pull/8309/files
Webrev: https://webrevs.openjdk.java.net/?re
On Thu, 14 Apr 2022 05:57:54 GMT, Daniel Jeliński wrote:
> The benchmark results are quite unexpected. Would we benefit from reducing
> the buffer size even further?
I tested with smaller and smaller buffer sizes until the performance started to
be affected which was about 64 KB. I have not ch
On Thu, 14 Apr 2022 06:23:24 GMT, Alan Bateman wrote:
>> Modify native multi-byte read-write code used by the `java.io` classes to
>> limit the size of the allocated native buffer thereby decreasing off-heap
>> memory footprint and increasing throughput.
>
> src/java.base/share/native/libjava/i
On Fri, 15 Apr 2022 19:34:33 GMT, Pavel Rappo wrote:
> People rarely include JDK elements with package access in a javadoc run. That
> is why bugs in those elements' doc comments tend to remain unnoticed.
>
> There are many more bugs in the doc comments of the JDK elements with the
> package a
On Thu, 14 Apr 2022 01:40:50 GMT, Brian Burkhalter wrote:
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Curr
Modify native multi-byte read-write code used by the `java.io` classes to limit
the size of the allocated native buffer thereby decreasing off-heap memory
footprint and increasing throughput.
-
Commit messages:
- 6478546: FileInputStream.read() throws OutOfMemoryError when there is
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote:
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
Expect the Unexpeted.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8231
On Tue, 12 Apr 2022 15:37:19 GMT, Raffaello Giulietti
wrote:
> Please review this tiny fix.
>
> A test similar to the code proposed by the bug reporter has been added for
> the LXM group. It does not pass before the fix and passes after.
Marked as reviewed by bpb (Reviewer).
-
P
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote:
> `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no
> corresponding `@since` in the javadoc. The absence of `@since` makes it
> impossible for IDEs to check for misuse of it, it may be misused by users
> targeting Java 8 and cr
On Sat, 9 Oct 2021 19:02:17 GMT, XenoAmess wrote:
>>> in extream situation, when doing this.skipBuffer = skipBuffer in Thread B,
>>> it might make this.skipBuffer to a byte[6] in thread A, and thus cause a
>>> IndexOutofBoundException in Thread A.
>>
>> No, it won't. The later `skipBuffer` ref
On Mon, 11 Apr 2022 12:32:26 GMT, Jim Laskey wrote:
>> `default float nextFloat(float origin, float bound); ` and `default double
>> nextDouble(double origin, double bound); ` are documented incorrectly. The
>> default method checks (origin < bound) and (bound - origin) < +infinity.
>>
>> The
> Minimal version of possible fixes: make the bulk read `@return` verbiage
> consistent in the `java.io` package.
Brian Burkhalter has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the pr
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote:
> A few integer divisions and multiplications can be replaced with test +
> addition, leading to a decent speed-up on java.time microbenchmarks such as
> `GetYearBench`. Numbers from my local x86 workstation, seeing similar
> speed-up on
Minimal version of possible fixes: make the bulk read `@return` verbiage
consistent in the `java.io` package.
-
Commit messages:
- 5087440: (ch spec) java.io,nio bulk read(...) end-of-stream return value
descriptions ambiguous
Changes: https://git.openjdk.java.net/jdk/pull/8044/fi
On Tue, 29 Mar 2022 09:15:01 GMT, Andrey Turbanov wrote:
> It was no longer used due to JDK-4479184 long ago.
It builds so looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8013
On Sun, 20 Mar 2022 13:20:31 GMT, Andrey Turbanov wrote:
> String.toString() calls doesn't make much sense. Only one place, where it
> could be used - to generate NPE. But in a few places of JDK codebase it's
> called, even when NPE will happen anyway.
> I propose to cleanup such places.
> Foun
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote:
> In a few places String.indexOf/lastIndexOf methods are called with default
> parameter for index: `0` for `indexOf`, length() for `lastIndexOf`.
> I propose to cleanup such calls. It makes code a bit easier to read. In case
> of `indexO
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote:
>> Fixing the out-of-date number of entries in
>> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
>> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
>> correctly has the `map.size()` value.
>
>
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote:
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Marked
On Mon, 14 Mar 2022 20:52:39 GMT, Joe Darcy wrote:
> Add a constant for tau, 2*pi, to Math and StrictMath. Since 2*pi is a very
> common value in mathematical formulas, it is helpful to give it a distinct
> constant.
>
> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-82831
On Thu, 10 Mar 2022 02:30:35 GMT, Brian Burkhalter wrote:
> Add a statement to the `java.io` package documentation clarifying how a
> `String` representing a _pathname string_ is interpreted in the package.
This pull request has now been integrated.
Changeset: 13cebffe
Author:
On Thu, 10 Mar 2022 02:30:35 GMT, Brian Burkhalter wrote:
> Add a statement to the `java.io` package documentation clarifying how a
> `String` representing a _pathname string_ is interpreted in the package.
CSR created: https://bugs.openjdk.java.net/browse/JDK-8282992
-
PR:
On Wed, 16 Feb 2022 22:32:21 GMT, Brian Burkhalter wrote:
> Remove reference to `java.io.InterruptedIOException` from
> `java.io.PrintStream`, and make the specifications of `checkError()`,
> `setError()`, and `clearError()` consistent between `java.io.PrintStream` and
> `java.io
Add a statement to the `java.io` package documentation clarifying how a
`String` representing a _pathname string_ is interpreted in the package.
-
Commit messages:
- 8058924: FileReader(String) documentation is insufficient
Changes: https://git.openjdk.java.net/jdk/pull/7767/files
On Tue, 8 Feb 2022 22:11:34 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
> Remove reference to `java.io.InterruptedIOException` from
> `java.io.PrintStream`, and make the specifications of `checkError()`,
> `setError()`, and `clearError()` consistent between `java.io.PrintStream` and
> `java.io.PrintWriter`.
Brian Burkhalter has refreshed the contents
On Wed, 9 Mar 2022 17:49:11 GMT, Ian Graves wrote:
>> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
>> metacharacters
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing superfluous 'if'
On Wed, 9 Mar 2022 01:33:43 GMT, Ian Graves wrote:
>> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
>> metacharacters
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating with additional de
On Thu, 24 Feb 2022 14:47:50 GMT, Jim Laskey wrote:
> Class: ./java.base/share/classes/jdk/internal/util/random/RandomSupport.java
> Method: public static long[] convertSeedBytesToLongs(byte[] seed, int n, int
> z)
>
> The method attempts to create an array of longs by consuming the input byt
On Sun, 27 Feb 2022 22:30:44 GMT, Jim Laskey wrote:
>> test/jdk/java/util/Random/T8282144.java line 39:
>>
>>> 37: public class T8282144 {
>>> 38: public static void main(String[] args) {
>>> 39: RandomGenerator rng =
>>> RandomGeneratorFactory.of("L64X128MixRandom").create(42);
>>
On Thu, 24 Feb 2022 14:47:50 GMT, Jim Laskey wrote:
> Class: ./java.base/share/classes/jdk/internal/util/random/RandomSupport.java
> Method: public static long[] convertSeedBytesToLongs(byte[] seed, int n, int
> z)
>
> The method attempts to create an array of longs by consuming the input byt
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote:
> Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also
> been drafted.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7625
On Fri, 18 Feb 2022 19:07:15 GMT, Andrey Turbanov wrote:
> 8282188: Unused static field MathContext.DEFAULT_DIGITS
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7538
On Thu, 17 Feb 2022 18:02:20 GMT, Ian Graves wrote:
> Adding a missing period per this doc bug.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7521
On Wed, 16 Feb 2022 22:32:21 GMT, Brian Burkhalter wrote:
> Remove reference to `java.io.InterruptedIOException` from
> `java.io.PrintStream`, and make the specifications of `checkError()`,
> `setError()`, and `clearError()` consistent between `java.io.PrintStream` and
> `java.io
On Wed, 16 Feb 2022 22:32:21 GMT, Brian Burkhalter wrote:
> Remove reference to `java.io.InterruptedIOException` from
> `java.io.PrintStream`, and make the specifications of `checkError()`,
> `setError()`, and `clearError()` consistent between `java.io.PrintStream` and
> `java.io
1 - 100 of 1001 matches
Mail list logo
