RE: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

= builder.parseLenient().appendValue(HOUR_OF_DAY).appendValue(MINUTE_OF_HOUR, 2).appendLiteral('9').toFormatter(Locale.UK); Since other test cases use Locale.UK may be here also you can use UK instead of locale.US. Thanks and Regards, Nadeesh On 11/11/2016 10:57 AM, Bhanu Gopul

RE: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

/ Thanks, Bhanu From: Roger Riggs Sent: Tuesday, June 21, 2016 8:36 PM To: Bhanu Gopularam; core-libs-dev@openjdk.java.net Cc: Stephen Colebourne Subject: Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale Hi Bhanu, It can be problematic to

RE: RFR 8160036: Java API doc for method minusMonths in LocalDateTime class needs correction

minusMonths in LocalDateTime class needs correction Hi Bhanu, Same issues with OffsetDateTime minusWeeks and minusDays Thanks and Regards, Nadeesh On 11/7/2016 5:31 PM, Bhanu Gopularam wrote: > Hi all, > > Could you please review fix for following issue? > > Bug id: https://bugs.openjdk.

RFR 8160036: Java API doc for method minusMonths in LocalDateTime class needs correction

Hi all, Could you please review fix for following issue? Bug id: https://bugs.openjdk.java.net/browse/JDK-8160036 Solution: Corrected documentation for couple of methods in LocalDateTime and OffsetDateTime classes Webrev: http://cr.openjdk.java.net/~bgopularam/8160036/webrev.00 Thanks, Bhanu

RE: RFR 8159616: java.time.Instant falls through switch statement

Hi all, May I request you to review below simple fix for following issue: Bug id: https://bugs.openjdk.java.net/browse/JDK-8159616 Solution: Removed the unneeded case statement INSTANT_SECONDS from get(TemporalField field) of java.time.Instant class Webrev: http://cr.openjdk.java.net/~bgopu

RFR 8159616: java.time.Instant falls through switch statement

Hi all, May I request you to review below simple fix for following issue: Bug id: https://bugs.openjdk.java.net/browse/JDK-8159616 Solution: Removed the unneeded case statement INSTANT_SECONDS from get(TemporalField field) of java.time.Instant class Webrev: http://cr.openjdk.java.net/~bgopul

RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

Hi all, May I request you to review fix for following issue Bug id: https://bugs.openjdk.java.net/browse/JDK-8158880 Solution: To avoid test failure in non english locales, set the default locale while initial test setup Webrev: http://cr.openjdk.java.net/~bgopularam/JDK-8158880/webrev.00/ T

RE: RFR 8156718: Need tests for IsoFields getFrom for unsupported non-Iso Temporal fields

same), but that is fine for that test. Thanks, Roger On 5/19/2016 7:16 AM, Stephen Colebourne wrote: > Fine by me > Stephen > > On 19 May 2016 at 11:34, Bhanu Gopularam > wrote: >> Thank you Nadeesh and Stephen. >> >> Here is the updated webrev link: >>

RE: RFR 8156718: Need tests for IsoFields getFrom for unsupported non-Iso Temporal fields

est case comparing the return value of > getFrom() > >( Not an official reviewer) > > Regards, > Nadeesh > > On 5/16/2016 11:46 AM, Bhanu Gopularam wrote: >> >> Hi all, >> >> Could you please review fix for following issue. >> >> Bug

RFR 8156718: Need tests for IsoFields getFrom for unsupported non-Iso Temporal fields

Hi all, Could you please review fix for following issue. Bug id: https://bugs.openjdk.java.net/browse/JDK-8156718 Solution: Added tck tests for validating getFrom method for unsupported non-Iso temporal fields Webrev: http://cr.openjdk.java.net/~bgopularam/JDK-8156718/webrev.00/ Thanks, Bha

RFR 8062804: IsoFields WEEK_BASED_YEAR and QUARTER_OF_YEAR too lenient

Hi all, Please review fix following issue Bug Id : https://bugs.openjdk.java.net/browse/JDK-8062804 Solution: Added check for unsupported fields in IsoFields rangeRefinedBy methods Webrev : http://cr.openjdk.java.net/~bgopularam/bhanu/JDK-8062804/webrev.00 Thanks, Bhanu

RE: RFR 8066291: ZoneIdPrinterParser can be optimized

afety aspects, although I think it is pretty simple and safe. Stephen On 9 May 2016 at 11:58, Bhanu Gopularam wrote: > Hi all, > > Here is the updated webrev: > > http://cr.openjdk.java.net/~bgopularam/bhanu/JDK-8066291/webrev.02/ > > I have included newly suggested chang

RE: RFR 8066291: ZoneIdPrinterParser can be optimized

haredSecrets, then >>>> no matter what, we are adding "a trivial method to the public API >>>> used only for an optimization". >>>> >>>> Stephen >>>> >>>> >>>> On 5 May 2016 at 15:23, Roger Riggs wrote: >>>>> >

RE: RFR 8066291: ZoneIdPrinterParser can be optimized

: ZoneIdPrinterParser can be optimized In ZoneRulesProvider.getAvailableZoneIdsSize() there is no need for the trailing paragraph tag in the Javadoc. Otherwise, fine by me. thanks Stephen On 5 May 2016 at 10:10, Bhanu Gopularam wrote: > Hi all, > > > > Please review fix following issue > &g

RFR 8066291: ZoneIdPrinterParser can be optimized

Hi all, Please review fix following issue Bug Id : https://bugs.openjdk.java.net/browse/JDK-8066291 Solution: provided new method to get size of available zone ids webrev : http://cr.openjdk.java.net/~bgopularam/bhanu/JDK-8066291/webrev.00 Thanks, Bhanu