On Fri, 7 May 2021 08:28:43 GMT, Kim Barrett wrote:
>> Please review this change to the String Deduplication facility. It is being
>> changed to use OopStorage to hold weak references to relevant objects,
>> rather than bespoke data structures requiring dedicated processing phases by
>> supporti
On Wed, 11 Nov 2020 18:04:12 GMT, Erik Österlund wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename inactive-getter and improve javadocs
>
> Looks good.
With `getInactive`, is the null check, `if (finalizee !=
On Thu, 15 Oct 2020 03:06:45 GMT, Kim Barrett wrote:
>>> See, for example, src/java.base/share/native/libjava/ConstantPool.c.
>>
>> Got it; thank you.
>>
>>> I'm not sure what else besides an override one might wonder about?
>>
>> I don't know; maybe override is the only sensible choice. I jus
On Wed, 14 Oct 2020 14:19:59 GMT, Kim Barrett wrote:
> See, for example, src/java.base/share/native/libjava/ConstantPool.c.
Got it; thank you.
> I'm not sure what else besides an override one might wonder about?
I don't know; maybe override is the only sensible choice. I just believe saying
i
On Wed, 14 Oct 2020 04:27:34 GMT, Kim Barrett wrote:
>> Finally returning to this review that was started in April 2020. I've
>> recast it as a github PR. I think the security concern raised by Gil
>> has been adequately answered.
>> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-A
