On Wed, 1 Jun 2022 06:26:23 GMT, David Holmes wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 11 commits:
>>
>> - Fixed another typo in comment
>> - Merge
>> - Fix typos in comments
>> - Allowing linking
On Wed, 1 Jun 2022 13:52:46 GMT, Adam Sotona wrote:
> LauncherCommon.gmk is unfortunately defining JAVA_ARGS with `-J-ms8m` option
> for all JDK launchers, including java launcher.
> JAVA_ARGS should not be defined for java launcher (in contrast to the other
> JDK launchers), and the command l
On Wed, 1 Jun 2022 19:08:03 GMT, Xue-Lei Andrew Fan wrote:
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impac
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request increme
On Wed, 1 Jun 2022 21:07:16 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the closed
>> test cases are i
- Added support for signing predefined application image.
- Following command can be used to sign predefined application images:
jpackage --type app-image --app-image Test.app --mac-sign [additional signing
options]
- Main class and if --mac-app-store was specified will be saved in
.jpackage.x
> Currently the vector load with mask when the given index happens out of the
> array boundary is implemented with pure java scalar code to avoid the IOOBE
> (IndexOutOfBoundaryException). This is necessary for architectures that do
> not support the predicate feature. Because the masked load is
On Thu, 2 Jun 2022 01:49:10 GMT, Xiaohong Gong wrote:
> > @XiaohongGong Could you please rebase the branch and resolve conflicts?
>
> Sure, I'm working on this now. The patch will be updated soon. Thanks.
Resolved the conflicts. Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/
On Wed, 1 Jun 2022 22:53:14 GMT, Chris Hennick wrote:
>> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a
>> rounding error to accumulate at the tail of the distribution (probably
>> starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes
>> that by tra
On Fri, 13 May 2022 08:58:12 GMT, Xiaohong Gong wrote:
>> Yes, the tests were run in debug mode. The reporting of the missing constant
>> occurs for the compiled method that is called from the method where the
>> constants are declared e.g.:
>>
>> 719 240bjdk.incubator.vector.
On Tue, 31 May 2022 16:48:27 GMT, Paul Sandoz wrote:
>> @PaulSandoz, could you please help to check whether the current version is
>> ok for you? Thanks so much!
>
> @XiaohongGong looks good, now the Vector API JEP has been integrated you will
> get a merge conflict, but it should be easier to
> Checking whether the indexes of masked lanes are inside of the valid memory
> boundary is necessary for masked vector memory access. However, this could be
> saved if the given offset is inside of the vector range that could make sure
> no IOOBE (IndexOutOfBoundaryException) happens. The maske
On Wed, 1 Jun 2022 22:49:01 GMT, Chris Hennick wrote:
>> @Pr0methean As @turbanoff observes, I think there's a closing parentheses
>> too much on L.1411 and one on L.1421.
>> Which compiler are you using ;-) ?
>
> Should be fixed as of fa340fb47b1169805f21fb71cce0da3fc175d427. I haven't yet
>
> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a
> rounding error to accumulate at the tail of the distribution (probably
> starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes
> that by tracking the multiple of exponentialX0 as a long. (This changes
On Mon, 23 May 2022 14:21:55 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line
>> 1411:
>>
>>> 1409: long U2 = (rng.nextLong() >>> 1);
>>> 1410: // Compute the actual x-coordinate of the randomly
>>>
On Fri, 13 May 2022 08:58:12 GMT, Xiaohong Gong wrote:
>> Yes, the tests were run in debug mode. The reporting of the missing constant
>> occurs for the compiled method that is called from the method where the
>> constants are declared e.g.:
>>
>> 719 240bjdk.incubator.vector.
On Thu, 8 Apr 2021 21:12:21 GMT, Raffaello Giulietti
wrote:
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi
On Wed, 1 Jun 2022 10:37:23 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Fri, 27 May 2022 22:09:22 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Fri, 27 May 2022 22:09:22 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Tue, 31 May 2022 23:15:26 GMT, Mandy Chung wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor stylistic cleanup
>
> src/java.base/share/classes/java/lang/invoke/LambdaForm.java line 204:
>
>> 202:
On Wed, 1 Jun 2022 13:31:27 GMT, Claes Redestad wrote:
>> When generating `MethodHandle`-based concatenation expressions in
>> `StringConcatFactory` we can reduce the number of classes generated at
>> runtime by creating small batches of prependers and mixers before binding
>> them into the ro
> When generating `MethodHandle`-based concatenation expressions in
> `StringConcatFactory` we can reduce the number of classes generated at
> runtime by creating small batches of prependers and mixers before binding
> them into the root expression tree.
>
> Improvements on one-off tests are m
On Wed, 1 Jun 2022 21:07:16 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the closed
>> test cases are i
On Wed, 1 Jun 2022 20:51:50 GMT, Mandy Chung wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments from @ExE-Boss
>
> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line
On Wed, 1 Jun 2022 20:45:07 GMT, Mandy Chung wrote:
> JDK-8287384 causes
> `test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java` to timeout
> when running with fastdebug VM. I think this might be caused by more frequent
> GCs.
>
> I tried your patch and the test fails.
I updated t
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request increme
On Mon, 30 May 2022 20:23:40 GMT, Claes Redestad wrote:
>> When generating `MethodHandle`-based concatenation expressions in
>> `StringConcatFactory` we can reduce the number of classes generated at
>> runtime by creating small batches of prependers and mixers before binding
>> them into the r
On Wed, 1 Jun 2022 13:31:27 GMT, Claes Redestad wrote:
>> When generating `MethodHandle`-based concatenation expressions in
>> `StringConcatFactory` we can reduce the number of classes generated at
>> runtime by creating small batches of prependers and mixers before binding
>> them into the ro
On Wed, 1 Jun 2022 19:08:03 GMT, Xue-Lei Andrew Fan wrote:
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impac
Hashtable doesn't allow `null` values. So, instead of pair
`containsKey`/`remove` calls, we can directly call `remove` and then compare
result with `null`.
https://github.com/openjdk/jdk/blob/2c461acfebd28fe5ef62805cbb004f91a3b18f08/src/java.base/share/classes/java/util/jar/JarVerifier.java#L433-
On Wed, 1 Jun 2022 13:52:46 GMT, Adam Sotona wrote:
> LauncherCommon.gmk is unfortunately defining JAVA_ARGS with `-J-ms8m` option
> for all JDK launchers, including java launcher.
> JAVA_ARGS should not be defined for java launcher (in contrast to the other
> JDK launchers), and the command l
On Wed, 1 Jun 2022 19:27:33 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>> it
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of c to make it
> easier to create helper objects that reduce the redundant
This is a follow up update per comments in [JDK-8287384
PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
open part looks good to me. Please help to run Mach5 just case the closed test
cases are impacted.
-
Commit messages:
- Remove trailing white space
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
`java.io` and `java.nio` look all right.
-
Marked as reviewed by bpb (Reviewer
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Reviewed i18n-related changes and they look good. One minor suggestion in
`Calendar`, but t
On Wed, 1 Jun 2022 13:32:36 GMT, Gaurav Chaudhari wrote:
>> This fix ensures that when a lookup for a custom TZ code fails, and an
>> attempt is made to find the GMT offset in order to get the current time,
>> Daylight savings rules are applied correctly.
>
> Gaurav Chaudhari has updated the pu
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Reviewers for i18n, net, nio, and security, please review call site changes in
your areas.
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
test/jdk/java/util/HashMap/WhiteBoxResizeTest.java line 441:
> 439: }
> 440: }
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of c to make it
> easier to create helper objects that reduce the redundant
On Wed, 1 Jun 2022 10:37:23 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Wed, 1 Jun 2022 03:01:35 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>> it
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
'the new' fix should be applied to newHashMap etc. too.
-
PR: https://git.open
On Fri, 27 May 2022 06:09:59 GMT, XenoAmess wrote:
>> Thanks for the updates. I've made a couple minor changes to the specs;
>> please merge the latest commit from this branch:
>>
>> https://github.com/stuart-marks/jdk/tree/pull/8302
>>
>> I've created a CSR and have included these changes in
On Wed, 1 Jun 2022 04:10:03 GMT, ExE Boss wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unnecessary clone() call
>
> src/java.base/share/classes/sun/util/cldr/CLDRLocaleProviderAdapter.java line
> 181:
>
> Refactoring some old code in locale providers. The test case data have also
> been modified due to:
> - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
> handle the case for `no-NO-NY`.
> - `Locale.toLanguageTag()` won't handle legacy Java locales, e.g., `ja_JP_JP`
>
On Wed, 1 Jun 2022 15:41:57 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
Marked as revi
Test change to silently pass if the test environment encounters a
NoRouteToHostException. These are intermittent at the moment but I will attempt
to find an alternative to the use of example.com in some follow up work.
-
Commit messages:
- 8281695: jtreg test com/sun/jndi/ldap/Ldap
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
This pull req
> On Jun 1, 2022, at 3:32 AM, Raffaello Giulietti wrote:
>
> On Tue, 31 May 2022 22:11:54 GMT, Brian Burkhalter wrote:
>
>>> Raffaello Giulietti has updated the pull request incrementally with one
>>> additional commit since the last revision:
>>>
>>> 4511638: Double.toString(double) some
On Jun 1, 2022, at 2:25 AM, Raffaello Giulietti
mailto:d...@openjdk.java.net>> wrote:
On Tue, 31 May 2022 21:57:44 GMT, Brian Burkhalter
mailto:b...@openjdk.org>> wrote:
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
4511
On Tue, 31 May 2022 22:34:11 GMT, Naoto Sato wrote:
>> Gaurav Chaudhari has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285838: Corrected month comparison check for TZ DST
>
> I tried out your patch on my local Linux machine, but the ne
On Mon, 7 Mar 2022 15:11:50 GMT, Сергей Цыпанов wrote:
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()` wit
On Wed, 1 Jun 2022 07:50:58 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of `Arrays.asList()
> This fix ensures that when a lookup for a custom TZ code fails, and an
> attempt is made to find the GMT offset in order to get the current time,
> Daylight savings rules are applied correctly.
Gaurav Chaudhari has updated the pull request incrementally with two additional
commits since the l
> When generating `MethodHandle`-based concatenation expressions in
> `StringConcatFactory` we can reduce the number of classes generated at
> runtime by creating small batches of prependers and mixers before binding
> them into the root expression tree.
>
> Improvements on one-off tests are m
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
test/jdk/com/
On Wed, 1 Jun 2022 13:03:38 GMT, Claes Redestad wrote:
>> When generating `MethodHandle`-based concatenation expressions in
>> `StringConcatFactory` we can reduce the number of classes generated at
>> runtime by creating small batches of prependers and mixers before binding
>> them into the ro
> When generating `MethodHandle`-based concatenation expressions in
> `StringConcatFactory` we can reduce the number of classes generated at
> runtime by creating small batches of prependers and mixers before binding
> them into the root expression tree.
>
> Improvements on one-off tests are m
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
The change lo
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has changed,
On Tue, 31 May 2022 22:11:54 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
> src/java.base/share/classes/jdk/in
On Tue, 31 May 2022 21:55:16 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
> src/java.base/share/classes/jdk/in
On Wed, 1 Jun 2022 09:21:43 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java line 118:
>>
>>> 116: private int index;
>>> 117:
>>> 118: private DoubleToDecimal() {
>>
>> Maybe add a comment like
>>
>> /**
>> * Prevent inst
On Fri, 6 May 2022 22:05:35 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Objec
Please review this cleanup change in the cgroup subsystem which used to use
hard-coded stack allocated
buffers for concatenating strings in memory. We can use `stringStream` instead
which doesn't have the issue
of hard-coding maximum lengths (and related checks) and makes the code, thus,
easier
On Tue, 31 May 2022 21:57:44 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
> src/java.base/share/classes/jdk/in
On Tue, 31 May 2022 21:35:08 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
> src/java.base/share/classes/jdk/in
On Wed, 1 Jun 2022 08:56:38 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/math/MathUtils.java line 38:
>>
>>> 36: *
>>> 37: * Giulietti, "The Schubfach way to render doubles",
>>> 38: *
>>> https://drive.google.com/file/d/1gp5xv4CAa78SVgCeWf
On Wed, 1 Jun 2022 02:05:40 GMT, Joe Darcy wrote:
>> Generally add apiNote's to map from Java library methods to particular IEEE
>> 754 operations. For now, I only added such notes to java.lang.Math and not
>> java.lang.StrictMath.
>
> Joe Darcy has updated the pull request with a new target ba
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()` with `List.of()` is dubious as
> the latter is null-hostile
72 matches
Mail list logo
