On Sat, 19 Mar 2022 22:30:13 GMT, Joe Darcy wrote:
> Another refactoring to use sealed classes where possible, this time in the
> java.lang.ref package.
>
> Copyright dates will be updated, if needed, before a push.
Looks good.
-
Marked as reviewed by kbarrett (Reviewer).
PR: ht
Can I please get a review of this change which handles
https://bugs.openjdk.java.net/browse/JDK-8283411?
The commit here moves the temporary byte array from being a member of the class
to a local variable within the `skip` method which is the only place where it
is used as a temporary buffer.
Hello,
With a number of efforts to update various class hierarchies in the JDK
to sealed classes, I wrote an annotation processor to find candidates to
be changed to sealed. The candidates for this analysis are non-final
public classes with at least one package access constructor and no
publi
Another refactoring to use sealed classes where possible, this time in the
java.lang.ref package.
Copyright dates will be updated, if needed, before a push.
-
Commit messages:
- JDK-8283415: Update java.lang.ref to use sealed classes
Changes: https://git.openjdk.java.net/jdk/pull/
On Mon, 21 Feb 2022 23:36:19 GMT, liach wrote:
>> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute`
>> `merge` would throw CME if the functions modified the map itself, and there
>> are corresponding specification changes.
>
> liach has updated the pull request incrementall
On Fri, 18 Mar 2022 22:12:10 GMT, liach wrote:
>> Change `CallSite` to a sealed class, as `CallSite` is an abstract class
>> which does not allow direct subclassing by users per its documentation.
>> Since I don't have a JBS account, I posted the content for the CSR in a
>> GitHub Gist at http
On Mon, 21 Feb 2022 23:36:19 GMT, liach wrote:
>> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute`
>> `merge` would throw CME if the functions modified the map itself, and there
>> are corresponding specification changes.
>
> liach has updated the pull request incrementall
On Sat, 19 Mar 2022 00:45:14 GMT, Stuart Marks wrote:
>> @stuart-marks Could you help me with this?
>>
>> In my JMH benchmark runs, I often find that ambient differences (from the
>> jdk processes, the random test data generated, etc.) hide the actual
>> performance difference caused by the pa
On Fri, 18 Mar 2022 22:12:10 GMT, liach wrote:
>> Change `CallSite` to a sealed class, as `CallSite` is an abstract class
>> which does not allow direct subclassing by users per its documentation.
>> Since I don't have a JBS account, I posted the content for the CSR in a
>> GitHub Gist at http
On Sat, 19 Mar 2022 00:45:14 GMT, Stuart Marks wrote:
>> @stuart-marks Could you help me with this?
>>
>> In my JMH benchmark runs, I often find that ambient differences (from the
>> jdk processes, the random test data generated, etc.) hide the actual
>> performance difference caused by the pa
Hello.
During my review of the JDK codebase, I found that launcher's 'main.c'
still has code, which included only with Visual Studio 2005 and 2008.
https://github.com/openjdk/jdk/blob/3f923b82c31325504430b50dee262fd460004e7b/src/java.base/share/native/launcher/main.c#L38
#if _MSC_VER > 1400 && _M
Hello.
I found a suspicious method java.lang.VersionProps#print with unused
parameter 'boolean newln'.
This class is generated from template -
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/VersionProps.java.template#L203
It's unused since integration of 'JDK-81690
On Wed, 16 Mar 2022 21:25:37 GMT, Tyler Steele wrote:
> As mentioned in the issue, I'd like to perform the following tidying on
> ClassLoader.c
>
> - Alphabetize includes.
> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
> - Replace 'return 0' with 'return NULL'.
This pull request has now
13 matches
Mail list logo
