Re: JDK-17: Wndows jpackage destination directory not writable

2022-03-06 Thread Sverre Moe
If anyone wants to try to reproduce this, here is the Dockerfile I used to create the Windows docker image # escape=` FROM mcr.microsoft.com/windows:1903 AS jdk17 # $ProgressPreference: https://github.com/PowerShell/PowerShell/issues/2138#issuecomment-251261324 SHELL [ "powershell", "-Command",

Wrong behavior of standard IO library when interacting with Samba (very serious)

2022-03-06 Thread Glavo
I am a Java application developer. I noticed that when my program runs on Windows in a samba shared folder (mounted as a drive, or accessed via a UNC path), the Java standard IO library has some unusual behavior. Note that these issues only occur when accessing a folder shared by *Samba*, but not f

Re: RFR: JDK-8282696: Add constructors take a cause to InvalidObjectException and InvalidClassException [v5]

2022-03-06 Thread Joe Darcy
> Occasionally in core-libs we've discussed whether or not to do a pass over > the exception classes and proactively add any of four missing convention > constructors per java.lang.Throwable (no-arg, string, cause, cause and > string). Last time this came up, we decided a wide-scale effort wasn'

Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v3]

2022-03-06 Thread Roger Riggs
On Mon, 7 Mar 2022 01:27:39 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/time/chrono/Chronology.java line 794: >> >>> 792: * @since 19 >>> 793: */ >>> 794: default boolean supportsIsoFields() { >> >> I'm not a fan of this name, as it is inconsistent with the rest of

Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v3]

2022-03-06 Thread Naoto Sato
On Sun, 6 Mar 2022 17:12:31 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addresses review comments > > src/java.base/share/classes/java/time/chrono/Chronology.java line 794: > >> 792:

Re: RFR: 8282432: Optimize masked "test" Vector API with predicate feature [v2]

2022-03-06 Thread Xiaohong Gong
On Thu, 3 Mar 2022 17:40:13 GMT, Paul Sandoz wrote: > I guess the following: `mask.cast(IntVector.species(shape())` is more > efficient than: `m.cast(vspecies().asIntegral()))` ? Yeah, that's one point. Another main reason is `m.cast(vspecies().asIntegral()))` cannot be handled well in the su

Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v25]

2022-03-06 Thread XenoAmess
On Fri, 4 Mar 2022 21:02:50 GMT, Stuart Marks wrote: >>> This actually tests three things: 1) table is lazily allocated, 2) default >>> capacity is 16, and 3) using putAll to populate the map with 64 elements >>> results in a table size of 128. This should really be broken into three >>> separ

Re: RFR: JDK-8282625 Formatter caches Locale/DecimalFormatSymbols poorly [v3]

2022-03-06 Thread Naoto Sato
On Sun, 6 Mar 2022 15:00:47 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/util/Formatter.java line 2012: >> >>> 2010: public final class Formatter implements Closeable, Flushable { >>> 2011: // Caching DecimalFormatSymbols >>> 2012: static DecimalFormatSymbols DFS = null;

Re: RFR: JDK-8282696: Add constructors take a cause to InvalidObjectException and InvalidClassException [v4]

2022-03-06 Thread Lance Andersen
On Sun, 6 Mar 2022 17:28:42 GMT, Joe Darcy wrote: >> Occasionally in core-libs we've discussed whether or not to do a pass over >> the exception classes and proactively add any of four missing convention >> constructors per java.lang.Throwable (no-arg, string, cause, cause and >> string). Last

Re: RFR: JDK-8282696: Add constructors take a cause to InvalidObjectException and InvalidClassException [v3]

2022-03-06 Thread Andrey Turbanov
On Sun, 6 Mar 2022 17:24:23 GMT, Joe Darcy wrote: >> src/java.base/share/classes/java/io/InvalidObjectException.java line 62: >> >>> 60: * @since 19 >>> 61: */ >>> 62: public InvalidObjectException(String reason, Throwable cause) { >> >> strange double space after `public` > > Fi

Re: RFR: JDK-8282696: Add constructors take a cause to InvalidObjectException and InvalidClassException [v3]

2022-03-06 Thread Joe Darcy
On Sat, 5 Mar 2022 17:36:20 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > src/java.base/share/classes/java/io/InvalidObjectException.java line 62: > >> 60:

Re: RFR: JDK-8282696: Add constructors take a cause to InvalidObjectException and InvalidClassException [v4]

2022-03-06 Thread Joe Darcy
> Occasionally in core-libs we've discussed whether or not to do a pass over > the exception classes and proactively add any of four missing convention > constructors per java.lang.Throwable (no-arg, string, cause, cause and > string). Last time this came up, we decided a wide-scale effort wasn'

Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v3]

2022-03-06 Thread Stephen Colebourne
On Fri, 4 Mar 2022 23:05:56 GMT, Naoto Sato wrote: >> Supporting `IsoFields` temporal fields in chronologies that are similar to >> ISO chronology. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revi

Re: New methods in PriorityQueue

2022-03-06 Thread Julian Waters
Hi Stuart and Roger, thanks for your patience, Attached below is the response from the author: @TheShermanTanker Cool. Thank you very much for relaying the messages from the list here! All right, I understand the concerns. My first thought about how to address them would be a functional API. Som

Re: RFR: JDK-8282625 Formatter caches Locale/DecimalFormatSymbols poorly [v3]

2022-03-06 Thread Jaikiran Pai
On Sat, 5 Mar 2022 14:20:40 GMT, Jaikiran Pai wrote: > will now try and update/use this cached class level static state DFS. That > would thus require some kind of thread safety semantics to be implemented for > this new getDecimalFormatSymbols(Locale) method, isn't it? A bit more closer look

Re: RFR: 8279508: Auto-vectorize Math.round API [v11]

2022-03-06 Thread Andrew Haley
On Wed, 2 Mar 2022 02:44:41 GMT, Jatin Bhateja wrote: >> Summary of changes: >> - Intrinsify Math.round(float) and Math.round(double) APIs. >> - Extend auto-vectorizer to infer vector operations on encountering scalar >> IR nodes for above intrinsics. >> - Test creation using new IR testing fram

Re: RFR: JDK-8282696: Add constructors take a cause to InvalidObjectException and InvalidClassException [v3]

2022-03-06 Thread Andrey Turbanov
On Sat, 5 Mar 2022 03:29:44 GMT, Joe Darcy wrote: >> Occasionally in core-libs we've discussed whether or not to do a pass over >> the exception classes and proactively add any of four missing convention >> constructors per java.lang.Throwable (no-arg, string, cause, cause and >> string). Last

Re: RFR: 8279508: Auto-vectorize Math.round API [v11]

2022-03-06 Thread Jatin Bhateja
On Sun, 6 Mar 2022 09:31:27 GMT, Andrew Haley wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8279508: Removing +LogCompilation flag. > > src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4157: > >> 4155: Exte

Re: RFR: 8279508: Auto-vectorize Math.round API [v11]

2022-03-06 Thread Andrew Haley
On Wed, 2 Mar 2022 02:44:41 GMT, Jatin Bhateja wrote: >> Summary of changes: >> - Intrinsify Math.round(float) and Math.round(double) APIs. >> - Extend auto-vectorizer to infer vector operations on encountering scalar >> IR nodes for above intrinsics. >> - Test creation using new IR testing fram