On Thu, 24 Feb 2022 18:51:08 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add null check
>
> The piece I was missing is that the HotSpot AIX specific code, computes and
> sets LIBPATH base
On Thu, 24 Feb 2022 18:51:08 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add null check
>
> The piece I was missing is that the HotSpot AIX specific code, computes and
> sets LIBPATH base
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH mic
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was ap
On Fri, 25 Feb 2022 03:51:09 GMT, Jaikiran Pai wrote:
>> test/jdk/java/util/Properties/PropertiesStoreTest.java line 112:
>>
>>> 110: locales.add(Locale.getDefault()); // always test the default
>>> locale
>>> 111: locales.add(Locale.US); // guaranteed to be present
>>> 112:
On Fri, 25 Feb 2022 03:54:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which fixes the issue
>> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>>
>> As noted in that JBS issue these tests fail when the default locale under
>> which those tests a
On Thu, 24 Feb 2022 17:15:16 GMT, Naoto Sato wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - use Roger's suggestion of using Stream and Collection based APIs to avoid
>> code duplication in the data provider me
> Can I please get a review of this test only change which fixes the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>
> As noted in that JBS issue these tests fail when the default locale under
> which those tests are run isn't `en_US`. Both these tests were introduced as
>
On Fri, 25 Feb 2022 00:50:49 GMT, Ravi Reddy wrote:
> While normalizing entity with '\r' , we should be checking if the entity is
> external before changing the position and offset.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/p
> While normalizing entity with '\r' , we should be checking if the entity is
> external before changing the position and offset.
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
Updated @LastModified to Feb 2022
-
Changes:
On Fri, 25 Feb 2022 00:50:49 GMT, Ravi Reddy wrote:
> While normalizing entity with '\r' , we should be checking if the entity is
> external before changing the position and offset.
> Please also update the @lastmodified to "Feb 2022"
Thanks , I have updated the tag.
-
PR: https:/
On Fri, 25 Feb 2022 00:50:49 GMT, Ravi Reddy wrote:
> While normalizing entity with '\r' , we should be checking if the entity is
> external before changing the position and offset.
Please also update the @LastModified to "Feb 2022"
-
Marked as reviewed by joehw (Reviewer).
PR: ht
On Thu, 17 Feb 2022 17:53:57 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8279995: jpackage --add-launcher option should allow overriding
>> description [v4]
>
> test/jdk/tools/jpackag
> Added ability to override description for additional launchers via
> "description" property.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8279995: jpackage --add-launcher option should allow overriding description
[v5]
--
On Wed, 23 Feb 2022 13:14:07 GMT, Jim Laskey wrote:
>> Yasser Bazzi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> check from master branch
>
> src/java.base/share/classes/java/util/Random.java line 259:
>
>> 257:
>> 258: private
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method `asRandom()` that wraps around the
> newer algorithms
While normalizing entity with '\r' , we should be checking if the entity is
external before changing the position and offset.
-
Commit messages:
- 8281093: JDK 11.0.14 violates Attribute-Value Normalization in the XML
specification 1.0
Changes: https://git.openjdk.java.net/jdk/pull
Hi,
on Windows, the mechanism to launch a new program is for the parent to
call CreateProcess(). This function accepts, among others parameters, a
lpApplicationName string and a lpCommandLine string. There's a *single*
lpCommandLine that encodes all the arguments to pass to the new program.
Hi,
as far as I know, on Windows every program can obtain the lpCommandLine
argument, used in the call of CreateProcess() from its parent, by
calling GetCommandLine() and parse that string as it sees fit. This is
in stark contrast with how Unix-like systems create and execute
programs, where
On Fri, 18 Feb 2022 15:29:34 GMT, Roger Riggs wrote:
> In some Linux configurations, the Linux home directory provided by getpwent
> is not usable.
> The value of the system property `user.home` should fallback to the value of
> $HOME
> if getpwent.user_home is null or less that 2 characters l
On Thu, 17 Feb 2022 15:11:11 GMT, Claes Redestad wrote:
> Splitting out these micro changes from #7231
>
> - Clean up and simplify setup and code
> - Add variants with different inputs with varying lengths and encoding
> weights, but also relevant mixes of each so that we both cover interesting
On Wed, 23 Feb 2022 22:00:19 GMT, Roger Riggs wrote:
>> In some Linux configurations, the Linux home directory provided by getpwent
>> is not usable.
>> The value of the system property `user.home` should fallback to the value of
>> $HOME
>> if getpwent.user_home is null or less that 2 charact
On Fri, 18 Feb 2022 17:21:48 GMT, Olga Mikhaltsova
wrote:
>> This fix made equal processing of strings such as ""C:\\Program
>> Files\\Git\\"" before and after JDK-8250568.
>>
>> For example, it's needed to execute the following command on Windows:
>> `C:\Windows\SysWOW64\WScript.exe "MyVB.vbs
On Thu, 24 Feb 2022 14:13:47 GMT, Jatin Bhateja wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix 32bit build issues
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4408:
>
>> 4406: jmp(done);
>> 4407:
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was ap
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote:
> Please review this PR that enables
> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170)
> compiler flag, which makes assigning a string literal
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote:
>> Please review this PR that enables
>> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170)
>> compiler flag, which makes assigning a string liter
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote:
>> Please review this PR that enables
>> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170)
>> compiler flag, which makes assigning a string liter
This is not an issue and does not affect the runtiime. When it fails to
load a native library, the VM will throw UnsatisfiedLinkError (see
JVM_LoadLibrary). The return value is only important for the JNI case
and calling System::loadLibrary on the system with dynamic linker cache
(Big Sur) s
On Thu, 24 Feb 2022 17:01:13 GMT, Roger Riggs wrote:
> Javac is compiling the source to a .class file. The contents of the
> `java.library.path` do not affect the class file generated. None of the code
> of the class is executed during compilation.
Yup. Not the best snippet to include. It is s
On Thu, 24 Feb 2022 05:02:47 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which fixes the issue
>> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>>
>> As noted in that JBS issue these tests fail when the default locale under
>> which those tests a
On Thu, 24 Feb 2022 17:01:13 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add null check
>
> Javac is compiling the source to a .class file. The contents of the
> `java.library.path` do no
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was ap
On Thu, 24 Feb 2022 07:16:42 GMT, Thomas Stuefe wrote:
> If its the former, then the issue is that `libpath` is just outdated when we
> get around to use it? In that case, why not just re-aquiring LIBPATH when
> building up `expected`?
^This was my thought at first as well :-) but in my invest
On Thu, 24 Feb 2022 00:43:27 GMT, Sandhya Viswanathan
wrote:
> Also curious, how does the performance look with all these changes.
Updated new perf numbers.
-
PR: https://git.openjdk.java.net/jdk/pull/7094
Class: ./java.base/share/classes/jdk/internal/util/random/RandomSupport.java
Method: public static long[] convertSeedBytesToLongs(byte[] seed, int n, int z)
The method attempts to create an array of longs by consuming the input bytes
most significant bit first. New bytes are appended to the exi
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was ap
On Thu, 24 Feb 2022 02:43:46 GMT, Vamsi Parasa wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>> Long. This ch
On Thu, 17 Feb 2022 15:11:11 GMT, Claes Redestad wrote:
> Splitting out these micro changes from #7231
>
> - Clean up and simplify setup and code
> - Add variants with different inputs with varying lengths and encoding
> weights, but also relevant mixes of each so that we both cover interesting
On Thu, 24 Feb 2022 01:43:27 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8279508: Review comments resolved.
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 8984:
>
>> 8982: }
>>
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH mic
On Fri, 18 Feb 2022 19:07:15 GMT, Andrey Turbanov wrote:
> 8282188: Unused static field MathContext.DEFAULT_DIGITS
This pull request has now been integrated.
Changeset: 3cfffa4f
Author:Andrey Turbanov
URL:
https://git.openjdk.java.net/jdk/commit/3cfffa4f8e5a0fff7f232130125c549f992b5
42 matches
Mail list logo
