Following the prior discussion [1], here is the PR for the subject enhancement.
CSR has also been updated according to the suggestion.
[1]
https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html
-
Commit messages:
- Removed trailing space
- Merge branch 'ma
On Sat, 29 Jan 2022 16:13:46 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
On Sat, 29 Jan 2022 16:13:46 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
On Thu, 3 Feb 2022 19:42:25 GMT, Christian Stein wrote:
> Thanks for the review, Lance.
>
> I didn't change order of creation, validation, and movement of the temporary
> JAR file in order to keep existing behaviour consistent.
I do think we are better served with the validation check earlier
On Sat, 29 Jan 2022 16:13:46 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
On Sat, 29 Jan 2022 16:13:46 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
On Wed, 2 Feb 2022 20:21:54 GMT, Christian Stein wrote:
> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
> parent directories (here `a/b`) on the default file system before storing the
> JAR file (here `foo.jar`) in the destination directory.
Thanks for the review,
On Wed, 2 Feb 2022 20:21:54 GMT, Christian Stein wrote:
> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
> parent directories (here `a/b`) on the default file system before storing the
> JAR file (here `foo.jar`) in the destination directory.
Thank you for taking t
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from GetModuleHandle("zip.dll"),
Add the `-providerPath` option to jarsigner to be consistent with keytool.
-
Commit messages:
- 8281175: Add a -providerPath option to jarsigner
Changes: https://git.openjdk.java.net/jdk/pull/7338/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7338&range=00
Issue: ht
Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing
parent directories (here `a/b`) on the default file system before storing the
JAR file (here `foo.jar`) in the destination directory.
-
Commit messages:
- Expect at least jar file's name in error message
-
On 03/02/22 7:07 pm, Alan Bateman wrote:
I think it would be useful to hear from Jon Gibbons or someone else
working on javac first. It would be a bit unusual to run the compiler
with a security manager and I thought it was deliberate to not grant
permissions to jdk.compiler in the default
I think it would be useful to hear from Jon Gibbons or someone else
working on javac first. It would be a bit unusual to run the compiler
with a security manager and I thought it was deliberate to not grant
permissions to jdk.compiler in the default policy. Also the source code
launcher is a
Thank you Sean for the confirmation. I just filed
https://bugs.openjdk.java.net/browse/JDK-8281217 to track this.
-Jaikiran
On 03/02/22 6:55 pm, Sean Mullan wrote:
I only took a quick look, but it looks like a bug. The jdk.compiler
module needs to be granted that permission in the default.poli
I only took a quick look, but it looks like a bug. The jdk.compiler
module needs to be granted that permission in the default.policy file.
Please file a bug, or if you like I can file one on your behalf.
Thanks,
Sean
On 2/3/22 8:01 AM, Jaikiran Pai wrote:
I'm unsure if core-libs is the right
I'm unsure if core-libs is the right place for this or compiler-dev,
sending this to core-libs for now.
Please consider this trivial Java source file:
public class HelloWorld {
public static void main(final String[] args) throws Exception {
System.out.println("Hello World");
}
}
On 2/2/22 17:48, Alan Bateman wrote:> At a high level it should be okay to
provide a JDK-internal way to await quiescent. You've added it as a public API
which might be okay for the current exploration but I don't think it would be
exposed in its current form. Once the method returns then th
17 matches
Mail list logo
