Re: RFR: 8266974: duplicate property key in java.sql.rowset resource bundle

2022-01-31 Thread Masanori Yano
On Tue, 25 Jan 2022 11:25:55 GMT, Lance Andersen wrote: >> I have removed the duplicate property keys. >> Could you please review the fix? > > Marked as reviewed by lancea (Reviewer). @LanceAndersen Could you please commit this fix as a sponsor? - PR: https://git.openjdk.java.net/j

Integrated: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos

2022-01-31 Thread Michael McMahon
On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote: > Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v13]

2022-01-31 Thread Joe Darcy
On Fri, 28 Jan 2022 16:58:55 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively inclu

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2022-01-31 Thread Jaikiran Pai
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However, the

Integrated: JDK-8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix

2022-01-31 Thread Joe Darcy
On Mon, 31 Jan 2022 22:31:03 GMT, Joe Darcy wrote: > The original fix to JDK-8280550 contained a typo where r rather than bound > was used as the first argument to nextAfter; this PR corrects that issue. This pull request has now been integrated. Changeset: 0e70d450 Author:Joe Darcy URL:

Re: RFR: JDK-8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix [v2]

2022-01-31 Thread Joe Darcy
> The original fix to JDK-8280550 contained a typo where r rather than bound > was used as the first argument to nextAfter; this PR corrects that issue. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes

Withdrawn: 8003417: WeakHashMap$HashIterator removes wrong entry

2022-01-31 Thread duke
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However, the

Integrated: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-31 Thread Mandy Chung
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification, wh

Integrated: JDK-8280534: Enable compile-time doclint reference checking

2022-01-31 Thread Joe Darcy
On Wed, 26 Jan 2022 20:05:07 GMT, Joe Darcy wrote: > The changes in this PR on top of the out-for-review changes in > https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint > checking to be enabled in all JDK modules. > > Typically, a @SuppressWarnings("doclint:refernce") annota

Re: RFR: JDK-8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix

2022-01-31 Thread Jim Laskey
On Mon, 31 Jan 2022 22:31:03 GMT, Joe Darcy wrote: > The original fix to JDK-8280550 contained a typo where r rather than bound > was used as the first argument to nextAfter; this PR corrects that issue. LGTM - Marked as reviewed by jlaskey (Reviewer). PR: https://git.openjdk.jav

Re: RFR: JDK-8280534: Enable compile-time doclint reference checking [v3]

2022-01-31 Thread Joe Darcy
> The changes in this PR on top of the out-for-review changes in > https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint > checking to be enabled in all JDK modules. > > Typically, a @SuppressWarnings("doclint:refernce") annotation is added to > declaration with javadoc blocks t

Re: RFR: JDK-8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix

2022-01-31 Thread Brian Burkhalter
On Mon, 31 Jan 2022 22:31:03 GMT, Joe Darcy wrote: > The original fix to JDK-8280550 contained a typo where r rather than bound > was used as the first argument to nextAfter; this PR corrects that issue. Looks all right modulo the copyright year. test/jdk/java/util/Random/RandomNextDoubleBound

RFR: JDK-8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix

2022-01-31 Thread Joe Darcy
The original fix to JDK-8280550 contained a typo where r rather than bound was used as the first argument to nextAfter; this PR corrects that issue. - Commit messages: - JDK-8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix Changes: https:

Re: RFR: 8280642: IllegalAccessError thrown by ObjectInputStream.resolveProxyClass is not handled [v2]

2022-01-31 Thread Naoto Sato
On Mon, 31 Jan 2022 20:01:39 GMT, Roger Riggs wrote: >> During deserialization of a serialized data stream that contains a proxy >> descriptor with non-public interfaces >> `java.io.ObjectInputStream` checks that the interfaces can be loaded from a >> single classloader in `ObjectInputStream.re

Re: RFR: 8280642: IllegalAccessError thrown by ObjectInputStream.resolveProxyClass is not handled [v2]

2022-01-31 Thread Mandy Chung
On Mon, 31 Jan 2022 20:01:39 GMT, Roger Riggs wrote: >> During deserialization of a serialized data stream that contains a proxy >> descriptor with non-public interfaces >> `java.io.ObjectInputStream` checks that the interfaces can be loaded from a >> single classloader in `ObjectInputStream.re

Re: RFR: 8280642: IllegalAccessError thrown by ObjectInputStream.resolveProxyClass is not handled [v2]

2022-01-31 Thread Roger Riggs
On Mon, 31 Jan 2022 20:01:39 GMT, Roger Riggs wrote: >> During deserialization of a serialized data stream that contains a proxy >> descriptor with non-public interfaces >> `java.io.ObjectInputStream` checks that the interfaces can be loaded from a >> single classloader in `ObjectInputStream.re

Re: RFR: 8280642: IllegalAccessError thrown by ObjectInputStream.resolveProxyClass is not handled [v2]

2022-01-31 Thread Roger Riggs
> During deserialization of a serialized data stream that contains a proxy > descriptor with non-public interfaces > `java.io.ObjectInputStream` checks that the interfaces can be loaded from a > single classloader in `ObjectInputStream.resolveProxyClass`. > If the interfaces cannot be loaded from

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-31 Thread Mandy Chung
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification, wh

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack [v2]

2022-01-31 Thread Mandy Chung
On Sun, 30 Jan 2022 21:59:19 GMT, David Holmes wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo > > src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 260: > >> 258: * If this me

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack [v2]

2022-01-31 Thread Mandy Chung
> `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification, when invoked by JNI code with no Java class on the stack.

Re: Fix proposal for bug JDK-8221642

2022-01-31 Thread Alan Bateman
On 31/01/2022 09:21, Andreas Rosenberg wrote: Hi Mandy, thanks for your comments. Yes, the correct solution is to examine each caller sensitive method. Surely my idea is not perfect, as the problem with the ResourceBundle and the bootstrap loader shows. I had the hope that cases like this coul

Integrated: 8280889: java/lang/instrument/GetObjectSizeIntrinsicsTest.java fails with -XX:-UseCompressedOops

2022-01-31 Thread Aleksey Shipilev
On Fri, 28 Jan 2022 15:37:59 GMT, Aleksey Shipilev wrote: > Recent test regression after adding new cases in the test. Without compressed > oops, ~1G elements `Object[]` array takes >8G of memory, which fails the > test. The fix cuts it down to 512M when reference size is 8 bytes. > Additional

Re: RFR: 8280889: java/lang/instrument/GetObjectSizeIntrinsicsTest.java fails with -XX:-UseCompressedOops

2022-01-31 Thread Aleksey Shipilev
On Fri, 28 Jan 2022 15:37:59 GMT, Aleksey Shipilev wrote: > Recent test regression after adding new cases in the test. Without compressed > oops, ~1G elements `Object[]` array takes >8G of memory, which fails the > test. The fix cuts it down to 512M when reference size is 8 bytes. > Additional