> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC`
> display names were incorrectly substituted for CLDR. The reason it worked
> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the names
> for `zh-Hant` were cached and hit for the following `zh-MO` name
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>
> The issue notes that this is applicable for `WeakHashMap` which have `null`
> keys. However, the
On Sat, 4 Dec 2021 00:02:04 GMT, Brent Christian wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>>
>> The issue notes that this is applicable for `WeakHashMap` which have `null`
>> keys. Howev
Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC` display
names were incorrectly substituted for CLDR. The reason it worked fine after
`zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the names for
`zh-Hant` were cached and hit for the following `zh-MO` name retrieva
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>
> The issue notes that this is applicable for `WeakHashMap` which have `null`
> keys. However, the
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>> Si
On Thu, 2 Dec 2021 10:55:57 GMT, Andrew Leonard wrote:
> This is the case at Adoptium for example, which uses the Mozilla trusted CA
> certs.
But they didn't think skipping this test was too strong a step? For example
validation of the certs expiration is quite useful. I tried to update the te
On Tue, 2 Nov 2021 03:02:42 GMT, Vamsi Parasa wrote:
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
This pull request has now been integrated.
Changeset: 38f525e9
Author:vamsi-parasa
Committer: Sandhya Viswanathan
URL:
https://git.openjdk.java
On Fri, 3 Dec 2021 10:05:43 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andre
On Fri, 3 Dec 2021 17:19:17 GMT, Paul Sandoz wrote:
>> @JimLaskey Could you please review this PR which optimizes three of the
>> Pseudo-Random Number Generators you implemented in
>> https://bugs.openjdk.java.net/browse/JDK-8248862 ?
>
> @vamsi-parasa you can now integrate this and then I or s
On Thu, 2 Dec 2021 01:53:47 GMT, John Neffenger wrote:
>>> I'm testing it now. So far, it's working great!
>>>
>>> I found one boundary problem. The magic instant of `1980-01-01T00:00:00Z`
>>> triggers an extended header with the wrong time:
>>>
>>> ```
>>> file last modified on (DOS date/ti
On Thu, 2 Dec 2021 20:56:46 GMT, Vamsi Parasa wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add seeds for the random generators to eliminate run-to-run variance
>
> @JimLaskey Could you please review this PR whic
On Wed, 1 Dec 2021 12:03:15 GMT, Mai Đặng Quân Anh
wrote:
> When doing an unsigned upcast, we perform a signed cast followed by a bitwise
> and operation to clip the extended signed bit. The sign clip mask is
> currently calculated incorrectly, the correct mask should have the number of
> lea
On Fri, 3 Dec 2021 03:44:09 GMT, Mai Đặng Quân Anh
wrote:
> Thanks a lot for your support and review. Do I need another review here?
No need for this one, for next PR for the intrinsics will likely need two
HotSpot reviewers.
-
PR: https://git.openjdk.java.net/jdk/pull/6634
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>
> The issue notes that this is applicable for `WeakHashMap` which have `null`
> keys. However, the
The specification of ObjectInputStream constructors that invoke
`ObjectInputFilter.Config.getSerialFilterFactory()` do not mention exceptions
that may be thrown by the apply() method.
In both constructors, add the following to the paragraph the describes invoking
the factory:
* When the f
On Wed, 1 Dec 2021 18:19:05 GMT, Roger Riggs wrote:
> The effects of invalid values of `jdk.serialFilter` and
> `jdk.serialFilterFactory` properties are
> incompletely specified. The behavior for invalid values of the properties is
> different and
> use an unconventional exception type, `Excep
On Mon, 29 Nov 2021 17:07:52 GMT, Alan Bateman wrote:
>> @andrew-m-leonard I see you've add several APIs to ZipEntry in this PR. I
>> think this part will require discussion as it's not immediately clear that
>> we should over burden the ZipEntry API as proposed.
>
>> @AlanBateman yes, see abov
On Thu, 2 Dec 2021 01:53:47 GMT, John Neffenger wrote:
>>> I'm testing it now. So far, it's working great!
>>>
>>> I found one boundary problem. The magic instant of `1980-01-01T00:00:00Z`
>>> triggers an extended header with the wrong time:
>>>
>>> ```
>>> file last modified on (DOS date/ti
On Thu, 2 Dec 2021 12:26:33 GMT, Maurizio Cimadamore
wrote:
> This patch adds missing `@throws` tags to the javadoc of `MemorySegment::set`
> and `MemorySegment::setAtIndex`.
> These methods can fail with `UnsupportedOperationException` if the segment is
> read-only.
This pull request has now
On Fri, 3 Dec 2021 10:03:30 GMT, Athijegannathan Sundararajan
wrote:
> jlink plugins dump .class files in debug mode. jpackage tests already set
> jlink.debug property to true.
This pull request has now been integrated.
Changeset: ba2a8e5a
Author:Athijegannathan Sundararajan
URL:
On Fri, 3 Dec 2021 02:14:51 GMT, Vamsi Parasa wrote:
>> This change optimizes random number generators using
>> Math.unsignedMultiplyHigh()
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last revision:
>
> minor changes to the benchmark
LG
On Fri, 3 Dec 2021 10:03:30 GMT, Athijegannathan Sundararajan
wrote:
> jlink plugins dump .class files in debug mode. jpackage tests already set
> jlink.debug property to true.
LGTM
-
Marked as reviewed by jlaskey (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6696
On Fri, 3 Dec 2021 07:29:17 GMT, Toshio Nakamura wrote:
> Could you review this fix?
>
> Problem:
> Custom JRE generated by jlink cannot find non-ASCII named modules included
> inside the JRE.
>
> Cause and fix:
> If module or package name was composed by ASCII then non-ASCII characters,
> Im
jlink plugins dump .class files in debug mode. jpackage tests already set
jlink.debug property to true.
-
Commit messages:
- 8278205: jlink plugins should dump .class file in debug mode
Changes: https://git.openjdk.java.net/jdk/pull/6696/files
Webrev: https://webrevs.openjdk.java.
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request with a
On Thu, 2 Dec 2021 12:15:51 GMT, David Holmes wrote:
> I've solicited feedback from core-libs folk as this affects them the most. At
> present we, Oracle, run the jdk_svc tests as part of hotspot testing, but
> this change will suddenly cause jdk testing to include them. That is probably
> not
On Thu, 2 Dec 2021 21:07:30 GMT, Andrew Leonard wrote:
> PR https://github.com/openjdk/jdk/pull/6647 resolved the GENDATA_CACERTS_SRC
> fir --with-cacerts-src after the recipe, which meant the dependencies were
> wrong.
> This PR moves it before the recipe.
>
> Signed-off-by: Andrew Leonard
28 matches
Mail list logo
