Re: RFR: JDK-8272192 Shortcut String equality checks by checking equality of the value array [v2]

2021-09-05 Thread q2q-2q2
> Shortcut String equality checks by checking equality of the value array q2q-2q2 has updated the pull request incrementally with one additional commit since the last revision: JDK-8272192 Shortcut String equality checks by checking equality of the value array - Changes: - all

Re: RFR: 8273314: Add tier4 test groups

2021-09-05 Thread David Holmes
On Fri, 3 Sep 2021 09:10:20 GMT, Aleksey Shipilev wrote: > During the review of JDK-8272914 that added hotspot:tier{2,3} groups, > @iignatev suggested to create tier4 groups that capture all tests not in > tiers{1,2,3}. I have excluded `vmTestbase` and `hotspot:tier4,` because they > take 10+

Re: better random numbers

2021-09-05 Thread John Rose
On Sep 5, 2021, at 7:44 AM, Andrew Haley wrote: > > On 9/3/21 12:35 AM, John Rose wrote: > >> The reference I’d like to give here is to Dr. Melissa O’Neill’s >> website and articles: > > I'm quite sceptical. Anyone who says a (non-cryptographic) random- > number generator is "hard to predict"

Re: better random numbers

2021-09-05 Thread Andrew Haley
On 9/3/21 12:35 AM, John Rose wrote: > The reference I’d like to give here is to Dr. Melissa O’Neill’s > website and articles: I'm quite sceptical. Anyone who says a (non-cryptographic) random- number generator is "hard to predict" is either quite naive or in a state of sin, (;-) and while O’Neil

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v6]

2021-09-05 Thread Andrew Haley
On Thu, 26 Aug 2021 09:26:24 GMT, Wu Yan wrote: >> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4871: >> >>> 4869: // exit from large loop when less than 64 bytes left to read or >>> we're about >>> 4870: // to prefetch memory behind array border >>> 4871: int largeLoopExi

Re: RFR: 8231640: (prop) Canonical property storage

2021-09-05 Thread Jaikiran Pai
On Sun, 5 Sep 2021 12:56:46 GMT, Jaikiran Pai wrote: > The failure is consistently in a single test InfoOptsTest and it fails with > the following error when running the testUniqueInfoOpts test case. Looks like > a recent issue in some commit. I'll sort that out separately. Created https://bug

Re: RFR: 8231640: (prop) Canonical property storage

2021-09-05 Thread Jaikiran Pai
On Sat, 4 Sep 2021 15:25:59 GMT, Jaikiran Pai wrote: > The commit in this PR implements the proposal for enhancement that was > discussed in the core-libs-dev mailing list recently[1], for > https://bugs.openjdk.java.net/browse/JDK-8231640 > > At a high level - the `store()` APIs in `Propertie

Re: RFR: JDK-8273246 Amend the test java/nio/channels/DatagramChannel/ManySourcesAndTargets.java to execute in othervm mode [v2]

2021-09-05 Thread Alan Bateman
On Sun, 5 Sep 2021 11:00:27 GMT, Mark Sheppard wrote: >> A number of nio DatagramChannel tests are intermittently failing on >> macosx-aarch64. >> In some instances this is a receive call blocking indefinitely waiting on >> data which has >> already been sent, and should be available immediatel

Re: RFR: 8231640: (prop) Canonical property storage

2021-09-05 Thread Jaikiran Pai
Hello Andrey, On 05/09/21 12:02 am, Andrey Turbanov wrote: src/java.base/share/classes/java/util/Properties.java line 924: 922: writeDateComment(bw); 923: synchronized (this) { 924: for (Map.Entry e : new TreeMap<>(map).entrySet()) { Is this sorting intentionally

Re: RFR: 8231640: (prop) Canonical property storage

2021-09-05 Thread Jaikiran Pai
Hello Alan, On 05/09/21 1:46 pm, Alan Bateman wrote: On 04/09/2021 16:50, Jaikiran Pai wrote: The commit in this PR implements the proposal for enhancement that was discussed in the core-libs-dev mailing list recently[1], for https://bugs.openjdk.java.net/browse/JDK-8231640 At a high level -

Re: RFR: JDK-8273246 Amend the test java/nio/channels/DatagramChannel/ManySourcesAndTargets.java to execute in othervm mode [v2]

2021-09-05 Thread Mark Sheppard
> A number of nio DatagramChannel tests are intermittently failing on > macosx-aarch64. > In some instances this is a receive call blocking indefinitely waiting on > data which has > already been sent, and should be available immediately to the receive method > call. > Other test failure scenari

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-05 Thread Alan Bateman
On 04/09/2021 12:12, Lance Andersen wrote: Perhaps the jar validate option could/should be updated to flag when an index is there? We could add a warning for JDK 18 when main::genIndex is invoked as I assume we would want to at least wait until JDK19 to remove this functionality? I'm not

Re: RFR: 8231640: (prop) Canonical property storage

2021-09-05 Thread Alan Bateman
On 04/09/2021 16:50, Jaikiran Pai wrote: The commit in this PR implements the proposal for enhancement that was discussed in the core-libs-dev mailing list recently[1], for https://bugs.openjdk.java.net/browse/JDK-8231640 At a high level - the `store()` APIs in `Properties` have been modified