On Wed, 2 Jun 2021 22:44:10 GMT, David Holmes wrote:
> > I think this is not deliberate. Since `rawAnnotations` may end up having
> > any of the following:
> > - `RuntimeVisibleAnnotations` (when there were just `RUNTIME` annotation
> > usages compiled into the class or `-XX+PreserveAllAnnotati
On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote:
> 8267630: Start of release updates for JDK 18
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4175
On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote:
> 8267630: Start of release updates for JDK 18
JDK 18 is right around the corner, time for the usual start-of-release
changeset for review.
Typical structure for these kinds of changes. I'll update the symbol file
information of JDK 17 b25 af
8267630: Start of release updates for JDK 18
-
Commit messages:
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8
On Wed, 2 Jun 2021 02:32:54 GMT, Yi Yang wrote:
>> The JDK codebase re-created many variants of checkIndex(`grep -I -r
>> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
>> annotated with @IntrinsicCandidate and it only has a corresponding C1
>> intrinsic version.
>
On Thu, 3 Jun 2021 03:23:13 GMT, Brian Goetz wrote:
> reasonable options are to either leave it alone, deprecate it, or engage
> in a much more deliberate redesign.?
My favorite option is to leave it alone and test it a bit with the test already
provided in this PR. That however requires one ap
On Tue, 1 Jun 2021 19:51:39 GMT, Raffaello Giulietti
wrote:
> Trivial changes to this non-normative document.
Marked as reviewed by smarks (Reviewer).
Looks good. Thanks for noticing and fixing this!
-
PR: https://git.openjdk.java.net/jdk/pull/4289
On Thu, 3 Jun 2021 03:09:58 GMT, Nick Gasson wrote:
>> macOS on Apple silicon uses slightly different ABI conventions to the
>> standard AArch64 ABI. The differences are outlined in [1]. In
>> particular in the standard (AAPCS) ABI, variadic arguments may be passed
>> in either registers or on
> macOS on Apple silicon uses slightly different ABI conventions to the
> standard AArch64 ABI. The differences are outlined in [1]. In
> particular in the standard (AAPCS) ABI, variadic arguments may be passed
> in either registers or on the stack following the normal calling
> convention. To h
It seems pretty clear that this "feature" is a leftover from an early
implementation, doesn't clearly say what it is supposed to do, is more
complicated than it looks, and is buggily implemented. While I
understand the temptation to "fix" it, at this point we'd realistically
be adding a basica
> macOS on Apple silicon uses slightly different ABI conventions to the
> standard AArch64 ABI. The differences are outlined in [1]. In
> particular in the standard (AAPCS) ABI, variadic arguments may be passed
> in either registers or on the stack following the normal calling
> convention. To h
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
> in
On Tue, 1 Jun 2021 17:43:45 GMT, Igor Veresov wrote:
>> Thank you @veresov!
>>
>> I'm glad to have more comments from hotspot-compiler group.
>>
>> Later, I'd like to integrate it if there are no more comments/objections.
>>
>> Thanks!
>> Yang
>
> @kelthuzadx Sorry about the delay. Could you
On Thu, 3 Jun 2021 00:29:00 GMT, Sandhya Viswanathan
wrote:
> The Vector API toShuffle method can be optimized using existing vector
> conversion intrinsic.
>
> The following changes are made:
> 1) vector.toShuffle java implementation is changed to call
> VectorSupport.convert.
> 2) The conv
On Thu, 3 Jun 2021 00:29:00 GMT, Sandhya Viswanathan
wrote:
> The Vector API toShuffle method can be optimized using existing vector
> conversion intrinsic.
>
> The following changes are made:
> 1) vector.toShuffle java implementation is changed to call
> VectorSupport.convert.
> 2) The conv
On Wed, 2 Jun 2021 07:48:47 GMT, Nils Eliasson wrote:
> Please wait until you have two reviewers before integrating.
Sure! Thanks so much for looking at this PR!
-
PR: https://git.openjdk.java.net/jdk/pull/4272
The Vector API toShuffle method can be optimized using existing vector
conversion intrinsic.
The following changes are made:
1) vector.toShuffle java implementation is changed to call
VectorSupport.convert.
2) The conversion intrinsic (inline_vector_convert()) in vectorIntrinsics.cpp
is change
On Thu, 3 Jun 2021 00:47:45 GMT, Jonathan Gibbons wrote:
> Please review a small test fix, to include hamcrest.jar, as required by the
> latest version of JUnit in jtreg 6.
This pull request has now been integrated.
Changeset: ef01e478
Author:Jonathan Gibbons
URL:
https://git.open
On Thu, 3 Jun 2021 00:47:45 GMT, Jonathan Gibbons wrote:
> Please review a small test fix, to include hamcrest.jar, as required by the
> latest version of JUnit in jtreg 6.
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4328
Please review a small test fix, to include hamcrest.jar, as required by the
latest version of JUnit in jtreg 6.
-
Commit messages:
- JDK-8268150: tier2: test/jdk/tools/jpackage/junit/junit.java needs updating
for jtreg 6
Changes: https://git.openjdk.java.net/jdk/pull/4328/files
On Wed, 2 Jun 2021 22:22:55 GMT, Paul Sandoz wrote:
>> The specification of `forEachRemaining`, accepting a primitive functional
>> interface, on the primitive iterators is updated to be the same as for
>> `Iterator.forEachRemaining`, specifically the following is added:
>>
>>
>> *
>>
On Wed, 2 Jun 2021 18:07:55 GMT, Daniel Fuchs wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tiny editorial tweaks.
>
> src/java.base/share/classes/java/util/Map.java line 396:
>
>> 394:
>> 395: /**
>> 396:
On 3/06/2021 2:54 am, Joe Darcy wrote:
If the reflection runtime doesn't implement the semantics of
-XX+PreserveAllAnnotations, I suggest deprecating/obsoleting/etc. that
option now.
I have to agree with Joe now. I mistakenly thought the raw annotation
stream was exposed to some parts of refl
On 3/06/2021 1:38 am, Peter Levart wrote:
On Wed, 2 Jun 2021 13:24:10 GMT, David Holmes wrote:
Sorry now I see what happens. We aren't combining two arrays of
annotations we're concatenating two streams of byes, each of which
represents a set of annotations, starting with the length.
The code
On Wed, 2 Jun 2021 22:22:22 GMT, Jonathan Gibbons wrote:
> Please review a test fix to refer to the new name of the TestNG module.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4325
On Wed, 2 Jun 2021 22:22:22 GMT, Jonathan Gibbons wrote:
> Please review a test fix to refer to the new name of the TestNG module.
This pull request has now been integrated.
Changeset: d46a2c8e
Author:Jonathan Gibbons
URL:
https://git.openjdk.java.net/jdk/commit/d46a2c8ecfac785ae2c9
On Wed, 2 Jun 2021 22:22:22 GMT, Jonathan Gibbons wrote:
> Please review a test fix to refer to the new name of the TestNG module.
Marked as reviewed by psandoz (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4325
On Wed, 2 Jun 2021 22:22:22 GMT, Jonathan Gibbons wrote:
> Please review a test fix to refer to the new name of the TestNG module.
Looks good and trivial.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4325
Please review a test fix to refer to the new name of the TestNG module.
-
Commit messages:
- JDK-8268147: need to update reference to testng module for jtreg6
Changes: https://git.openjdk.java.net/jdk/pull/4325/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4325&range=
> The specification of `forEachRemaining`, accepting a primitive functional
> interface, on the primitive iterators is updated to be the same as for
> `Iterator.forEachRemaining`, specifically the following is added:
>
>
> *
> * Subsequent behavior of an iterator is unspecified if th
On 3/06/2021 12:39 am, Peter Levart wrote:
On Wed, 2 Jun 2021 05:59:05 GMT, David Holmes wrote:
Sorry Jaroslav but I don't really see this test as a basic functional
test of the PreserveAllAnnotations flag. There is no need for any
dynamic retention mode switch. All you need as I've said previ
On Wed, 2 Jun 2021 17:54:06 GMT, Stuart Marks wrote:
>> I'm fixing this along with a couple intertwined issues.
>>
>> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>>
>> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
>> really immutable) but that subcl
On Wed, 2 Jun 2021 13:48:47 GMT, Andy Herrick wrote:
> JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed
> as SCR
Marked as reviewed by almatvee (Reviewer).
Can we add a simple test for .scr executables?
-
PR: https://git.openjdk.java.net/jdk/pull/4306
On Tue, 1 Jun 2021 23:37:10 GMT, Stuart Marks wrote:
>> Yeah, well spotted. I agree it's awkward. How about we lean on the behavior
>> of the boxed counterpart:
>>
>> /**
>> * Performs the given action for each remaining element until all
>> elements
>> * have been processed or t
The specification of `forEachRemaining`, accepting a primitive functional
interface, on the primitive iterators is updated to be the same as for
`Iterator.forEachRemaining`, specifically the following is added:
*
* Subsequent behavior of an iterator is unspecified if the action throw
On Tue, 1 Jun 2021 21:34:10 GMT, Stuart Marks wrote:
>> The specification of `forEachRemaining`, accepting a primitive functional
>> interface, on the primitive iterators is updated to be the same as for
>> `Iterator.forEachRemaining`, specifically the following is added:
>>
>>
>> *
>>
On Tue, 1 Jun 2021 22:40:53 GMT, Paul Sandoz wrote:
>> src/java.base/share/classes/java/util/PrimitiveIterator.java line 77:
>>
>>> 75: *
>>> 76: * The behavior of an iterator is unspecified if the action
>>> modifies the
>>> 77: * collection in any way (even by calling the {@li
On Tue, 1 Jun 2021 19:54:59 GMT, Paul Sandoz wrote:
> The specification of `forEachRemaining`, accepting a primitive functional
> interface, on the primitive iterators is updated to be the same as for
> `Iterator.forEachRemaining`, specifically the following is added:
>
>
> *
> * S
On Wed, 2 Jun 2021 21:50:24 GMT, Bradford Wetmore wrote:
>> A trivial copyright fix.
>
> LGTM
@bradfordwetmore - Thanks for the review.
-
PR: https://git.openjdk.java.net/jdk/pull/4323
On Wed, 2 Jun 2021 21:39:15 GMT, Daniel D. Daugherty wrote:
> A trivial copyright fix.
This pull request has now been integrated.
Changeset: 76fdf2c8
Author:Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/commit/76fdf2c89bb7df9140438fcbaf16ea5fda024551
Stats: 1 line in
On Wed, 2 Jun 2021 21:39:15 GMT, Daniel D. Daugherty wrote:
> A trivial copyright fix.
LGTM
-
Marked as reviewed by wetmore (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4323
On Wed, 2 Jun 2021 21:40:59 GMT, Paul Sandoz wrote:
>> A trivial copyright fix.
>
> Marked as reviewed by psandoz (Reviewer).
@PaulSandoz - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/4323
On Wed, 2 Jun 2021 21:39:15 GMT, Daniel D. Daugherty wrote:
> A trivial copyright fix.
Marked as reviewed by psandoz (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4323
A trivial copyright fix.
-
Commit messages:
- 8268146: fix for JDK-8266254 fails validate-source
Changes: https://git.openjdk.java.net/jdk/pull/4323/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4323&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8268146
Can the test cases be broken into pieces or otherwise decomposed into
several shorter-running tests?
-Joe
On 6/2/2021 2:35 PM, Maurizio Cimadamore wrote:
This patch increases time out for both TestUpcall and TestDowncall. These tests
were already long-running, but with JEP-412, they were beef
This patch increases time out for both TestUpcall and TestDowncall. These tests
were already long-running, but with JEP-412, they were beefed up even more, so
now they time out on some debug builds.
This patch also address a minor issue in TestResourceScope which can sometimes
lead to intermitt
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 16:56:07 GMT, Joe Darcy wrote:
> If the reflection runtime doesn't implement the semantics of
> -XX+PreserveAllAnnotations, I suggest deprecating/obsoleting/etc. that
> option now.
>
> -Joe
What is the -XX+PreserveAllAnnotations semantics in terms of reflection? The VM
spec
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> This patch replaces `LibraryLookup` with a simpler `SymbolLookup
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> This patch replaces `LibraryLookup` with a simpler `SymbolLookup
On Wed, 2 Jun 2021 18:40:48 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with 10
>> additional commits since the last revision:
>>
>> - Update test/jdk/java/foreign/TestIntrinsics.java
>>
>>Co-authored-by: Paul Sandoz
>> - Update test/jdk/
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
Thanks Daniel!
For the questi
On Wed, 2 Jun 2021 20:17:20 GMT, Maurizio Cimadamore
wrote:
>> This patch overhauls the library loading mechanism used by the Foreign
>> Linker API. We realized that, while handy, the *default* lookup abstraction
>> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>>
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
I now agree that what you propos
On Wed, 2 Jun 2021 20:15:55 GMT, Jonathan Gibbons wrote:
>> Please review the change to update to using jtreg 6.
>>
>> The primary change is to the jib-profiles.js file, which specifies the
>> version of jtreg to use, for those systems that rely on this file. In
>> addition, the `requiredVers
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
Argh! You're right. It's this li
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore
wrote:
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> T
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> This patch replaces `LibraryLookup` with a simpler `SymbolLookup
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion` has been updated in the various `TEST.ROOT`
> files.
>
>
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
I tried, but getRawPath returned
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
I believe this is the wrong fix
On Wed, 2 Jun 2021 17:58:29 GMT, Vyom Tewari wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Inline local vars where reasonable
>
> src/java.base/share/classes/java/util/BitSet.java line 105:
>
>> 103:
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore
wrote:
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> T
Special characters are different in File and URI. Treat File input as File
using FileInputStream instead of converting to an URI, but fall back to URI in
case of error for compatibility (in error handling).
-
Commit messages:
- 8266019: StreamResult(File) writes to incorrect file p
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 17:54:06 GMT, Stuart Marks wrote:
>> I'm fixing this along with a couple intertwined issues.
>>
>> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>>
>> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
>> really immutable) but that subcl
On Wed, 2 Jun 2021 16:37:49 GMT, Сергей Цыпанов
wrote:
>> There is a few JDK classes duplicating the contents of Long.hashCode() for
>> hash code calculation. They should explicitly delegate to Long.hashCode().
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
>
> This PR contains API and implementation changes for [JEP-414 Vector API
> (Second Incubator)](https://openjdk.java.net/jeps/414), in preparation for
> when targeted.
>
> Enhancements are made to the API for the support of operations on characters,
> such as for UTF-8 character decoding. Speci
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
> I'm fixing this along with a couple intertwined issues.
>
> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>
> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
> really immutable) but that subclasses can be modifiable.
>
> 3. Clarify some confusing, hist
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
I file
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore
wrote:
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> T
On Fri, 28 May 2021 02:14:45 GMT, Igor Ignatyev wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spaces updated.
>
> test/failure_handler/src/share/classes/jdk/test/failurehandler/action/PatternAction.java
> line
This patch overhauls the library loading mechanism used by the Foreign Linker
API. We realized that, while handy, the *default* lookup abstraction
(`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
This patch replaces `LibraryLookup` with a simpler `SymbolLookup` abstract
On Wed, 2 Jun 2021 17:12:21 GMT, Stuart Marks wrote:
> A quick search reveals that Guava has a public subclass of
> SimpleImmutableEntry:
> https://guava.dev/releases/30.1.1-jre/api/docs/com/google/common/cache/RemovalNotification.html
>There are possibly others. It doesn't seem worth the incom
> This PR contains Short Vector Math Library support related changes for
> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
> in preparation for when targeted.
>
> Intel Short Vector Math Library (SVML) based intrinsics in native x86
> assembly provide optimized imple
On Wed, 2 Jun 2021 07:35:25 GMT, Rémi Forax wrote:
> i wonder if we should not declare SimpleImmutableEntry final, while it's not
> a backward compatible change,
> it's may be better on the long term because SimpleImmutableEntry is already
> used as an immutable type,
> so instead of documentin
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Changes to Math and Long look fine.
-
Marked as reviewe
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 13:48:47 GMT, Andy Herrick wrote:
> JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed
> as SCR
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4306
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Hi Patrick, some minor comments.
src/java.base/share/classes/java/la
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
If the reflection runtime doesn't implement the semantics of
-XX+PreserveAllAnnotations, I suggest deprecating/obsoleting/etc. that
option now.
-Joe
On 6/2/2021 7:48 AM, Peter Levart wrote:
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
There doesn't seem to be much support for t
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 15:00:56 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8268113: Inline local vars wh
On Wed, 2 Jun 2021 14:50:23 GMT, liach
wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Inline local vars where reasonable
>
> src/java.base/share/classes/java/lang/Double.java line 881:
>
>> 879: p
On Thu, 27 May 2021 20:33:50 GMT, Brian Burkhalter wrote:
> Modify the specification of `java.io.File.equals` to clarify that equality is
> based only on a comparison of abstract pathnames as opposed to the file
> system objects that the `File`s represent.
This pull request has now been integr
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8268113: Delegate to Double.h
On Wed, 2 Jun 2021 14:51:35 GMT, liach
wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Delegate to Double.hashCode()
>
> src/java.desktop/macosx/classes/apple/laf/JRSUIConstants.java line 115:
>
>> 113
Please review the change to update to using jtreg 6.
The primary change is to the jib-profiles.js file, which specifies the version
of jtreg to use, for those systems that rely on this file. In addition, the
`requiredVersion` has been updated in the various `TEST.ROOT` files.
All the tests tha
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/runtime/ObjectMethods.java line
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
We req
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/invoke/MemberName.java line 331
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator
Please find below a fix that will make
`java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to the
rare case where addresses bound to a network interfaces are updated while the
test is running.
Instead of using `NetworkInterface::equals` to compare network interfaces, the
t
On Fri, 21 May 2021 01:52:27 GMT, Weijun Wang wrote:
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usage it is suppressing, and
> with the
1 - 100 of 138 matches
Mail list logo
