On Thu, 17 Dec 2020 12:11:33 GMT, Jie Fu wrote:
> Hi all,
>
> java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'.
> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
> The current implementation only supports maximum 3800M on 32-bit systems [1].
>
On Mon, 21 Dec 2020 14:37:57 GMT, Сергей Цыпанов
wrote:
>> I don't think so, the code is fine, for me.
>
> @forax I've sent a mail into compiler-dev list:
> http://mail.openjdk.java.net/pipermail/compiler-dev/2020-December/015857.html
>
> Let's see what they decide.
FYI, despite the confusing
On Mon, 21 Dec 2020 15:34:16 GMT, Roger Riggs wrote:
>> Jie Fu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Ignore OOME for testOOME
>> - Revert the change
>
> Completely ignoring the exception will leave no trace that the test was
On Mon, 21 Dec 2020 23:37:08 GMT, Jie Fu wrote:
>> Hi all,
>>
>> java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'.
>> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
>> The current implementation only supports maximum 3800M on 32-bit systems [1]
> Hi all,
>
> java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'.
> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
> The current implementation only supports maximum 3800M on 32-bit systems [1].
>
> I've tried to reduce the -Xmx size, but it still
Hi,
JDK-8248901 is backported to 11.0.11-oracle. I'd like to backport it for parity.
Change applies cleanly, but 11u needs minor adaptation:
- Keep "import java.util.Iterator;" in Module.java.
- "toModuleInfo" has one argument less in 11u, so pass one "null" less.
Bug:
https://bugs.openjdk.java.n
On Sat, 19 Dec 2020 09:45:09 GMT, Jie Fu wrote:
>> Hi all,
>>
>> java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'.
>> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
>> The current implementation only supports maximum 3800M on 32-bit systems [1]
On Mon, 21 Dec 2020 14:26:45 GMT, Сергей Цыпанов
wrote:
>> This message is purely informational: I may have found a JBS comment that
>> provides historical context for that "this method is likely to run
>> significantly faster under most implementations" phrase. Here:
>> https://bugs.openjdk.
On Thu, 17 Dec 2020 11:07:55 GMT, Rémi Forax
wrote:
>> Should I then wait for the fix of that bug to remove `@SupressWarnings`?
>
> I don't think so, the code is fine, for me.
@forax I've sent a mail into compiler-dev list:
http://mail.openjdk.java.net/pipermail/compiler-dev/2020-December/0158
On Mon, 21 Dec 2020 11:32:28 GMT, Pavel Rappo wrote:
>> Hi all,
>>
>> According to the document of
>> [SafeVarargs](https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/SafeVarargs.html).
>>
>>> Compilers are encouraged to issue warnings when this annotation type is
>>> appl
Hi Götz,
thanks for the review!
Best regards,
Martin
From: Lindenmaier, Goetz
Sent: Montag, 21. Dezember 2020 14:44
To: Doerr, Martin ; core-libs-dev
; jdk-updates-...@openjdk.java.net
Cc: Langer, Christoph
Subject: RE: [11u] RFR: 8235351: Lookup::unreflect should bind with the
original cal
Hi Martin,
The change looks good.
The private methods have been called at those places before, so this is
straight forward.
Best regards,
Goetz.
From: Doerr, Martin
Sent: Monday, December 21, 2020 11:52 AM
To: core-libs-dev ;
jdk-updates-...@openjdk.java.net
Cc: Langer, Christoph ; Lindenmai
On Mon, 14 Dec 2020 00:40:08 GMT, Martin Buchholz wrote:
>> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12
>
> Martin Buchholz has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains one commit:
>
> JDK-8234131
Marked a
On Tue, 8 Dec 2020 05:54:24 GMT, Martin Buchholz wrote:
>> 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates
>
> Martin Buchholz has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compa
On Wed, 9 Dec 2020 20:20:49 GMT, Martin Buchholz wrote:
>> 8246585: ForkJoin updates
>
> Martin Buchholz has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request con
On Sat, 19 Dec 2020 09:09:50 GMT, Guoxiong Li
wrote:
>> Apart from the @SuppressWarnings, this looks good to me.
>> And i like the irony of this.
>
> Hi all,
>
> According to the document of
> [SafeVarargs](https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/SafeVarargs.html
Hi,
JDK-8235351 is backported to 11.0.11-oracle. I'd like to backport it for parity.
Change doesn't apply cleanly, because
https://bugs.openjdk.java.net/browse/JDK-8233527 is not in 11u (jdk14 uses
hasFullPrivilegeAccess(), but older versions use hasPrivateAccess()).
Bug:
https://bugs.openjdk.j
On 20/12/2020 19:15, Philippe Marschall wrote:
On 20.12.20 18:47, Rob Spoor wrote:
...
That "> 0" is incorrect here; it's allowed to return 0 before EOF
I don't think the method is allowed to return 0 before EOF. To quote
from the method Javadoc.
> This method blocks until input data is a
On Mon, 21 Dec 2020 09:51:25 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2459:
>>
>>> 2457: byte[] bytes = in.readAllBytes();
>>> 2458: return
>>> CertificateFactory.getInstance("X509").generateCRLs(
>>> 2
On Mon, 21 Dec 2020 09:40:39 GMT, Сергей Цыпанов
wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
>> revert changes in Apache Santuari
> Hello, I feel like this was previously discussed in
> https://mail.openjdk.java.net/pipermail/core-libs-dev/ but since I cannot
> find original mail I post this here.
>
> Currently `Collections.addAll()` is implemented and documented as:
> /**
> * ...
> * The behavior of this con
On Mon, 21 Dec 2020 09:16:11 GMT, Andrey Turbanov
wrote:
>> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8080272: Refactor I/O stream copying
Forwardport JDK 16 -> JDK 17
-
Commit messages:
- Merge
- 8258007: Add instrumentation to NativeLibraryTest
- 8258002: Update "type" terminology in generated docs
- 8223607: --override-methods=summary ignores some signature changes
- 8258687: Build broken on Windows after fix for
On Mon, 21 Dec 2020 09:05:48 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 16 -> JDK 17
This pull request has now been integrated.
Changeset: d2343880
Author:Jesper Wilhelmsson
URL: https://git.openjdk.java.net/jdk/commit/d2343880
Stats: 1822 lines in 76 files changed: 1281 i
> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
revert changes in Apache Sant
On Wed, 2 Dec 2020 17:34:00 GMT, Anton Kozlov wrote:
> Please review a small change that replaces use of objc_msgSend_stret in macOS
> platform code with pure ObjC code. It's also a prerequisite for macOS/AArch64
> support, where objc_msgSend_stret is not available.
This pull request has now b
On Mon, 21 Dec 2020 07:55:06 GMT, Andrey Turbanov
wrote:
>> I already suggested this, but anyway please always extract the changes to
>> the java.desktop module to the separate PR.
>
> I've extracted changes in java.desktop into separate PR #1856
> Reverted this changes from current PR.
Probab
> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
Andrey Turbanov has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains
On Sun, 20 Dec 2020 22:48:24 GMT, Sergey Bylokhov wrote:
>> So these changes are all over the place which means no one person knows how
>> to test all of it.
>> Have you run the sound, swing tests, and the printing tests on unix and
>> windows ?
>> For printing for sure you'll need to do some
29 matches
Mail list logo
