Re: RFR: 8257882: Implement linkToNative intrinsic on AArch64 [v3]

2020-12-13 Thread Nick Gasson
On Fri, 11 Dec 2020 09:29:57 GMT, Andrew Haley wrote: >> Nick Gasson has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8257882: Implement linkToNative intrinsic on AArch64 [v4]

2020-12-13 Thread Nick Gasson
> This is more-or-less a straight port of the x86 code to AArch64. > GraphKit::make_native_call() calls SharedRuntime::make_native_invoker() > to generate a blob that jumps to the native function entry point. This > simply switches the thread state from Java to native and handles the > safepoint po

RFR: 8256820: AArch64: Optimize vector rotate (immediate) with shift and insert instructions

2020-12-13 Thread Dong Bo
This patch optimizes vectorial rotate (immediate) on aarch64 with shift and insert instructions, i.e. SLI and SRI. Patch passed jtreg tier1-3 tests with linux-aarch64-server-fastdebug build. Tests under `test/hotspot/jtreg/compiler/c2/cr6340864/` runned specially for the correctness and passed.

Re: Impossible (?) code path resulting in IllegalStateException on jdk14+

2020-12-13 Thread David Holmes
Hi Martin, On 14/12/2020 12:48 pm, Martin Buchholz wrote: 1. JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue It's surprising that you can have a repro which is essentially just simple producer-consumer.  Can we remove the

Re: Impossible (?) code path resulting in IllegalStateException on jdk14+

2020-12-13 Thread Martin Buchholz
1. JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue It's surprising that you can have a repro which is essentially just simple producer-consumer. Can we remove the forkjoinpool from the repro (just threads?) On Sun, Dec 13, 202

Re: Impossible (?) code path resulting in IllegalStateException on jdk14+

2020-12-13 Thread David Holmes
Hi Dawid, This appears to be a bug in AbstractQueuedSynchronizer and FJP interaction, so cc'ing core-libs as this is not a hotspot issue. Also cc'ing Martin and Doug as this is a j.u.c bug. Cheers, David On 12/12/2020 12:56 am, Dawid Weiss wrote: So, I know what this is. Sort of. This isn'

Re: RFR: 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 [v3]

2020-12-13 Thread Martin Buchholz
On Fri, 11 Dec 2020 15:07:45 GMT, Petr Janeček wrote: >> The changes to doc comments look good. >> >> Thanks for incorporating my earlier code snippet suggestions published on >> [concurrency-interest](http://cs.oswego.edu/pipermail/concurrency-interest/2020-November/017264.html)! > > This als

Re: RFR: 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 [v4]

2020-12-13 Thread Martin Buchholz
> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 Martin Buchholz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8234131 - Changes: https://git.openjdk.java.net/jdk/pull/1647/files Web

[jdk16] Integrated: 8254350: CompletableFuture.get may swallow InterruptedException

2020-12-13 Thread Martin Buchholz
On Sun, 13 Dec 2020 03:31:44 GMT, Martin Buchholz wrote: > 8254350: CompletableFuture.get may swallow InterruptedException This pull request has now been integrated. Changeset: 43dc3f79 Author:Martin Buchholz URL: https://git.openjdk.java.net/jdk16/commit/43dc3f79 Stats: 178 line

Re: [jdk16] RFR: 8254350: CompletableFuture.get may swallow InterruptedException

2020-12-13 Thread Doug Lea
On Sun, 13 Dec 2020 03:31:44 GMT, Martin Buchholz wrote: > 8254350: CompletableFuture.get may swallow InterruptedException Marked as reviewed by dl (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/17

Re: [jdk16] RFR: 8254350: CompletableFuture.get may swallow InterruptedException

2020-12-13 Thread Alan Bateman
On Sun, 13 Dec 2020 03:31:44 GMT, Martin Buchholz wrote: > 8254350: CompletableFuture.get may swallow InterruptedException Previously reviewed for openjdk/jdk, looks good. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk16/pull/17