Re: RFR: 8256486: Linux/Windows-x86 builds broken after JDK-8254231 [v7]

2020-11-26 Thread David Holmes
On Wed, 25 Nov 2020 12:09:07 GMT, Jorn Vernee wrote: >> JDK-8254231 breaks the Linux and Windows x86 (32-bit) builds. This contains >> the needed changes to get it working again. >> >> Perhaps the most interesting change is adding the `JNI_ENTRY_CPP_NOENV` >> macro. Using just JNI_ENTRY was ca

Re: RFR: 8257186: Size of heap segments is not computed correctlyFix overflow in size computation for heap segments

2020-11-26 Thread Jorn Vernee
On Thu, 26 Nov 2020 18:29:42 GMT, Maurizio Cimadamore wrote: > There is a subtle bug in the heap segment factories: the byte size is > computed using an int multiplication instead of a long multiplication. > Because of that, it is possible to observe overflow when creating segments > out of a

RFR: 8257189: Handle concurrent updates of MH.form better

2020-11-26 Thread Vladimir Ivanov
Concurrent updates may lead to redundant LambdaForms created and unnecessary class loading when those are compiled. Most notably, it severely affects MethodHandle customization: when a MethodHandle is called from multiple threads, every thread starts customization which takes enough time for o

RFR: 8256541: Sort out what version of awk is used in the build system

2020-11-26 Thread Magnus Ihse Bursie
For historical reasons, there exists a variety of different implementations of awk: awk (the original implementation), gawk (the GNU version), nawk (new awk, iirc) and the lesser known mawk. Things are complicated by the fact that the original awk is seldom used, but instead gawk or nawk is ty

RFR: 8257184: Upstream 8252504: Add a method to MemoryLayout which returns a offset-computing method handle

2020-11-26 Thread Jorn Vernee
This upstreams the patch from: https://github.com/openjdk/panama-foreign/pull/396 There were only some minor merge conflicts due to imports and some tests being replaced by java/foreign/TestNulls. All tests still pass, no other changes were needed. - Commit messages: - Add a meth

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput [v2]

2020-11-26 Thread Richard Fussenegger
On Thu, 26 Nov 2020 18:53:06 GMT, Alan Bateman wrote: >> Richard Fussenegger has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > src/java.base/share/classes/jav

Re: RFR: 8170432: Class java.util.UUID & @Override

2020-11-26 Thread Daniel Fuchs
On Thu, 26 Nov 2020 17:01:59 GMT, Richard Fussenegger wrote: > Adds `@Override` annotation to all methods in `java.util.UUID` that implement > methods from the implemented interfaces. Hi, This looks reasonable to me. best regards, -- daniel - Marked as reviewed by dfuchs (Revi

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput [v2]

2020-11-26 Thread Alan Bateman
On Thu, 26 Nov 2020 18:59:57 GMT, Richard Fussenegger wrote: >> Made byte constructor public and changed the length assertion to an >> `IllegalArgumentException`, added a `getBytes` method that allows users to >> retrieve the raw bytes of the UUID, and created a new private constructor >> wit

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput [v2]

2020-11-26 Thread Richard Fussenegger
> Made byte constructor public and changed the length assertion to an > `IllegalArgumentException`, added a `getBytes` method that allows users to > retrieve the raw bytes of the UUID, and created a new private constructor > with an optimized construction for byte arrays that can set the version

RFR: 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant

2020-11-26 Thread Richard Fussenegger
6594730: UUID.getVersion() is only meaningful for Leach-Salz variant - Commit messages: - 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant Changes: https://git.openjdk.java.net/jdk/pull/1467/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1467&range=

RFR: 8257186: Size of heap segments is not computed correctlyFix overflow in size computation for heap segments

2020-11-26 Thread Maurizio Cimadamore
There is a subtle bug in the heap segment factories: the byte size is computed using an int multiplication instead of a long multiplication. Because of that, it is possible to observe overflow when creating segments out of arrays whose carrier has a byte size greater than one. - Co

RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput

2020-11-26 Thread Richard Fussenegger
Made byte constructor public and changed the length assertion to an `IllegalArgumentException`, added a `getBytes` method that allows users to retrieve the raw bytes of the UUID, and created a new private constructor with an optimized construction for byte arrays that can set the version as desi

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v7]

2020-11-26 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at > http://cr.openjdk.java.net/~jlaskey/prng/doc/a

RFR: 8170432: Class java.util.UUID & @Override

2020-11-26 Thread Richard Fussenegger
Adds `@Override` annotation to all methods in `java.util.UUID` that implement methods from the implemented interfaces. - Commit messages: - 8170432: Class java.util.UUID & @Override Changes: https://git.openjdk.java.net/jdk/pull/1463/files Webrev: https://webrevs.openjdk.java.net/

RFR: 8257164: Share LambdaForms for VH linkers/invokers.

2020-11-26 Thread Vladimir Ivanov
Introduce sharing of `LambdaForms` for `VarHandle` linkers and invokers. It reduces the number of LambdaForms needed at runtime. Testing: tier1-4 - Commit messages: - Share LambdaForms for VH linkers/invokers. Changes: https://git.openjdk.java.net/jdk/pull/1455/files Webrev: https

RFR: 8207329: Add NIL Constant to UUID

2020-11-26 Thread Richard Fussenegger
Adds a constant for the special NIL UUID where all bits are zero to `java.util.UUID`. The [8207329](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8207329) mentions the usage of it to avoid `null`, it for sure is also very handy in testing where a UUID is required and we do not care about

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v6]

2020-11-26 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at > http://cr.openjdk.java.net/~jlaskey/prng/doc/a

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2020-11-26 Thread Jim Laskey
On Wed, 25 Nov 2020 14:16:20 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8248862: Implement Enhanced Pseudo-Random Number Generators >> >> Changes to RandomGeneratorFactory requested by @Pau

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2020-11-26 Thread Jim Laskey
On Wed, 25 Nov 2020 14:10:17 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8248862: Implement Enhanced Pseudo-Random Number Generators >> >> Changes to RandomGeneratorFactory requested by @Pau

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v5]

2020-11-26 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at > http://cr.openjdk.java.net/~jlaskey/prng/doc/a

Integrated: 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly delay

2020-11-26 Thread Daniel Fuchs
On Wed, 25 Nov 2020 20:13:48 GMT, Daniel Fuchs wrote: > Hi, > > Please find here an almost trivial fix for: > 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly > delay > > The two tests are changed from using Math.random() to using the jdk test lib > RandomFactory, wh

Re: RFR: 8257074 Update the ByteBuffers micro benchmark [v3]

2020-11-26 Thread Chris Hegarty
> The ByteBuffers micro benchmark seems to be a little dated. > > It should be a useful resource to leverage when analysing the performance > impact of any potential implementation changes in the byte buffer classes. > More specifically, the impact of such changes on the performance of sharp >

Re: RFR: 8257074 Update the ByteBuffers micro benchmark [v2]

2020-11-26 Thread Chris Hegarty
> The ByteBuffers micro benchmark seems to be a little dated. > > It should be a useful resource to leverage when analysing the performance > impact of any potential implementation changes in the byte buffer classes. > More specifically, the impact of such changes on the performance of sharp >

Re: RFR: 8256999: Add C2 intrinsic for Reference.refersTo and PhantomReference::refersTo [v2]

2020-11-26 Thread Roman Kennke
On Wed, 25 Nov 2020 23:35:14 GMT, Vladimir Kozlov wrote: >> JDK-8188055 added the function Reference.refersTo. For performance, the >> supporting native methods Reference.refersTo0 and PhantomReference.refersTo0 >> should be intrinsified by C2. >> >> Initial patch was prepared by @fisk. >> >>

Re: RFR: 8256999: Add C2 intrinsic for Reference.refersTo and PhantomReference::refersTo [v2]

2020-11-26 Thread Vladimir Ivanov
On Wed, 25 Nov 2020 23:35:14 GMT, Vladimir Kozlov wrote: >> JDK-8188055 added the function Reference.refersTo. For performance, the >> supporting native methods Reference.refersTo0 and PhantomReference.refersTo0 >> should be intrinsified by C2. >> >> Initial patch was prepared by @fisk. >> >>

Integrated: 8256862: Several java/foreign tests fail on x86_32 platforms

2020-11-26 Thread Jorn Vernee
On Mon, 23 Nov 2020 14:54:21 GMT, Jorn Vernee wrote: > This patch fixes several failures on x86_32 of java/foreign tests. > > This is mostly done by disabling the failing tests, but the impl of CLinker > is also adjusted ton properly detect 32 bit platforms as unsupported. > > CLinker is speci

Re: RFR: 8253751: Dependencies of automatic modules are not propagated through module layers [v2]

2020-11-26 Thread Alan Bateman
> This is a corner case that arises when creating a Configuration for a child > module layer. If an explicit module in the child configuration reads an > automatic module in a parent configuration then it should read all automatic > modules in the parent configurations. Unfortunately, this read