On Sat, 19 Sep 2020 01:36:38 GMT, Naoto Sato wrote:
>> Hi,
>>
>> Please review the fix to JDK-8253321. As in the issue, uninitialized
>> (cached) hash code was incorrectly referenced in
>> equals() method. Removing it will correct the problem. Also, unrelated to
>> the issue, I fixed a paramet
https://bugs.openjdk.java.net/browse/JDK-8231591
- Added MultiLauncherTwoPhaseTest which uses predefine app image with multiple
launcher and tests to make sure installer
will create shortcuts for all launchers.
- Fixed Linux DesktopIntegration to create shortcuts for additional launcher if
we
On Sat, 19 Sep 2020 01:19:04 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing Joe's comments
>
> Marked as reviewed by joehw (Reviewer).
> Also, copyright year may need to be updated to 2020
> Hi,
>
> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached)
> hash code was incorrectly referenced in
> equals() method. Removing it will correct the problem. Also, unrelated to the
> issue, I fixed a parameter description in
> a private method. Naoto
Naoto Sato has
On Fri, 18 Sep 2020 23:26:39 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached)
> hash code was incorrectly referenced in
> equals() method. Removing it will correct the problem. Also, unrelated to the
> issue, I fixed a parameter des
On Fri, 18 Sep 2020 23:26:39 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached)
> hash code was incorrectly referenced in
> equals() method. Removing it will correct the problem. Also, unrelated to the
> issue, I fixed a parameter des
With more CDS related code added to VM, it is time to move CDS code to a
separate class. CDS is the new class which is
specific to CDS.
Tests: tier1-4
-
Commit messages:
- 8253208: Move CDS related code to a separate class
- Merge branch 'master' of https://github.com/yminqi/jdk i
Hi,
Please review the fix to JDK-8253321. As in the issue, uninitialized (cached)
hash code was incorrectly referenced in
equals() method. Removing it will correct the problem. Also, unrelated to the
issue, I fixed a parameter description in
a private method.
Naoto
-
Commit messag
On Fri, 18 Sep 2020 16:31:23 GMT, Andrew Dinn wrote:
> Can you explain where this restricted effect is documented?
Certainly! I’ve found that determining the capability of the CPU and whether to
enable AVX2 support if the chip
supports it is mostly controlled in: [vm_version_x86.cpp](
https://g
On Thu, 17 Sep 2020 08:09:31 GMT, Сергей Цыпанов
wrote:
> Hello,
>
> is it possible to have a code review for the changes proposed in JDK-8251548
> (originally contributed via
> https://mail.openjdk.java.net/pipermail/security-dev/2020-June/022137.html)?
> Sean Mullan has created an issue and
> Related to [JDK-8252730 jlink does not create reproducible builds on different
> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces
> ordering based on `Archive` module names to
> ensure stable files (and file signatures) across generated JDK images by
> jlink.
Ian Graves h
On Wed, 16 Sep 2020 20:26:10 GMT, Monica Beckwith wrote:
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have
On Fri, 18 Sep 2020 20:32:36 GMT, Erik Joelsson wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18 h
>
> But a Stream cleanly separate the lazy side effect free API from the
> mutable one (Collection) and can be optimized better by the VM (it's a push
> API instead of being a pull API).
No doubt, but a stream also creates overhead and is more cumbersome to use
in the example I gave. Of course, I
On Fri, 18 Sep 2020 15:34:26 GMT, Erik Joelsson wrote:
>> Build changes look good to me. I will take this branch for a spin.
>
> Our linux-aarch64 build fails with this:
> cc: error: unrecognized command line option '-std=c++14'
> when compiling
> build/linux-aarch64/buildjdk/hotspot/variant-ser
On Fri, 18 Sep 2020 15:55:52 GMT, Jason Tatton
wrote:
>> Hi Andrew,
>>
>> Thanks for coming back to me. Looking on the github
>> [PR](https://github.com/openjdk/jdk/pull/71) nobody is tagged as a
>> reviewer for this (perhaps this is a feature which is not being used).
>>> That's
>>> because w
> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com
>
> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions.
> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto
> Extensions:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
On Fri, 18 Sep 2020 11:04:34 GMT, Jason Tatton
wrote:
>> Hi everyone,
>>
>> This patch is just missing a couple of reviewers... Please can someone step
>> forward?
>>
>> I think it's a fairly straightforward change.
>>
>> -Jason
>
> Hi Andrew,
>
> Thanks for coming back to me. Looking on th
On Thu, 17 Sep 2020 08:09:31 GMT, Сергей Цыпанов
wrote:
> Hello,
>
> is it possible to have a code review for the changes proposed in JDK-8251548
> (originally contributed via
> https://mail.openjdk.java.net/pipermail/security-dev/2020-June/022137.html)?
> Sean Mullan has created an issue and
> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com
>
> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions.
> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto
> Extensions:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
On Fri, 18 Sep 2020 01:49:09 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this simple doc fix.
This pull request has now been integrated.
Changeset: 89044200
Author:Naoto Sato
URL: https://git.openjdk.java.net/jdk/commit/89044200
Stats: 2 lines in 1 file changed: 0 ins; 0 del;
On Fri, 18 Sep 2020 13:33:07 GMT, Erik Joelsson wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18 h
On Fri, 18 Sep 2020 01:49:09 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this simple doc fix.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/234
On Wed, 16 Sep 2020 20:26:10 GMT, Monica Beckwith wrote:
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have
Hi,
Please help to review
[JDK-8251188](https://bugs.openjdk.java.net/browse/JDK-8251188) fix which helps
to improve LDAP
tests stability. The list of changes: 1. Usages of wildcard address have been
replaced with loopback address. This
change includes addition of `LDAPTestUtils.initEnv` method
On 18/09/2020 12:06, Jason Tatton wrote:
> There are two separate things here:
> 1). Justification for the change itself:
> -The objective and justification for this patch is to bring the performance
> of StringLatin1 indexOf(char) in
> line with StringUTF16 indexOf(char) for x86 and ARM64. This
> This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1
> byte encoded Strings). It is provided for
> x86 and ARM64. The implementation is greatly inspired by the indexOf(char)
> intrinsic for StringUTF16. To incorporate it
> I had to make a small change to StringLatin1.jav
On Fri, 18 Sep 2020 02:48:15 GMT, Stuart Marks wrote:
>> Our local Santuario maintainer says:
>>
>> In general, changes to Apache Santuario should also be made at Apache so we
>> stay in sync.
>
> Hi @doom369, I hope we didn't end up wasting too much of your time with this.
> I wanted to respo
On Thu, 17 Sep 2020 18:20:08 GMT, Jason Tatton
wrote:
>> Hi Andrew,
>>
>> The current indexOf char intrinsics for StringUTF16 and the new one here for
>> StringLatin1 both use the AVX2 – i.e. 256
>> bit instructions, these are also affected by the frequency scaling which
>> affects the AVX-51
On Mon, 14 Sep 2020 06:30:50 GMT, Aleksei Voitylov
wrote:
>> Marked as reviewed by dholmes (Reviewer).
>
> thank you Alan, Erik, and David! When the JEP becomes Targeted, I'll use this
> PR to integrate the changes.
I added the contributors that could be found in the portola project commits. I
On Fri, 18 Sep 2020 01:49:09 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this simple doc fix.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/234
On Fri, 18 Sep 2020 08:27:44 GMT, Pavel Rappo wrote:
> To confirm that this would not require a CSR I asked Joe Darcy. Joe replied
> that this would NOT require a CSR.
This pull request has now been integrated.
Changeset: 83b2411f
Author:Pavel Rappo
URL: https://git.openjdk.java.net
This is a continuation of
https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
Changes since then:
* We've improved the write barrier as suggested by Andrew [1]
* The define-guards around R18 have been changed to `R18_RESERVED`. This will
be enabled for Windows only
On Fri, 18 Sep 2020 08:53:34 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/lang/String.java line 3186:
>>
>>> 3184: * caller.
>>> 3185: *
>>> 3186: * @param fa function to apply
>>
>> Shouldn't this be "_the_ function to apply"? Grep for other instance of
>> "f
On Fri, 18 Sep 2020 08:27:44 GMT, Pavel Rappo wrote:
> To confirm that this would not require a CSR I asked Joe Darcy. Joe replied
> that this would NOT require a CSR.
Changing the review from "Request Changes" to just "Comment.
-
PR: https://git.openjdk.java.net/jdk/pull/238
On Fri, 18 Sep 2020 08:27:44 GMT, Pavel Rappo wrote:
> To confirm that this would not require a CSR I asked Joe Darcy. Joe replied
> that this would NOT require a CSR.
Marked as reviewed by jlaskey (Reviewer).
Marked as reviewed by jlaskey (Reviewer).
-
PR: https://git.openjdk.ja
On Fri, 18 Sep 2020 08:46:45 GMT, Aleksey Shipilev wrote:
>> To confirm that this would not require a CSR I asked Joe Darcy. Joe replied
>> that this would NOT require a CSR.
>
> src/java.base/share/classes/java/lang/String.java line 3186:
>
>> 3184: * caller.
>> 3185: *
>> 3186:
On 17/09/2020 19:22, Jason Tatton wrote:
> This patch is just missing a couple of reviewers... Please can someone step
> forward?
>
> I think it's a fairly straightforward change.
I believe you got a review from Andrew Haley -- it was quoted in your
follow-up from which I selected the above respo
On Fri, 18 Sep 2020 08:27:44 GMT, Pavel Rappo wrote:
> To confirm that this would not require a CSR I asked Joe Darcy. Joe replied
> that this would NOT require a CSR.
Changes requested by shade (Reviewer).
src/java.base/share/classes/java/lang/String.java line 3186:
> 3184: * caller.
>
To confirm that this would not require a CSR I asked Joe Darcy. Joe replied
that this would NOT require a CSR.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.java.net/jdk/pull/238/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=238&range=00
Issue: h
Hi,
> Did you not follow these instructions to get your github account
> connected to your OCA record:
Those are for "OpenJDK Author, Committer or Reviewer", but I'm only a
contributor,
i.e. I cannot file an issue or commit directly. My previous contributions were
shipped as *.patch
files in ma
41 matches
Mail list logo
