Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v2]

2020-09-13 Thread Aleksei Voitylov
On Mon, 14 Sep 2020 04:18:39 GMT, David Holmes wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8247589: Implementation of Alpine Linux/x64 Port > > Marked as reviewed by dholmes (Reviewer). thank you Alan,

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

2020-09-13 Thread David Holmes
On Thu, 10 Sep 2020 20:48:23 GMT, Richard Reingruber wrote: > Hi, > > this is the continuation of the review of the implementation for: > > https://bugs.openjdk.java.net/browse/JDK-8227745 > https://bugs.openjdk.java.net/browse/JDK-8233915 > > It allows for JIT optimizations based on escape an

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v2]

2020-09-13 Thread David Holmes
On Wed, 9 Sep 2020 00:08:35 GMT, David Holmes wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8247589: Implementation of Alpine Linux/x64 Port > > Attempting to use the GitHub UI for further review. If this

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v2]

2020-09-13 Thread David Holmes
On Fri, 11 Sep 2020 07:36:57 GMT, Aleksei Voitylov wrote: >> test/hotspot/jtreg/runtime/StackGuardPages/exeinvoke.c line 282: >> >>> 280: >>> 281: pthread_attr_init(&thread_attr); >>> 282: pthread_attr_setstacksize(&thread_attr, stack_size); >> >> Just a comment in response to the explanat

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v2]

2020-09-13 Thread David Holmes
On Fri, 11 Sep 2020 07:03:37 GMT, Aleksei Voitylov wrote: >> continuing the review thread from here >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html >> >>> The download side of using JNI in these tests is that it complicates the >>> setup a bit for those that

Re: RFR: 8251397: Add release fence to ClassValueMap constructor

2020-09-13 Thread David Holmes
On Thu, 10 Sep 2020 13:29:29 GMT, Severin Gehwolf wrote: >> Just noting here that @galderz is a Red Hat employee and should be covered >> by the Red Hat OCA: >> https://www.oracle.com/technical-resources/oracle-contributor-agreement.html#r > > @galderz We'll have to wait until somebody marks you

Integrated: 8244778: Archive full module graph in CDS

2020-09-13 Thread Ioi Lam
On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote: > This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in > [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hot

Re: RFR: 8244778: Archive full module graph in CDS [v6]

2020-09-13 Thread Claes Redestad
On Sat, 12 Sep 2020 22:41:36 GMT, Ioi Lam wrote: >> This is the same patch as >> [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) >> published in >> [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermai