Re: RFR: 8252725: Refactor jlink GenerateJLIClassesPlugin code

HI, Sundar   Thanks for review. On 9/3/20 6:34 PM, sundararajan.athijegannat...@oracle.com wrote: Looks good to me. Few minor comment: * traceFileStream (and even the preexisting mainArgument) is accessed only inside GenerateJLIClassesPlugin. Could be private? I will fix them before push.

Re: RFR: 8252725: Refactor jlink GenerateJLIClassesPlugin code

Looks good to me. Few minor comment: * traceFileStream (and even the preexisting mainArgument) is accessed only inside GenerateJLIClassesPlugin. Could be private? -Sundar On 04/09/20 3:41 am, Yumin Qi wrote: HI, Mandy   Thanks for review and comment. Yumin On 9/3/20 9:13 AM, Mandy Chung

Re: RFR: 8252740: java/util/Properties/LoadAndStoreXMLWithDefaults.java fails after JDK-8252354(Internet mail)

Thanks Joe for your review. Pushed. Best regards, Jie On 2020/9/4, 12:18 AM, "Joe Wang" wrote: On 9/3/20 2:51 AM, Alan Bateman wrote: > On 03/09/2020 10:22, jiefu(傅杰) wrote: >> Hi all, >> >> JBS:https://bugs.openjdk.java.net/browse/JDK-8252740 >> Webrev: h

Re: RFR 8214761 : Bug in parallel Kahan summation implementation

Hello, Thanks for the nudge; I'll get to this sometime after the Skara transition for jdk/jdk. Cheers, -Joe On 9/3/2020 9:29 AM, Chris Dennis wrote: In case there is a need for extra motivation here: import java.util.stream.DoubleStream; public class Test8214761 { public static void ma

Re: RFR: 8252725: Refactor jlink GenerateJLIClassesPlugin code

HI, Mandy   Thanks for review and comment. Yumin On 9/3/20 9:13 AM, Mandy Chung wrote: On 9/3/20 8:36 AM, Yumin Qi wrote: Hi, Please review bug: https://bugs.openjdk.java.net/browse/JDK-8252725 webrev: http://cr.openjdk.java.net/~minqi/2020/8252725/webrev-01/ Looks good to me.   Sund

Re: RFR 8251989: Hex formatting and parsing

> Are there current hex formatting in code you are aware of that already uses > prefixes or suffixes on each byte? > Java. My example. > { 0x00, 0x01, 0x02, 0xOD, 0x0E, 0x0F } Douglas > On Sep 3, 2020, at 2:24 PM, core-libs-dev-requ...@openjdk.java.net wrote: > > Date: Thu, 3 Sep 2020

JDK-8173585: Intrinsify StringLatin1.indexOf(char)

Hi All, Please review the following patch: https://bugs.openjdk.java.net/browse/JDK-8173585 http://cr.openjdk.java.net/~phh/8173585/webrev.00/ This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1 byte encoded Strings). It is provided for x86 and ARM64. The implementation

Re: jpackage: support for environment variables in --java-options

>> >> This is not how I’ve done it before. I did a little googling and it seemed >> to indicate launchctl could somehow be used for ‘global’ environment >> variables. It didn’t sound application specific. > > Right it isn’t application specific. If you need a separate environment for > you

Re: RFR 8251989: Hex formatting and parsing

Hi Roger, In Formatter (1) The javadoc reads: "Returns up to sixteen [...]" rather than "Returns sixteen [...]", similar to the other toHex() methods. (2) equals() and hashCode() are missing. In Parser (1) In methods fromHex(), isHex(), xxxFromHex(), you probably meant "static" rather tha

Re: RFR 8251989: Hex formatting and parsing

Hi Douglas, I think you answered your own question at the outset. (with the API as it stands). Are there current hex formatting in code you are aware of that already uses prefixes or suffixes on each byte? I'm evauating whether there is consensus to change the semantics of prefix and suffix.

Re: RFR 8252537: Replace @exception with @throws for core-libs

Thanks for doing this! 15 years ago I considered taking on this task, eventually backing away because it was too much work (!). But I made sure most of the classes I maintained were using @throws. When considering this, I thought that tidying the whitespace after conversion would be a big part o

Re: RFR 8252537: Replace @exception with @throws for core-libs

Hi Vipin I can sponsor once the review is complete as a vast majority are in java.sql I will look at this tomorrow > On Sep 3, 2020, at 3:33 PM, Vipin Sharma wrote: > > Hi, > > Please review and sponsor the fix for replacing @exception with @throws for > core-libs. > > Issue: https://bugs.o

RFR 8252537: Replace @exception with @throws for core-libs

Hi, Please review and sponsor the fix for replacing @exception with @throws for core-libs. Issue: https://bugs.openjdk.java.net/browse/JDK-8252537 Webrev: https://cr.openjdk.java.net/~vsharma/8252537 As suggested in the previous discussion

Re: RFR 8252538: Replace @exception with @throws java.rmi package

> On 3 Sep 2020, at 18:51, Vipin Sharma wrote: > > I agree. In the next patch, I will include all remaining occurrences of > @exception in the core-libs > area. > > Also, I noticed that those files still use the markup. >> Converting them to use {@c

Re: jpackage: support for environment variables in --java-options

> On Sep 3, 2020, at 8:55 AM, Michael Hall wrote: > > > >> On Sep 3, 2020, at 7:12 AM, Scott Palmer > > wrote: >> >> >> >>> On Sep 3, 2020, at 4:26 AM, Michael Hall >> > wrote: >>> >>> >>> On Sep 2, 2020, at 10:07 PM, Scott Pal

Re: RFR(L) 8244778 Archive full module graph in CDS

On 8/31/2020 11:31 AM, Ioi Lam wrote: Hi Lois, Thanks for the review. Your comments has led me to discover a couple of pretty serious issues, which hopefully I have fixed. Also the code is cleaner now, with much fewer control-flow changes than the last webrev. http://cr.openjdk.java.net/~ik

Re: RFR 8252538: Replace @exception with @throws java.rmi package

Hi Roger, On Thu, Sep 3, 2020 at 2:20 AM Roger Riggs wrote: > Hi Vipin, > > Looks fine. > > I see you filed separate tasks for the other packages in java.rmi. [1] > That's unnecessarily fine grained. > It would be more efficient to do them all in one code review, saving your > time and reviewers

Re: RFR 8214761 : Bug in parallel Kahan summation implementation

In case there is a need for extra motivation here: import java.util.stream.DoubleStream; public class Test8214761 { public static void main(String[] args) { double a = Double.valueOf(args[0]); if (Math.ulp(a) <= Math.ulp(Math.nextAfter(a, 0))) { System.out.println("Stable addition

Re: RFR: 8252740: java/util/Properties/LoadAndStoreXMLWithDefaults.java fails after JDK-8252354

On 9/3/20 2:51 AM, Alan Bateman wrote: On 03/09/2020 10:22, jiefu(傅杰) wrote: Hi all, JBS:    https://bugs.openjdk.java.net/browse/JDK-8252740 Webrev: http://cr.openjdk.java.net/~jiefu/8252740/webrev.00/ After JDK-8252354, properties whose keys or values are none strings won't be skipped an

Re: RFR: 8252725: Refactor jlink GenerateJLIClassesPlugin code

On 9/3/20 8:36 AM, Yumin Qi wrote: Hi, Please review bug: https://bugs.openjdk.java.net/browse/JDK-8252725 webrev: http://cr.openjdk.java.net/~minqi/2020/8252725/webrev-01/ Looks good to me.   Sundar should also review it. A few things to mention compared to the proposed patch from 8247

Re: RFR: 8252725: Refactor jlink GenerateJLIClassesPlugin code

Sorry push "send" too soon: Tests: local build. mach5 tier1-4 have 2 timeouts on build which I think related to lab move(?). Thanks Yumin On 9/3/20 8:36 AM, Yumin Qi wrote: Hi, Please review bug: https://bugs.openjdk.java.net/browse/JDK-8252725 webrev: http://cr.openjdk.java.net/~minqi/

RFR: 8252725: Refactor jlink GenerateJLIClassesPlugin code

Hi, Please review bug: https://bugs.openjdk.java.net/browse/JDK-8252725 webrev: http://cr.openjdk.java.net/~minqi/2020/8252725/webrev-01/ Summary: The work is part of 8247536, which supports archive pre-generated java.lang.invoke classes in CDS. In this patch (thanks to Mandy): 1. Two metho

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic)

Hi Joe, I modified the values in method testDivideAndRemainder(), without touching the logic. The values are odd and even dividends and divisors around 0, 2^31, 2^32, 2^33, 2^63 and 2^64. Is this OK? Greetings Raffaello On 2020-09-02 23:26, Raffaello Giulietti wrote: will do in the ne

Re: RFR: 8252740: java/util/Properties/LoadAndStoreXMLWithDefaults.java fails after JDK-8252354(Internet mail)

Thanks Alan for your review. Will push it tomorrow. Best regards, Jie From: Alan Bateman Sent: Thursday, September 3, 2020 5:51 PM To: jiefu(傅杰); core-libs-dev@openjdk.java.net Subject: Re: RFR: 8252740: java/util/Properties/LoadAndStoreXMLWithDefaults.java

Re: RFC: 8229469 JEP 386: Alpine Linux/x64 Port

On 01/09/2020 12:41, Aleksei Voitylov wrote: Hi, JEP 386 is now Candidate [1] and as we resolved all outstanding issues within the Portola project I'd like to ask for comments from HotSpot, Core Libs (changes in libjli/java_md.c), and Build groups before moving the JEP to Proposed to Target: ht

Re: jpackage: support for environment variables in --java-options

> > The incident mentioned earlier showed a resolution of having the user provide > their own custom Info.plist. While plain old edit would probably be fine for > this some sort of code to provide it without manual intervention might also > be nice. I believe I have some old code lying around t

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic)

Hi Brian, setting up µ-benchmarks to get meaningful results on code that has execution paths with quite different shapes, like the current and the patched one, requires some care. I chose to exercise all paths at each iteration rather than to rely on a high iteration count. Without real worl

Re: jpackage: support for environment variables in --java-options

> On Sep 3, 2020, at 7:12 AM, Scott Palmer wrote: > > > >> On Sep 3, 2020, at 4:26 AM, Michael Hall > > wrote: >> >> >> >>> On Sep 2, 2020, at 10:07 PM, Scott Palmer >> > wrote: >>> >>> There is already a way to supply a custom Info.p

Re: jpackage: support for environment variables in --java-options

> On Sep 3, 2020, at 4:26 AM, Michael Hall wrote: > > > >> On Sep 2, 2020, at 10:07 PM, Scott Palmer > > wrote: >> >> There is already a way to supply a custom Info.plist. >> That can have the LSEnvironment entries you want. >> >> https://bugs.openjdk.java.net/

Re: RFR: 8249694 - [TestBug] java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @ignore-d

Looks fine to me. regards, Sean. On 03/09/2020 11:40, Fernando Guallini wrote: Hi Sean, Right, it also applies for these tests, changes: --- a/test/jdk/java/lang/StringBuffer/HugeCapacity.java +++ b/test/jdk/java/lang/StringBuffer/HugeCapacity.java - * @requires os.maxMemory >= 6G + * @requires

Re: RFR: 8249694 - [TestBug] java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @ignore-d

Hi Sean, Right, it also applies for these tests, changes: --- a/test/jdk/java/lang/StringBuffer/HugeCapacity.java +++ b/test/jdk/java/lang/StringBuffer/HugeCapacity.java - * @requires os.maxMemory >= 6G + * @requires (sun.arch.data.model == "64" & os.maxMemory >= 6G) --- a/test/jdk/java/lang/String

Re: RFR: 8252740: java/util/Properties/LoadAndStoreXMLWithDefaults.java fails after JDK-8252354

On 03/09/2020 10:22, jiefu(傅杰) wrote: Hi all, JBS:https://bugs.openjdk.java.net/browse/JDK-8252740 Webrev: http://cr.openjdk.java.net/~jiefu/8252740/webrev.00/ After JDK-8252354, properties whose keys or values are none strings won't be skipped any more. Instead, ClassCastException will be

RFR: 8252740: java/util/Properties/LoadAndStoreXMLWithDefaults.java fails after JDK-8252354

Hi all, JBS:https://bugs.openjdk.java.net/browse/JDK-8252740 Webrev: http://cr.openjdk.java.net/~jiefu/8252740/webrev.00/ After JDK-8252354, properties whose keys or values are none strings won't be skipped any more. Instead, ClassCastException will be thrown. So this part of testing code i

Re: jpackage: support for environment variables in --java-options

> On Sep 2, 2020, at 10:07 PM, Scott Palmer wrote: > > There is already a way to supply a custom Info.plist. > That can have the LSEnvironment entries you want. > > https://bugs.openjdk.java.net/browse/JDK-8233175 > > > I was under the im