Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

Hi Max, I looked at updating the warning string but figured that it might have been of no interest to end users. How about this edit then ? +    {"posix.attributes.detected", "POSIX file permission attributes detected. These attributes are ignored when signing and are not protected by th

Re: Review request for JDK-8251538: Modernize and lint Dynalink code

Looks good. Thanks for doing this cleanup! -Sundar On 21/08/20 2:10 am, Attila Szegedi wrote: Following up on the previous e-mail, here’s the modernization and linting work on the existing Dynalink codebase: Please review JDK-8251538 "Modernize and lint Dynalink code" at

RFR 8251989: Hex formatter and parser utility

Please review updates to the formatting and parsing API based on the last round of comments. There are many changes, so it may be useful to read it as a fresh draft.  - Rename classes: Encoder -> Formatter; Decoder -> Parser  - Rename methods: encode -> format; decode -> parse, etc.  - Rename fa

Re: RFR 8251989: Hex encoder and decoder utility

Hi Mark, The updates to the API based on the comments received are in the works. On 8/25/20 8:01 PM, mark.reinh...@oracle.com wrote: 2020/8/20 13:59:39 -0700, roger.ri...@oracle.com: On 8/20/20 3:10 PM, mark.reinh...@oracle.com wrote: ... A few comments: - Why do the short-form `encoder

Re: RFR 8251989: Hex encoder and decoder utility

Paul, Thanks for the review, there are a number of updates pending. On 8/24/20 4:55 PM, Paul Sandoz wrote: Hi Roger, A nice minimal addition. I agree with Mark’s naming suggestion. - Use appropriate code convention for static field names. - The encoder comes with two encoding production sign

Re: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

Hi Martin, Some inline responses below. On 8/26/20 8:26 AM, Doerr, Martin wrote: Hi Corey, I should explain my comments regarding Base64.java better. Let's be precise: "should process a multiple of four" => "must process a multiple of four" Did you try to support non-multiple of 4 and this

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

Are you going to update the warning text or create a new one? Thanks, Max > On Aug 26, 2020, at 2:26 PM, Seán Coffey wrote: > > This is a follow on from the recent 8218021 fix. The jarsigner tool removes > symlink attribute data from zipfiles when signing them. jarsigner should > preserve thi

Re: RFR: JDK-8242451 : ensure semantics of non-capturing lambdas are preserved independent of execution mode

On 8/26/20 10:16 AM, Gilles Duboscq wrote: Hi Mandy, Thanks for your review. I have added a test as you suggested and switched to `.descriptorString()`. https://cr.openjdk.java.net/~gdub/8242451/webrev.2/ Looks fine.    This test is a javac test.  I'm including compiler-dev if anyone ha

Re: RFR: JDK-8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore

test/jdk/java/util/Base64/TestEncodingDecodingLength.java is an example of another test using -Xmx8g. Do you want to push the os.maxMemory requirement up to 10g perhaps ? It might avoid border line resource failures. Also I think it might need a "sun.arch.data.model == "64" " requirement : @r

RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

This is a follow on from the recent 8218021 fix. The jarsigner tool removes symlink attribute data from zipfiles when signing them. jarsigner should preserve this data. The fix involves preserving the 16 bits associated with the file attributes (instead of the current 12). That's done in ZipFil

RFR: JDK-8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore

Hi, Could I please get reviews and a sponsor for: webrev: http://cr.openjdk.java.net/~fguallini/8249699/webrev.00/ Testbug: https://bugs.openjdk.java.net/browse/JDK-8249699 The test wa

Re: RFR: JDK-8242451 : ensure semantics of non-capturing lambdas are preserved independent of execution mode

Hi Mandy, Thanks for your review. I have added a test as you suggested and switched to `.descriptorString()`. https://cr.openjdk.java.net/~gdub/8242451/webrev.2/ Gilles On 25/08/2020 19:23, Mandy Chung wrote: On 8/25/20 3:16 AM, Gilles Duboscq wrote: Since this patch caches a singleton i

Re: [NEW BUG] NumberFormat.parse fails in some scenarios

Hi Christoph, The behavior you are observing is what is expected with the CLDR provider, as the currency format is exactly the one that CLDR has for the de locale: https://unicode-org.github.io/cldr-staging/charts/37/by_type/numbers.number_formatting_patterns.html#53687a25c19b6481 I'd recomm

Re: RFR 8252265: Replace @exception with @throws java.util.logging package

Hi Lance, On 26/08/2020 17:55, Lance Andersen wrote: I did find it strange that FileHandler had a few methods which listed IllegalArgumentException multiple times (vs. including the possible scenarios for the exception as part of 1 @throws) as I have not noticed that elsewhere in the JDK but

Re: RFR 8252265: Replace @exception with @throws java.util.logging package

Hi Vipin, This looks good to me. Make sure to generate the API docs locally and eyeball them to double check that nothing is amiss. best regards, -- daniel On 26/08/2020 17:38, Vipin Sharma wrote: Hi, Please review and sponsor the fix for replacing @exception with @throws in java.util.loggin

Re: RFR 8252265: Replace @exception with @throws java.util.logging package

This looks ok overall. Not specific to your change but … I did find it strange that FileHandler had a few methods which listed IllegalArgumentException multiple times (vs. including the possible scenarios for the exception as part of 1 @throws) as I have not noticed that elsewhere in the JDK b

Re: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

Thanks for your careful review, Martin. I will consider what you have said, and reply with comments/questions and possibly a revised webrev if I think I can satisfy your concerns. Regards, - Corey On 8/26/20 8:26 AM, Doerr, Martin wrote: Hi Corey, I should explain my comments regarding Base

RFR 8252265: Replace @exception with @throws java.util.logging package

Hi, Please review and sponsor the fix for replacing @exception with @throws in java.util.logging package. Issue: https://bugs.openjdk.java.net/browse/JDK-8252265 Webrev: https://cr.openjdk.java.net/~vsharma/8252265/ It came up in the below discussion, starting this cleanup with java.util.logging

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

+1 > On Aug 26, 2020, at 7:46 AM, Aleks Efimov wrote: > > Hi Roger, Lance, Daniel, > > Thanks for your reviews and comments! > New webrev with suggested modifications can be viewed at this location: > http://cr.openjdk.java.net/~aefimov/8251182/01 > > The list of modifications: > - Added @java

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

On 8/26/20 4:00 AM, Alan Bateman wrote: On 21/08/2020 19:23, Joe Wang wrote: Pelase review a patch to add the missing @return, @throws, @param statements in the java.xml package (excluding the DOM component). JBS: https://bugs.openjdk.java.net/browse/JDK-8251561 CSR: https://bugs.openjdk.ja

RE: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

Hi Corey, I should explain my comments regarding Base64.java better. > Let's be precise: "should process a multiple of four" => "must process a > multiple of four" Did you try to support non-multiple of 4 and this was intended as recommendation? I think making it a requirement and simplifying th

Re: [NEW BUG] NumberFormat.parse fails in some scenarios

Hi Christoph, Its worth investigating, tracking the issue with: https://bugs.openjdk.java.net/browse/JDK-8252383 Bugs can be reported with:    https://bugreport.java.com/bugreport/ Thanks, Roger On 8/26/20 10:18 AM, Christoph Dreis wrote: Hi, A colleague of mine (filipe.silvest...@innogame

[NEW BUG] NumberFormat.parse fails in some scenarios

Hi, A colleague of mine (filipe.silvest...@innogames.com) approached me today that his code wasn’t working that converted a currency String into cents. Apparently, the code worked with Java 8 while it didn’t with 11+. public class Main { public static void main(String[] args) throws IOE

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Looks good,  Thanks for the updates. Roger On 8/26/20 8:17 AM, Daniel Fuchs wrote: Hi Aleksei, Thanks for taking this on. The new version looks good to me. best regards, -- daniel On 26/08/2020 12:46, Aleks Efimov wrote: Hi Roger, Lance, Daniel, Thanks for your reviews and comments! New w

RE: RFR: JDK-8252113: Move jfr man page into jfr module

Good idea. Will do. Best Regards Adam Farley IBM Runtimes Alan Bateman wrote on 26/08/2020 11:45:26: > From: Alan Bateman > To: Adam Farley8 , core-libs-dev d...@openjdk.java.net> > Date: 26/08/2020 11:45 > Subject: [EXTERNAL] Re: RFR: JDK-8252113: Move jfr man page into jfr module > >

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Hi Aleksei, Thanks for taking this on. The new version looks good to me. best regards, -- daniel On 26/08/2020 12:46, Aleks Efimov wrote: Hi Roger, Lance, Daniel, Thanks for your reviews and comments! New webrev with suggested modifications can be viewed at this location: http://cr.openjdk.j

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

Hi Alexander, --- src/java.base/unix/native/libnet/net_util_md.h why include pthread.h? SIGRTMAX is in signal.h on posix ( https://pubs.opengroup.org/onlinepubs/007908799/xsh/signal.h.html). I see the old code included this too, pretty sure this was either incidental or just wrong. --- Are the

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Hi Roger, Lance, Daniel, Thanks for your reviews and comments! New webrev with suggested modifications can be viewed at this location: http://cr.openjdk.java.net/~aefimov/8251182/01 The list of modifications: - Added @java.io.Serial annotation to 'serialVersionUID' declarations - Removed trailin

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

On 21/08/2020 19:23, Joe Wang wrote: Pelase review a patch to add the missing @return, @throws, @param statements in the java.xml package (excluding the DOM component). JBS: https://bugs.openjdk.java.net/browse/JDK-8251561 CSR: https://bugs.openjdk.java.net/browse/JDK-8251995 webrev: http://cr

Re: RFR(L) 8244778 Archive full module graph in CDS

On 12/08/2020 23:06, Ioi Lam wrote: Hi Lois, Thanks for the comments. I have an updated webrev http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v02/ http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v02.delta/ Here are the general notes on

Re: RFR: JDK-8252113: Move jfr man page into jfr module

On 20/08/2020 18:58, Adam Farley8 wrote: Hi All, Should jfr.1 be moved from java.base to the jdk.jfr module source directory, as indicated here? Webrev: http://cr.openjdk.java.net/~afarley/8252113/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8252113 Seems right, on the surface at lea

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

On 25/08/2020 18:00, Alexander Scherbatiy wrote: Hello, Could your review the fix for the issue:   Bug: https://bugs.openjdk.java.net/browse/JDK-8252248   Fix: http://cr.openjdk.java.net/~alexsch/8252248/webrev.00/ : The fix has been discussed on the portola-dev alias [2] where it was pointe