Hi Naoto,
Looks good overall. One nit, blocks 1633-1639 and 1642-1649 may share a
common private method with a parameter that takes either matchedPosIndex
or matchedNegIndex, if you want.
Best,
Joe
On 8/17/20 4:42 PM, naoto.s...@oracle.com wrote:
Hi Joe,
It turned out that the previous fix
Hi David.
Thanks.
-Sundar
On 18/08/20 8:04 am, David Holmes wrote:
Hi Sundar,
On 18/08/2020 12:25 pm, sundararajan.athijegannat...@oracle.com wrote:
Not a full review of fresh changes. But couple of comments:
* src/hotspot/share/memory/lambdaFormInvokers.cpp and
src/hotspot/share/memory/la
Hi Sundar,
On 18/08/2020 12:25 pm, sundararajan.athijegannat...@oracle.com wrote:
Not a full review of fresh changes. But couple of comments:
* src/hotspot/share/memory/lambdaFormInvokers.cpp and
src/hotspot/share/memory/lambdaFormInvokers.hpp miss "Classpath
exception" clause in the copyrigh
Not a full review of fresh changes. But couple of comments:
* src/hotspot/share/memory/lambdaFormInvokers.cpp and
src/hotspot/share/memory/lambdaFormInvokers.hpp miss "Classpath
exception" clause in the copyright header
* I had suggested a change GenerateJLIClassesPlugin.java in last round
o
Hi Joe,
It turned out that the previous fix did not address plural format cases.
That means that just making the divisor negative to indicate
non-placeholder cannot distinguish multiple plural cases with the same
divisor. Instead, I created a list of placeholders (minimum digits) for
each ind
+1
Paul.
> On Aug 17, 2020, at 1:01 PM, Vicente Romero wrote:
>
> Please review this very simple fix for [1] at [2]. The fix is a very simple
> one liner change,
>
> Thanks,
> Vicente
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8246804
> [2] http://cr.openjdk.java.net/~vromero/8246804/we
+1
-Joe
On 8/17/2020 1:01 PM, Vicente Romero wrote:
Please review this very simple fix for [1] at [2]. The fix is a very
simple one liner change,
Thanks,
Vicente
[1] https://bugs.openjdk.java.net/browse/JDK-8246804
[2] http://cr.openjdk.java.net/~vromero/8246804/webrev.00/
Please review this very simple fix for [1] at [2]. The fix is a very
simple one liner change,
Thanks,
Vicente
[1] https://bugs.openjdk.java.net/browse/JDK-8246804
[2] http://cr.openjdk.java.net/~vromero/8246804/webrev.00/
Hi, Ioi
Thanks for review/suggestion. I have updated the webrev at the following link:
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-02/
Following changes done in this patch:
1) move regenerating holder classes into new added file:
lambdaFormInvokers.[ch]pp
"@lambda-form-invo
On 8/12/20 3:06 PM, Ioi Lam wrote:
Hi Lois,
Thanks for the comments. I have an updated webrev
http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v02/
http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v02.delta/
This is very good work.
Hi all,
This is a small fix that helps with some test cleanup. One redundant test file
has been removed.
Webrev found at: http://cr.openjdk.java.net/~kravikumar/8249691/webrev/
Link to JBS issue: https://bugs.openjdk.java.net/browse/JDK-8249691
Any follow up questions are welcomed.
Looks good.
- Alexey
On 8/14/2020 10:05 AM, Andy Herrick wrote:
Please review revised webrev [3] that does not check for client jvm
are (always use server)
/Andy
[3] - http://cr.openjdk.java.net/~herrick/8250611/webrev.02
On 8/13/2020 6:03 PM, Philip Race wrote:
Do I understand correctly th
On 8/16/20 7:35 PM, Andrew Haley wrote:
On 15/08/2020 10:13, Peter Levart wrote:
https://github.com/openjdk/jdk/pull/9
Sorry for abusing GitHub pull request mechanism but I don't have
bandwidth currently to clone the mercurial repository ;-)
That's a lot of work to avoid a simple fence.
Tw
13 matches
Mail list logo
