Re: 8245304: Re-examine ThreadLocal usage in java.math.BigDecimal

2020-08-11 Thread Alan Bateman
On 11/08/2020 18:32, Brian Burkhalter wrote: To fix [1], please consider [2] which replaces the ThreadLocal “threadLocalStringBuilderHelper” with straightforward use of a StringBuilderHelper instance. The initial capacity of the StringBuilder instance variable of StringBuilderHelper is also do

Re: 8245304: Re-examine ThreadLocal usage in java.math.BigDecimal

2020-08-11 Thread Joe Darcy
Looks fine; thanks, -Joe On 8/11/2020 10:32 AM, Brian Burkhalter wrote: To fix [1], please consider [2] which replaces the ThreadLocal “threadLocalStringBuilderHelper” with straightforward use of a StringBuilderHelper instance. The initial capacity of the StringBuilder instance variable of S

Re: Fwd: RFR: 8247536: Support pre-generated MethodHandle lambda forms in CDS

2020-08-11 Thread Ioi Lam
Hi Yumin, This looks good! Here are my comments: [1] classListParser.cpp: #define LAMBDA_FOMRM_INVOKER "@lambda-form-invoker" I think this should be moved to classListParser.hpp:     const char* lambda_form_invoker_tag() {     return "@lambda-form-invoker";     } Also, instead of also d

Re: Fwd: RFR(S): 8248188 Add HotSpotIntrinsicCandidate and API for Base64 decoding (repost to correct mailing list)

2020-08-11 Thread Corey Ashford
This is an accidental duplicate post. Please disregard. On 8/10/20 2:00 PM, Corey Ashford wrote: Hello, I had originally made two posts to the hotspot-compiler-dev and ppc-aix-port-dev mailing lists, but since this RFR requires modifying the core library code, it makes sense to post it to co

Re: 8181919: Refactor test/java/io/File/GetXSpace.sh to java test

2020-08-11 Thread Brian Burkhalter
A revised version [A] is available pursuant to the changes made in the course of the review [B] of the fix for [C]. Thanks, Brian [A] http://cr.openjdk.java.net/~bpb/8181919/webrev.01/ [B] http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068094.html [C] https://bugs.openjdk.java

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

2020-08-11 Thread Patrick Concannon
Hi, Please find the next iteration of mapMulti in the new webrev below. In this iteration the following changes have been made: The API note for mapMulti has been updated. Sub-interfaces for {Int, Double, Long}Stream have been refactored to be more specific to mapMulti. The examples have been c

Re: Review Request JDK-8244090: public lookup should find public members of public exported types

2020-08-11 Thread Mandy Chung
It was agreed in an offline discussion with Lois, Kim and John that this work should wait for the integration of JDK-8247938 and JEP 347 Enable C++ 14 features. This patch is updated to use scoped enum consistent with JDK-8247938. Updated webrev: http://cr.openjdk.java.net/~mchung/jdk16/webre

Fwd: RFR(S): 8248188 Add HotSpotIntrinsicCandidate and API for Base64 decoding (repost to correct mailing list)

2020-08-11 Thread Corey Ashford
Hello, I had originally made two posts to the hotspot-compiler-dev and ppc-aix-port-dev mailing lists, but since this RFR requires modifying the core library code, it makes sense to post it to core-lib-devs instead. The two original posts: https://mail.openjdk.java.net/pipermail/ppc-aix-port

Fwd: RFR: 8247536: Support pre-generated MethodHandle lambda forms in CDS

2020-08-11 Thread Yumin Qi
Forget to send to @core-lib-dev, the patch changed jdk code. Thanks Yumin Forwarded Message Subject:RFR: 8247536: Support pre-generated MethodHandle lambda forms in CDS Date: Tue, 11 Aug 2020 07:44:34 -0700 From: Yumin Qi To: hotspot-runtime-...@openjdk.ja

Re: [15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

2020-08-11 Thread Igor Ignatyev
Hi Arno, We haven't seen such failures in our infra, I guess we just need to add ^ to the beginning of the pattern. please file a bug and send a proper RFR for it and will be happy to run the patch in our testing infra for you. Cheers, -- Igor > On Aug 11, 2020, at 6:39 AM, Zeller, Arno wrote

8245304: Re-examine ThreadLocal usage in java.math.BigDecimal

2020-08-11 Thread Brian Burkhalter
To fix [1], please consider [2] which replaces the ThreadLocal “threadLocalStringBuilderHelper” with straightforward use of a StringBuilderHelper instance. The initial capacity of the StringBuilder instance variable of StringBuilderHelper is also doubled from 16 to 32. Microbenchmarking was eff

RE: [15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

2020-08-11 Thread Zeller, Arno
Hi Igor, after our push I see test/java/io/File/GetXSpace.java failing on our Windows test machines. The issue seems to be that the 'df' call produces several lines of output on my windows machine and the pattern uses \n as line-ending. In a short test I changed the regex to match $ instead of

Re: Possible subtle memory model error in ClassValue

2020-08-11 Thread Andrew Haley
On 11/08/2020 12:03, Andrew Dinn wrote: > You ought to look at the pdf Ningsheng linked in the RFR that was posted > with the SVE patch. The pdf is available here: > >https://developer.arm.com/docs/ddi0584/latest > > The relevant text is in section 4.4. Memory Ordering. That looks better than

Re: RFR[testbug]: 8251189: com/sun/jndi/ldap/LdapDnsProviderTest.java failed due to timeout

2020-08-11 Thread Vyom Tiwari
+1 Vyom On Tue, Aug 11, 2020 at 4:39 PM Daniel Fuchs wrote: > Hi Aleksei, > > Looks good to me! > > best regards, > > -- daniel > > On 06/08/2020 13:44, Aleks Efimov wrote: > > Hi, > > > > LdapDnsProviderTest was seen failing due to the timeout caused by the > > blocked bind operation. That coul

Re: RFR [testbug]: 8250772: Test com/sun/jndi/ldap/NamingExceptionMessageTest.java fails intermittently with javax.naming.ServiceUnavailableException

2020-08-11 Thread Daniel Fuchs
Hi Aleksei, I agree that this is the best fix for this issue. best regards, -- daniel On 06/08/2020 23:21, Aleks Efimov wrote: Hi, Please, help to review NamingExceptionMessageTest test stabilization change: There is a race condition between the closure of connection in test LDAP server an

Re: RFR[testbug]: 8251189: com/sun/jndi/ldap/LdapDnsProviderTest.java failed due to timeout

2020-08-11 Thread Daniel Fuchs
Hi Aleksei, Looks good to me! best regards, -- daniel On 06/08/2020 13:44, Aleks Efimov wrote: Hi, LdapDnsProviderTest was seen failing due to the timeout caused by the blocked bind operation. That could happen if there is a local process listening on the port specified in the test URL. To

Re: Possible subtle memory model error in ClassValue

2020-08-11 Thread Andrew Dinn
On 11/08/2020 11:47, Andrew Haley wrote: > On 09/08/2020 18:55, Hans Boehm wrote: >> There is no guarantee that the address dependency enforces ordering >> if there is no final field involved. This may matter in the future, >> since ARM's Scalable Vector Extension does not guarantee ordering >> for

Re: Possible subtle memory model error in ClassValue

2020-08-11 Thread Andrew Haley
On 09/08/2020 18:55, Hans Boehm wrote: > There is no guarantee that the address dependency enforces ordering > if there is no final field involved. This may matter in the future, > since ARM's Scalable Vector Extension does not guarantee ordering > for address-dependent loads, if both loads are ve