Re: RFR: JDK-8222187: java.util.Base64.Decoder stream adds unexpected null bytes at the end

2020-07-19 Thread Lance Andersen
Hi Raffaello, I think the changes look reasonable. I have created a webrev, http://cr.openjdk.java.net/~lancea/8222187/webrev.00/ , for others to review as it is a bit easier than the patch. I have also run the JCK tests in this area as we

Re: RFR: 8248655: Support supplementary characters in String case insensitive operations

2020-07-19 Thread naoto . sato
Hi Mark, Thank you for your comments. On 7/17/20 8:03 PM, Mark Davis ☕ wrote: One option is to have a fast path that uses char functions, up to the point where you hit a high surrogate, then drop into the slower codepoint path. That saves time for the high-runner cases. On the other hand, if

Re: [15] RFR(S) : 8249700 : java/io/File/GetXSpace.java should be added to exclude list, and not @ignore-d

2020-07-19 Thread Alan Bateman
On 19/07/2020 05:28, Igor Ignatyev wrote: : the patch also includes minimal changes to make the test runnable on macosx, which reveled that the test might fail on macos. 8249703 has been filed for that issue and the appropriate changes are done in ProblemList.txt. webrev: http://cr.openjdk.jav

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

2020-07-19 Thread Lisa Li
Hi Julia, Apologies for the delay. Please review the updated fix for JDK-8245694 . Also, my name is on the contributor list as: Yu Li - OpenJDK - yuli. *BUG DESCRIPTION*: JDK-8245694 : java.uti