Re: RFR: 8196334: Optimize UUID#fromString

Sounds reasonable. I think the current proposal is clearly a progress, so it looks good. I agree that any further optimization can be considered within a separate enhancement request. With kind regards, Ivan On 2/28/20 2:59 PM, Claes Redestad wrote: Hi Ivan, I've considered trying it out,

Re: RFR: 8196334: Optimize UUID#fromString

Hi Ivan, I've considered trying it out, but it gets complicated as we don't want to penalize -XX:-UseCompactStrings. I think adding special methods for UUID inside StringLatin1 is a step in the wrong direction, but maybe there's something more generic we can consider. However, short of adding St

Re: RFR: 8196334: Optimize UUID#fromString

Hi Claes and Andriy! It looks good overall. I wonder if it'll be even faster if the fast path were implemented in StringLatin1 (for compact strings only) and was called via SharedSecrets/JavaLangAccess? Then, you could operate directly on bytes and avoid dealing with longs. With kind regard

Re: RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

Welcome to the troublesome world of zip implementations! It looks like by creating a new JarEntry you are discarding possible information from the old one, e.g. you might be discarding whether the input entry was compressed. If "jar u" does that, I would consider it a bug! Arguably there is a mi

RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

Hi, can I please have a review for this small test fix: http://cr.openjdk.java.net/~simonis/webrevs/2020/8240235/ https://bugs.openjdk.java.net/browse/JDK-8240235 JarUtils.updateJar() and JarUtils.updateJarFile() update jar files by reading JarEntry-s from a source jar file and writing these exa

Re: RFR(S): 8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file

On Fri, Feb 28, 2020 at 6:11 PM Alan Bateman wrote: > > > > On 28/02/2020 15:39, Martin Buchholz wrote: > > LGTM. > > We're all resisting the urge to modernize this test. > > > yeah, that is a very old test. The change looks good to me too. > Thanks, Alan! > -Alan

Re: RFR(S): 8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file

On 28/02/2020 15:39, Martin Buchholz wrote: LGTM. We're all resisting the urge to modernize this test. yeah, that is a very old test. The change looks good to me too. -Alan

Re: RFR: removing dead code from jar tool

sigh it is being removed it appears by the mail server I placed a copy here: http://cr.openjdk.java.net/~lancea/JDK-8230117.patch > On Feb 28, 2020, at 12:00 PM, Lance Andersen > wrote: > > Here it is again > >> On Feb 28, 2020, at 11:07

Re: RFR: removing dead code from jar tool

Here it is again > On Feb 28, 2020, at 11:07 AM, Sean Mullan wrote: > > I think you forgot to attach the patch. > > --Sean > > On 2/28/20 2:28 AM, Adam Sotona wrote: >> Hi, >> I would like to ask for review of the attached patch removing dead code from >> jar tool >> Class files sun.tools.jar

Re: RFR: removing dead code from jar tool

I think you forgot to attach the patch. --Sean On 2/28/20 2:28 AM, Adam Sotona wrote: Hi, I would like to ask for review of the attached patch removing dead code from jar tool Class files sun.tools.jar.Manifest and sun.tools.jar.SignatureFile appear to be dead code and should be removed. Buil

Re: RFR(S): 8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file

On Fri, Feb 28, 2020 at 4:40 PM Martin Buchholz wrote: > > LGTM. Thanks, for your review Martin. > We're all resisting the urge to modernize this test. I have some more zip-related fixes in the queue :) > > On Fri, Feb 28, 2020 at 5:17 AM Volker Simonis > wrote: >> >> Hi, >> >> can I please

Re: RFR(S): 8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file

LGTM. We're all resisting the urge to modernize this test. On Fri, Feb 28, 2020 at 5:17 AM Volker Simonis wrote: > Hi, > > can I please get a review for this trivial test fix: > > http://cr.openjdk.java.net/~simonis/webrevs/2020/8240226/ > https://bugs.openjdk.java.net/browse/JDK-8240226 > > The

RFR: 8196334: Optimize UUID#fromString

Hi all, please review this patch to optimize UUID#fromString. Jon Chambers originally proposed a patch that used a strict parser to get a similar speed-up, but I failed to adapt it in a way that could fall back to the less strict behavior while maintaining a reasonable speed-up in the fast-path

Re: RFR(s): 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111

Hi Bob, On Thu, 2020-02-27 at 15:04 -0500, Bob Vandette wrote: > The updates look fine to me. Thanks for the review! > Have you scanned through all tests looking for “.length” and [0] to > see if we have any more cases that need updating? I have now and haven't found any places where it's inco

RFR(S): 8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file

Hi, can I please get a review for this trivial test fix: http://cr.openjdk.java.net/~simonis/webrevs/2020/8240226/ https://bugs.openjdk.java.net/browse/JDK-8240226 The SkipBytes() subtest in DeflateIn_InflateOut.java executes several steps and for each step it deflates an array of 1024*1024 byte

Re: RFR: removing dead code from jar tool

Thank you, Adam > On 28 Feb 2020, at 12:57, Lance Andersen wrote: > > I think this looks OK. I did a search and did not find any usages so I > suspect this should be safe to do. > > Best > Lancee > >> On Feb 28, 2020, at 5:28 AM, Adam Sotona > > wrote: >> >>

Re: RFR: removing dead code from jar tool

I think this looks OK. I did a search and did not find any usages so I suspect this should be safe to do. Best Lancee > On Feb 28, 2020, at 5:28 AM, Adam Sotona wrote: > > Hi, > I would like to ask for review of the attached patch removing dead code from > jar tool > Class files sun.tools.ja

RFR: removing dead code from jar tool

Hi, I would like to ask for review of the attached patch removing dead code from jar tool Class files sun.tools.jar.Manifest and sun.tools.jar.SignatureFile appear to be dead code and should be removed. Build with the patch passes all Tier1, Tier2 and Tier3 tests. Thank you, Adam