Hi Nick :)
On 23/01/2020 5:25 pm, David Holmes wrote:
On 23/01/2020 5:08 pm, Nick Gasson wrote:
Hi Maurizio,
Yes, for jdk/jdk. Do I need another Reviewer?
Yes - specifically you need a reviewer from Hotspot! cc'ing
hotspot-runtime-dev :)
So on 32-bit size_t is 32-bit and so may have ~half
On 23/01/2020 5:08 pm, Nick Gasson wrote:
Hi Maurizio,
Yes, for jdk/jdk. Do I need another Reviewer?
Yes - specifically you need a reviewer from Hotspot! cc'ing
hotspot-runtime-dev :)
Cheers,
David
Thanks,
Nick
On 01/22/20 20:46 pm, Maurizio Cimadamore wrote:
Fixes look good to me - I
Hi Maurizio,
Yes, for jdk/jdk. Do I need another Reviewer?
Thanks,
Nick
On 01/22/20 20:46 pm, Maurizio Cimadamore wrote:
> Fixes look good to me - I assume this is for JDK 15, right?
>
> Maurizio
>
> On 22/01/2020 08:43, Nick Gasson wrote:
>> Hi,
>>
>> Bug: https://bugs.openjdk.java.net/browse
Please review the jpackage fix for bug [1] at [2].
- Fixed by forcing signing even if runtime already signed.
- Original implementation was not taken in consideration that runtime
can be signed (JDK itself is signed from which jpackage is used or
runtime provided via --runtime-image).
- Signatu
Hello everyone!
When the input of a j.u.regex.Matcher is restricted with .region()
method, it can possibly cut off a half of a surrogate pair.
It turns out that greedy matching implemented in the
Pattern.CharPropertyGreedy class fails to recognize this edge case in
two scenarios:
1) When i
My sense is it is fixing a marginal case for the less dominant platform where
this is less likely arise, whereas for the dominant platform there is still an
issue.
Waiting for a non-blocking native read is a reasonable approach (IIUC that is
required for the desired proper fix). It would be us
> On Jan 22, 2020, at 11:06 AM, Mandy Chung wrote:
>
>
>
> On 1/22/20 1:53 AM, Severin Gehwolf wrote:
>> Hi Mandy,
>>
>> Thanks again for the review! I'll be sure to fix things. Some of the
>> issues you've pointed out probably pre-existed in old code. Some became
>> more complicated since u
On 1/22/20 1:53 AM, Severin Gehwolf wrote:
Hi Mandy,
Thanks again for the review! I'll be sure to fix things. Some of the
issues you've pointed out probably pre-existed in old code. Some became
more complicated since unlimited in cgroupv1 is a large long value in
files. Anyway, I'll update it
+1, looks good
On 1/22/20 4:55 AM, Stephen Colebourne wrote:
Looks good
Stephen
On Tue, 21 Jan 2020 at 21:53, wrote:
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8236903
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/823690
Fixes look good to me - I assume this is for JDK 15, right?
Maurizio
On 22/01/2020 08:43, Nick Gasson wrote:
Hi,
Bug: https://bugs.openjdk.java.net/browse/JDK-8237521
Webrev: http://cr.openjdk.java.net/~ngasson/8237521/webrev.01/
This is a follow-up to JDK-8236634 which just contained changes
Thank you Roger for review!
Pushed.
--
With kind regards,
Ivan Gerasimov
Looks good
Stephen
On Tue, 21 Jan 2020 at 21:53, wrote:
> Please review the fix to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8236903
>
> The proposed changeset is located at:
>
> http://cr.openjdk.java.net/~naoto/8236903/webrev.00/
>
> This edge case throws an out-of-bound
Hi Mandy,
Thanks again for the review! I'll be sure to fix things. Some of the
issues you've pointed out probably pre-existed in old code. Some became
more complicated since unlimited in cgroupv1 is a large long value in
files. Anyway, I'll update it.
On Tue, 2020-01-21 at 16:09 -0800, Mandy Chun
Hi,
Bug: https://bugs.openjdk.java.net/browse/JDK-8237521
Webrev: http://cr.openjdk.java.net/~ngasson/8237521/webrev.01/
This is a follow-up to JDK-8236634 which just contained changes to the
tests to make them build/pass on 32-bit systems for JDK 14. This patch
removes the test workarounds an
14 matches
Mail list logo
