looks good .
/Andy
On 9/29/2019 6:08 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
The fix adds use of `ldd` command and packaging specific tools to
build list of pack
Looks good.
On 9/29/2019 1:50 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- Improve jpackage test helpers.
- Implement jdk.jpackage.internal.ApplicationLayo
Hi Andy,
webrev.04 looks good.
Thanks,
Alexander
On 9/30/2019 1:09 PM, Andy Herrick wrote:
yes - I removed get, and the "instance" variable and just call load
(see: webrev.04).
we shouldn't actually call it with different base dir arg, except
possibly in a test.
/Andy
On 9/30/2019 4:07 P
Looks good.
On 9/29/2019 4:45 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Baseline for review is [3].
[1] https://bugs.openjdk.java.net/browse/JDK-8230974
[2] http:/
Looks good.
On 9/29/2019 3:08 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
The fix adds use of `ldd` command and packaging specific tools to
build list of packages req
yes - I removed get, and the "instance" variable and just call load
(see: webrev.04).
we shouldn't actually call it with different base dir arg, except
possibly in a test.
/Andy
On 9/30/2019 4:07 PM, Alexander Matveev wrote:
Looks good.
Do we really planning to call AppImageFile.get() with
Looks good.
Do we really planning to call AppImageFile.get() with different values?
I think removing or fixing is still better to avoid any potential bugs.
Thanks,
Alexander
On 9/29/2019 1:06 PM, Alexey Semenyuk wrote:
One thing that I just notice is that you introduced caching in
AppImageFi
Thank you Sean for reviewing!
With kind regards,
Ivan
On 9/27/19 7:20 AM, Sean Mullan wrote:
Hi Ivan,
The fix looks good. Good catch.
--Sean
On 8/30/19 7:32 PM, Ivan Gerasimov wrote:
Hello!
In the two implementations of
PermissionCollection.implies(Permission), all the permissions are
I will need to look at this closer. Skimming through the
implementation, it seems to me that the Runtime::loadLibrary0 does not
need to be synchronized. ClassLoader::loadLibrary0 should ensure that
a native library of a given name is loaded and registered only once.
Can you explain why yo
Hi Ralf,
> The test should not omit these two bytecodes because the current
> implementation is the same. This can change and it is not much additional code
> to add the two cases.
I implemented test cases for the missing invokes:
http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/20-increm
Hey Patrick,
I don't think that we need to add 8229338 to the bug line since it is
just test refactoring issue (noreg-self).
Otherwise, the changes look good to me!
With Best Regards,
Aleksei
On 27/09/2019 15:53, Patrick Concannon wrote:
Hi Lance,
Thanks for your feedback. I've added in t
Looks fine.
(Sorry to have needed the reminder to respond).
Roger
On 9/27/19 8:25 PM, Brian Burkhalter wrote:
Begin forwarded message:
From: Brian Burkhalter
Subject: Re: 8229333: java/io/File/SetLastModified.java timed out
Date: September 6, 2019 at 9:36:39 AM PDT
To: core-libs-dev
An al
On Sat, Sep 28, 2019 at 3:39 AM Peter Levart wrote:
>
> On 9/25/19 12:15 PM, Remi Forax wrote:
> > that said, i believe we should deprecate LinkedList (and any other List
> > implementation that doesn't implement RandomAccess) because there are too
> > much code out there that suppose that list.
Looks good.
- Alexey
On 9/30/2019 7:31 AM, Andy Herrick wrote:
Please review the revised jpackage fix for bug [1] at [4].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
I have removed the caching in AppImageFile and moved it to the caller,
in thi
looks good.
/Andy
ps: still studying the two prerequisite patches.
On 9/29/2019 7:45 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Baseline for review is [3].
[1] htt
Please review the revised jpackage fix for bug [1] at [4].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
I have removed the caching in AppImageFile and moved it to the caller,
in this case WinMsiBundler, where the knowledge resides that the value
Hey Martin,
great, that you got my issue. The link you shared is an interesting
basis for this discussion.
Maybe at some places e.g. in the "upfront specifications", additionally
the term "UTF-16 char" or "UTF-16 code unit" could be helpful and then
determining "char" or "{@code char}" as a short
Hi,
First of all, sorry in advance if there is a more appropriate place or
system to report this issue. I'm not yet familiar with reporting Java bugs.
Please let me know if that's the case.
I'm testing out jpackage (using the 14-jpackage+1-35 build at
https://jdk.java.net/jpackage/) and am seeing
18 matches
Mail list logo
