jpackage: better error messages when things go wrong ?

2019-05-19 Thread Jon Harper
Many things can go wrong when launching an app package with jpackage (1). If the app doesn't work enough to get basic logging, then the only error message you get is "Failed to launch JVM" (with javapackager form jdk 8 you also had "Error Invoking Method"..) I think it would be a great improvement

jpackage: uniform error messages on different platforms

2019-05-19 Thread Jon Harper
when things go wrong launching an app packaged with jpackage, the behavior is different accross platform: - on windows it show a popup - on other platforms it logs to stdout I think it would be better if the behavior was consistent: - provide popups on other platforms when the program is launched

Re: RFR 8223593 : Refactor code for reallocating storage

2019-05-19 Thread Peter Levart
Hi Ivan, Roger, What about "calcNewLength" ? The word "new" gives enough hint as to what the method does - it calculates the length of new array to be allocated instead of old one. Regards, Peter On 5/17/19 8:45 PM, Ivan Gerasimov wrote: Hi Roger! I think that not only the name, but also t

JDK 13 RFR of JDK-8224175: Fix inconsistencies in @jls and @jvms tags

2019-05-19 Thread Joe Darcy
Hello, Thanks to some tooling developed by Jon Gibbons, inconsistencies in the section names and numbers in the @jls and @jvms javadoc tags in the jdk and the names and numbers of the current specifications have been identified. These inconsistencies should be fixed. The names and numbers of

JDK 13 RFR of JDK-8224174: java.lang.Number has a default constructor

2019-05-19 Thread Joe Darcy
Hello, While doing some other work, I noticed that java.lang.Number relies on an implicit default constructor. Until there is a lint warning to find these cases systematically (JDK-8071961: Add javac lint warning when a default constructor is created), please review the diff below to address

Re: RFR: 8218781 : Localized names for Japanese Era Reiwa in COMPAT provider

2019-05-19 Thread li . jiang
Thank you, pushed. /Leo On 5/19/19 9:55 PM, naoto.s...@oracle.com wrote: Looks good. Naoto On 5/18/19 6:23 AM, li.ji...@oracle.com wrote: Hi Naoto, Please review the updated webrev: http://cr.openjdk.java.net/~ljiang/8218781/webrev.01/ In this update, renamed the data provider names and te

Re: RFR: 8218781 : Localized names for Japanese Era Reiwa in COMPAT provider

2019-05-19 Thread naoto . sato
Looks good. Naoto On 5/18/19 6:23 AM, li.ji...@oracle.com wrote: Hi Naoto, Please review the updated webrev: http://cr.openjdk.java.net/~ljiang/8218781/webrev.01/ In this update, renamed the data provider names and test case name to improve the readability. Thanks, Leo On 5/18/19 12:39 AM