Re: RFR: 8218781 : Localized names for Japanese Era Reiwa in COMPAT provider

2019-05-18 Thread li . jiang
Hi Naoto, Please review the updated webrev: http://cr.openjdk.java.net/~ljiang/8218781/webrev.01/ In this update, renamed the data provider names and test case name to improve the readability. Thanks, Leo On 5/18/19 12:39 AM, naoto.s...@oracle.com wrote: Hi Leo, Overall looks good. One com

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

2019-05-18 Thread Alan Bateman
On 09/05/2019 16:16, Langer, Christoph wrote: Hi Alan, I've got a new iteration for the zipfs POSIX support and addressed your concerns: http://cr.openjdk.java.net/~clanger/webrevs/8213031.9/ Thanks. I think you've addressed most of my points. The only thing that isn't clear is the group owner

Re: RFR: 8224112: [TESTBUG] java/util/Base64/TestEncodingDecodingLength.java should be skipped with insufficient memory

2019-05-18 Thread Jie Fu
Okay, I see. Thank you very much, Aleksey. On 2019/5/18 下午5:00, Aleksey Shipilev wrote: On 5/18/19 10:10 AM, Jie Fu wrote: If the memory isn't enough, the test won't run (filtered out by the "requires" tag) instead of being skipped in the previous patch. It fixes the false sense of passing p

Re: RFR: 8224112: [TESTBUG] java/util/Base64/TestEncodingDecodingLength.java should be skipped with insufficient memory

2019-05-18 Thread Jie Fu
Hi Alan, Oh, we just have 2G swap buffer on our machine. Yes, we do have observed some other intermittent failures due to memory/network/GUI reasons, but this case is the most frequently observed one. I just try to improve the test stability since it seems impossible to always keep others away

Re: RFR: 8224112: [TESTBUG] java/util/Base64/TestEncodingDecodingLength.java should be skipped with insufficient memory

2019-05-18 Thread Aleksey Shipilev
On 5/18/19 10:10 AM, Jie Fu wrote: > If the memory isn't enough, the test won't run (filtered out by the > "requires" tag) instead of > being skipped in the previous patch. It fixes the false sense of passing > problem pointed out by > Aleksey. Could you please review it and give me some advice?

Re: RFR: 8224112: [TESTBUG] java/util/Base64/TestEncodingDecodingLength.java should be skipped with insufficient memory

2019-05-18 Thread Alan Bateman
On 18/05/2019 02:17, Jie Fu wrote: Hi Alan, On 2019/5/17 下午11:00, Alan Bateman wrote: The issue isn't clear. The test only runs when on 64-bit systems with >= 10GB memory. Is the issue related to the -concurrency setting that you specify to jtreg? No. Even we set the concurrency=1, the issue

Re: RFR: 8224112: [TESTBUG] java/util/Base64/TestEncodingDecodingLength.java should be skipped with insufficient memory

2019-05-18 Thread Jie Fu
Hi all, Please review the updated version: http://cr.openjdk.java.net/~jiefu/8224112/webrev.01/ If the memory isn't enough, the test won't run (filtered out by the "requires" tag) instead of being skipped in the previous patch. It fixes the false sense of passing problem pointed out by Aleks